mirror of
https://github.com/openai/codex.git
synced 2026-10-20 08:19:50 +00:00
andrewgu-oaiandIan MacLeod
51215e9f88
Backport two reviewed upstream fixes onto the exact content parent of 0.159.0-alpha.12 for the desktop 260930 train: - Public #49019 (internal #10589),4fd5745e84: reuse unpackaged PowerShell fallback for local MXC. Remote, unsandboxed, restricted-token handling and elevated-only -NoProfile behavior are preserved. - Public #49704,5602705c96: keep newer npm alpha pointers unchanged when publishing an older frozen hotfix. The existing OIDC publisher uses version-specific tags; registry lookup failure aborts publication. No new credentials or permission changes. Both patches apply cleanly and match their upstream patch IDs. Eight files total, +360/-71; no extra dependencies or unrelated product changes. Frozen base:1cc7e23612. Intended publication: 0.159.0-alpha.12.1 through the exact-SHA-guarded branch publisher. Validation: just fmt and whitespace checks passed; all 50 focused PowerShell library tests passed; all 17 release/tag-selection tests passed. Initial product-only head passed all three production build checks (Linux/macOS/Windows); updated-head checks are pending. Native MXC execution is not claimed by Linux validation. The included Windows integration test skips if MXC is unavailable. Initial CI manifest-policy failure reproduces on the exact frozen base; Codespell and cargo-shear failures concern unchanged files. No unrelated lint fixes included. --------- Co-authored-by: Ian MacLeod <imac@openai.com>
Workflow Strategy
The workflows in this directory are split so that pull requests get fast, review-friendly signal while main still gets the full cross-platform verification pass.
Pull Requests
- Required checks run against GitHub's synthetic merge commit, not the pull
request head alone. This includes changes already on
mainand catches conflicts before they reach the branch. bazel.ymlis the main pre-merge verification path for Rust code. It runs Bazeltestand Bazelclippyon the supported Bazel targets, including the generated Rust test binaries needed to lint inline#[cfg(test)]code.rust-ci.ymlkeeps the Cargo-native PR checks intentionally small:cargo fmt --checkcargo shearargument-comment-linton Linux, macOS, and Windowstools/argument-comment-lintpackage tests when the lint or its workflow wiring changes
Post-Merge On main
bazel.ymlalso runs on pushes tomain. This re-verifies the merged Bazel path and helps keep the BuildBuddy caches warm.rust-ci-full.ymlis the full Cargo-native verification workflow. It keeps the heavier checks off the PR path while still validating them after merge:- the full Cargo
clippymatrix - the full Cargo
nextestmatrix via per-platform archive-backed shards - Windows ARM64 nextest archives cross-compiled on Windows x64, then replayed on native Windows ARM64 shards
- release-profile Cargo builds
- cross-platform
argument-comment-lint - Linux remote-env tests
- the full Cargo
Rule Of Thumb
- If a build/test/clippy check can be expressed in Bazel, prefer putting the PR-time version in
bazel.yml. - Keep
rust-ci.ymlfast enough that it usually does not dominate PR latency. - Reserve
rust-ci-full.ymlfor heavyweight Cargo-native coverage that Bazel does not replace yet.