Owen Lin 23aac925e7 feat(core): emit canonical review mode items (#31473) ...

## Description

This PR moves review-mode markers onto canonical `TurnItem` lifecycle:

- `TurnItem::EnteredReviewMode`
- `TurnItem::ExitedReviewMode`

Core now emits `ItemStarted` / `ItemCompleted` for both. The completed
items map back into the existing `EnteredReviewMode` /
`ExitedReviewMode` events, so raw core event consumers and legacy
rollout persistence keep seeing the old events.

This is the compatibility layer needed before paginated rollouts persist
review markers as `ItemCompleted(TurnItem)`.

## Why

Review markers were one of the remaining app-server thread items created
directly from legacy events. Giving them canonical items lets paginated
history persist stable turn/item IDs without changing legacy rollouts.

## What changed

- Added canonical review-mode `TurnItem`s and switched review flow to
emit their lifecycle.
- Added completed-item → legacy review event mappings with stable
turn/item IDs.
- Switched app-server live notifications to the generic canonical item
path and kept legacy replay compatible with old payloads.
- Updated `ThreadHistoryBuilder` to replay canonical review items even
though review turns still do not emit `TurnStarted`.

2026-07-08 09:59:50 -07:00

..

agent

Log multi-agent communication lifecycle (#30872)

2026-07-01 18:11:09 -07:00

apps

Make Apps guidance react to MCP availability (#30226)

2026-07-06 14:29:19 -07:00

bin

Refactor config types into a separate crate (#16962)

2026-04-07 00:32:41 +00:00

config

[codex] Enable auth elicitation by default (#28772)

2026-07-07 11:48:27 -07:00

context

Use model catalog approval messages (#31312)

2026-07-07 10:52:38 -07:00

context_manager

Use model catalog approval messages (#31312)

2026-07-07 10:52:38 -07:00

guardian

core: make AGENTS.md react to environment changes (#29810)

2026-06-24 22:57:42 -07:00

mcp_tool_call

Report MCP error codes with server attribution (#29969)

2026-06-24 21:08:39 -07:00

plugins

Make plugin guidance react to environment readiness (#30223)

2026-07-06 07:05:40 -07:00

sandboxing

Prepare managed network sandbox context (#29456)

2026-06-23 20:07:09 +01:00

session

feat(core): emit canonical review mode items (#31473)

2026-07-08 09:59:50 -07:00

state

elicitations: Move to shared ElicitationService (#30627)

2026-07-06 11:20:32 -07:00

tasks

feat(core): emit canonical review mode items (#31473)

2026-07-08 09:59:50 -07:00

tools

core: migrate standalone web search to extension-owned turn items (#31525)

2026-07-08 09:40:00 -07:00

unified_exec

feat(core): emit canonical command execution items (#31297)

2026-07-06 21:22:51 -07:00

utils

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

agent_communication.rs

Log multi-agent communication lifecycle (#30872)

2026-07-01 18:11:09 -07:00

agents_md_manager.rs

core: make AGENTS.md react to environment changes (#29810)

2026-06-24 22:57:42 -07:00

agents_md_tests.rs

core: make AGENTS.md react to environment changes (#29810)

2026-06-24 22:57:42 -07:00

agents_md.rs

core: make AGENTS.md react to environment changes (#29810)

2026-06-24 22:57:42 -07:00

apply_patch_tests.rs

path-uri: clarify host-native path conversion (#29501)

2026-06-23 00:02:33 +00:00

apply_patch.rs

apply-patch: carry paths as PathUri (#28854)

2026-06-18 19:31:19 +00:00

attestation.rs

[codex] request desktop attestation from app (#20619)

2026-05-08 12:36:02 -07:00

client_common_tests.rs

[codex] Support sequential cutoff reasoning summaries (#31306)

2026-07-06 23:23:56 -04:00

client_common.rs

[codex] Use input items for Responses Lite tools (#27946)

2026-06-22 23:56:16 -07:00

client_tests.rs

core: route Responses API through system proxy (#31335)

2026-07-07 03:49:53 +00:00

client.rs

[codex] Add externally provided Codex auth (#31274)

2026-07-07 17:43:19 -07:00

codex_delegate_tests.rs

Fix cancelled review leaving MCP startup busy (#31189)

2026-07-06 10:55:35 -04:00

codex_delegate.rs

Fix cancelled review leaving MCP startup busy (#31189)

2026-07-06 10:55:35 -04:00

codex_thread.rs

elicitations: Move to shared ElicitationService (#30627)

2026-07-06 11:20:32 -07:00

command_canonicalization_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

command_canonicalization.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

compact_model_fallback.rs

fix: retry rejected previous-model compaction with selected model (#30319)

2026-07-07 14:26:03 -07:00

compact_remote_request.rs

chore: extract remote compaction request attempts (#31316)

2026-07-07 12:57:19 -07:00

compact_remote_v2_attempt.rs

chore: extract remote compaction request attempts (#31316)

2026-07-07 12:57:19 -07:00

compact_remote_v2.rs

fix: retry rejected previous-model compaction with selected model (#30319)

2026-07-07 14:26:03 -07:00

compact_remote.rs

fix: retry rejected previous-model compaction with selected model (#30319)

2026-07-07 14:26:03 -07:00

compact_tests.rs

core: make AGENTS.md react to environment changes (#29810)

2026-06-24 22:57:42 -07:00

compact_token_budget.rs

core: make AGENTS.md react to environment changes (#29810)

2026-06-24 22:57:42 -07:00

compact.rs

[codex] rename rollout budget error to session budget error (#29744)

2026-06-23 16:49:13 -07:00

config_lock.rs

Use plugin-service MCP as the hosted plugin runtime (#27198)

2026-06-10 12:54:21 +02:00

connectors_tests.rs

[apps] Thread structured icon assets through app list (#29889)

2026-06-24 13:25:44 -07:00

connectors.rs

Make Apps guidance react to MCP availability (#30226)

2026-07-06 14:29:19 -07:00

consequential_tool_message_templates.json

[elicitation] User-friendly tool call messages. (#14403)

2026-03-12 00:35:21 -07:00

current_time.rs

[codex] route sleep through time providers (#29973)

2026-06-24 22:17:43 -07:00

elicitation_tests.rs

elicitations: Move to shared ElicitationService (#30627)

2026-07-06 11:20:32 -07:00

elicitation.rs

elicitations: Move to shared ElicitationService (#30627)

2026-07-06 11:20:32 -07:00

environment_selection.rs

Persist selected capability roots and resolve availability per model step (#29856)

2026-06-25 17:49:43 +00:00

event_mapping_tests.rs

core: add configurable <context_window_guidance> message (#29936)

2026-06-24 18:03:44 -07:00

event_mapping.rs

Make Apps guidance react to MCP availability (#30226)

2026-07-06 14:29:19 -07:00

exec_env_tests.rs

core: expose permission profile to shell tools (#29941)

2026-06-25 19:00:23 +00:00

exec_env.rs

core: expose permission profile to shell tools (#29941)

2026-06-25 19:00:23 +00:00

exec_policy_tests.rs

Preserve managed exec policy after rules parse errors (#31188)

2026-07-06 19:28:44 -07:00

exec_policy_windows_tests.rs

[codex] Respect Windows sandbox backend in exec policy (#26307)

2026-06-05 11:20:52 -07:00

exec_policy.rs

Preserve managed exec policy after rules parse errors (#31188)

2026-07-06 19:28:44 -07:00

exec_tests.rs

Add network environment ID plumbing (#28766)

2026-06-18 14:09:38 +02:00

exec.rs

Prepare managed network sandbox context (#29456)

2026-06-23 20:07:09 +01:00

function_tool.rs

feat: extract shared tool executor interface (#22359)

2026-05-13 11:31:27 +02:00

git_info_tests.rs

Pipeline bounded AGENTS.md and Git root probes (#29870)

2026-06-24 22:58:34 +01:00

hook_runtime.rs

Support thread-level originator overrides (#29477)

2026-06-23 17:23:38 -07:00

image_preparation_tests.rs

[codex] replace remote images with model-visible error text (#29417)

2026-06-22 16:41:00 -07:00

image_preparation.rs

[codex] Use input items for Responses Lite tools (#27946)

2026-06-22 23:56:16 -07:00

installation_id.rs

feat: split memories part 2 (#19860)

2026-04-28 13:03:28 +02:00

landlock.rs

linux-sandbox: switch helper plumbing to PermissionProfile (#20106)

2026-04-28 19:43:44 -07:00

lib.rs

feat(core): emit canonical review mode items (#31473)

2026-07-08 09:59:50 -07:00

mcp_openai_file.rs

Centralize Codex Apps client handling (#29528)

2026-06-23 00:00:25 -07:00

mcp_skill_dependencies.rs

Pin MCP runtimes to model steps (#30101)

2026-06-26 00:53:07 +01:00

mcp_tool_approval_templates.rs

Uprev Rust toolchain pins to 1.95.0 (#24684)

2026-05-26 20:59:47 -07:00

mcp_tool_call_tests.rs

[codex] Enable auth elicitation by default (#28772)

2026-07-07 11:48:27 -07:00

mcp_tool_call.rs

[codex-rs] Add writes app approval mode (#30482)

2026-07-07 13:13:59 -04:00

mcp_tool_exposure_test.rs

[apps] Thread structured icon assets through app list (#29889)

2026-06-24 13:25:44 -07:00

mcp_tool_exposure.rs

[codex] Use tool search for MCP tools by default (#29486)

2026-06-22 16:45:23 -07:00

mcp.rs

Make plugin guidance react to environment readiness (#30223)

2026-07-06 07:05:40 -07:00

memory_usage.rs

[codex] simplify memory read metrics (#28164)

2026-06-15 08:28:02 -07:00

mention_syntax.rs

Extract codex-utils-plugins crate (#15746)

2026-03-25 11:05:35 -07:00

network_policy_decision_tests.rs

fix: attribut network requests to the exact exec on linux (#29697)

2026-07-06 14:51:34 -07:00

network_policy_decision.rs

refactor(proxy): clarify sandbox block messages (#17168)

2026-04-09 10:53:06 -07:00

network_proxy_loader_tests.rs

Preserve managed exec policy after rules parse errors (#31188)

2026-07-06 19:28:44 -07:00

network_proxy_loader.rs

Preserve managed exec policy after rules parse errors (#31188)

2026-07-06 19:28:44 -07:00

original_image_detail.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

otel_init.rs

Add process-scoped SQLite telemetry (#22154)

2026-05-11 11:32:40 -07:00

personality_migration_tests.rs

feat(app-server): add history_mode to thread (#29927)

2026-06-26 09:12:42 -07:00

personality_migration.rs

feat(app-server): list descendant threads by ancestor (#29591)

2026-06-24 13:08:14 -07:00

prompt_debug.rs

Project selected plugin runtime by environment availability (#30093)

2026-06-26 01:36:44 +01:00

realtime_context_tests.rs

feat(app-server): add history_mode to thread (#29927)

2026-06-26 09:12:42 -07:00

realtime_context.rs

feat(app-server): list descendant threads by ancestor (#29591)

2026-06-24 13:08:14 -07:00

realtime_conversation_tests.rs

Support thread-level originator overrides (#29477)

2026-06-23 17:23:38 -07:00

realtime_conversation.rs

[codex] Flush trailing realtime transcript tail (#29918)

2026-07-06 14:12:54 -07:00

realtime_prompt.rs

[codex] Consolidate shared prompts in codex-prompts (#25151)

2026-06-01 18:45:07 +00:00

responses_metadata.rs

fix: retry rejected previous-model compaction with selected model (#30319)

2026-07-07 14:26:03 -07:00

responses_retry.rs

centralize Responses retry policy (#24131)

2026-05-26 11:01:18 +02:00

rollout_budget.rs

[codex] configure rollout budget reminder thresholds (#29423)

2026-06-22 13:25:48 -07:00

rollout.rs

app-server: remove experimental persist_extended_history bool flag (#25712)

2026-06-01 23:33:42 +00:00

safety_tests.rs

apply-patch: carry paths as PathUri (#28854)

2026-06-18 19:31:19 +00:00

safety.rs

chore(core) rm AskForApproval::OnFailure (#28418)

2026-06-23 12:13:54 -07:00

sandbox_tags_tests.rs

telemetry: tag sandboxes from permission profiles (#22791)

2026-05-15 10:58:50 -07:00

sandbox_tags.rs

telemetry: tag sandboxes from permission profiles (#22791)

2026-05-15 10:58:50 -07:00

session_prefix_tests.rs

core: surface terminal subagent errors to parent agents (#28375)

2026-06-16 14:34:54 +02:00

session_prefix.rs

core: surface terminal subagent errors to parent agents (#28375)

2026-06-16 14:34:54 +02:00

session_rollout_init_error.rs

feat(app-server): add history_mode to thread (#29927)

2026-06-26 09:12:42 -07:00

session_startup_prewarm.rs

core: make AGENTS.md react to environment changes (#29810)

2026-06-24 22:57:42 -07:00

shell_snapshot_tests.rs

[codex] Bind shell snapshots to retained thread environments (#28421)

2026-06-15 20:10:53 -07:00

shell_snapshot.rs

app-server: preserve target-native environment cwd (#28146)

2026-06-16 21:42:28 +00:00

shell_tests.rs

[codex] simplify shell snapshot ownership (#27756)

2026-06-15 08:18:13 -07:00

shell.rs

[codex] simplify shell snapshot ownership (#27756)

2026-06-15 08:18:13 -07:00

skills.rs

Support thread-level originator overrides (#29477)

2026-06-23 17:23:38 -07:00

spawn.rs

core: stop threading SandboxPolicy through exec (#25700)

2026-06-03 10:41:41 -07:00

state_db_bridge.rs

state: pass state db handles through consumers (#20561)

2026-05-04 11:46:03 -07:00

stream_events_utils_tests.rs

Preserve namespaces on custom tool calls (#30302)

2026-06-27 09:54:56 -07:00

stream_events_utils.rs

Let image generation extension hosts control output persistence (#29711)

2026-06-23 18:51:49 -07:00

test_support.rs

Support openai/form extended form elicitations (#27500)

2026-06-18 11:54:49 -07:00

thread_manager_tests.rs

Make plugin guidance react to environment readiness (#30223)

2026-07-06 07:05:40 -07:00

thread_manager.rs

feat(app-server): add history_mode to thread (#29927)

2026-06-26 09:12:42 -07:00

thread_rollout_truncation_tests.rs

feat(app-server): add optional turn_id to thread/fork (#30277)

2026-06-26 19:35:54 +00:00

thread_rollout_truncation.rs

feat(app-server): add optional turn_id to thread/fork (#30277)

2026-06-26 19:35:54 +00:00

turn_diff_tracker_tests.rs

path-uri: clarify host-native path conversion (#29501)

2026-06-23 00:02:33 +00:00

turn_diff_tracker.rs

core: cache turn diff rendering (#27489)

2026-06-10 17:17:44 -07:00

turn_metadata_tests.rs

fix(core): restore thread_source in x-codex-turn-metadata (#29455)

2026-06-22 09:05:27 -07:00

turn_metadata.rs

fix(core): restore thread_source in x-codex-turn-metadata (#29455)

2026-06-22 09:05:27 -07:00

turn_timing_tests.rs

Preserve namespaces on custom tool calls (#30302)

2026-06-27 09:54:56 -07:00

turn_timing.rs

[codex] Support sequential cutoff reasoning summaries (#31306)

2026-07-06 23:23:56 -04:00

user_shell_command_tests.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

user_shell_command.rs

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

util_tests.rs

Trim TUI legacy core helper usage (#22695)

2026-05-14 16:54:59 -07:00

util.rs

Trim TUI legacy core helper usage (#22695)

2026-05-14 16:54:59 -07:00

web_search.rs

add missing fields to WebSearchAction and update app-server types (#10276)

2026-01-30 16:37:56 -08:00

windows_sandbox_read_grants_tests.rs

windows-sandbox: pass workspace roots to runner (#24108)

2026-05-28 15:26:55 -07:00

windows_sandbox_read_grants.rs

windows-sandbox: pass workspace roots to runner (#24108)

2026-05-28 15:26:55 -07:00

windows_sandbox_tests.rs

config: remove legacy profile v1 resolution (#24051)

2026-05-22 12:13:52 +02:00

windows_sandbox.rs

Add Windows sandbox provisioning setup command (#24831)

2026-05-29 11:01:44 -07:00