Dylan Hurd 67afc79674 Use ReviewDecision for MCP tool approvals (#38081) ...

## What changed

- Add `ApprovedMcpPolicyAmendment` to represent MCP approvals that persist across sessions.
- Route MCP approval responses directly through the shared `ReviewDecision` type while preserving session-only approvals, rejection reasons, timeouts, and cancellations.
- Reject the MCP-only policy decision if it reaches command, shell, network, or other tool approval paths.

## Testing

- Update MCP approval parsing, normalization, hook, and Guardian tests for the shared decisions.
- Verify generic tool approvals reject MCP policy amendments.

GitOrigin-RevId: b8cc931dc61d4c794915145273ede82b9eb30fc8

2026-08-11 22:25:14 +00:00

..

agent

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

apps

Make Apps guidance react to MCP availability (#30226)

2026-07-06 14:29:19 -07:00

bin

Refactor config types into a separate crate (#16962)

2026-04-07 00:32:41 +00:00

config

Configure PSP routing through the feature system (#38056)

2026-08-11 19:16:15 +00:00

context

Reduce cloning in world-state patch handling (#38078)

2026-08-11 21:28:35 +00:00

context_manager

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

exec_policy

Ignore reusable command approvals for cyber models (#37516)

2026-08-08 00:59:39 +00:00

guardian

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

mcp_tool_call

Report MCP error codes with server attribution (#29969)

2026-06-24 21:08:39 -07:00

plugins

Stop re-exporting skill APIs from codex-core (#37984)

2026-08-11 10:43:11 +00:00

realtime_conversation

Support configurable realtime BEM channel prefixes (#34816)

2026-07-22 19:43:35 +00:00

sandboxing

Use permission profiles throughout sandbox execution (#36183)

2026-07-30 16:30:32 +00:00

session

Use ReviewDecision for MCP tool approvals (#38081)

2026-08-11 22:25:14 +00:00

state

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

tasks

Distinguish turn-start thread persistence (#37926)

2026-08-11 03:35:45 +00:00

tools

Use ReviewDecision for MCP tool approvals (#38081)

2026-08-11 22:25:14 +00:00

unified_exec

Track artifact operations from trusted plugin markers (#38057)

2026-08-11 19:26:41 +00:00

utils

Extract rollout into its own crate (#15548)

2026-03-24 18:10:53 -07:00

agent_communication.rs

Support plaintext collaboration tool messages (#35845)

2026-07-28 23:49:37 +00:00

agents_md_manager.rs

Instrument environment and plugin resolution paths (#33223)

2026-07-15 03:27:16 +00:00

agents_md_tests.rs

Scope environment readiness config to thread attachments (#38067)

2026-08-11 19:58:10 +00:00

agents_md.rs

Cap project instructions across environments (#37424)

2026-08-07 09:50:43 +00:00

apply_patch_tests.rs

path-uri: clarify host-native path conversion (#29501)

2026-06-23 00:02:33 +00:00

apply_patch.rs

Use turn environment permissions for tool execution (#37038)

2026-08-05 06:38:57 +00:00

attestation.rs

[codex] request desktop attestation from app (#20619)

2026-05-08 12:36:02 -07:00

client_common_tests.rs

Reduce cloning when building Responses requests (#34825)

2026-07-22 21:00:01 +00:00

client_common.rs

Share model-visible tool specs across prompts (#37807)

2026-08-10 10:50:49 +00:00

client_tests.rs

Preserve base instruction provenance across sessions (#37446)

2026-08-07 14:08:13 +00:00

client.rs

Disable storage for Azure Responses requests (#38060)

2026-08-11 19:35:05 +00:00

codex_delegate_tests.rs

Make submission operations move-only (#37901)

2026-08-10 23:41:52 +00:00

codex_delegate.rs

Use ReviewDecision for MCP tool approvals (#38081)

2026-08-11 22:25:14 +00:00

codex_thread.rs

Scope environment readiness config to thread attachments (#38067)

2026-08-11 19:58:10 +00:00

command_canonicalization_tests.rs

fix: move inline codex-rs/core unit tests into sibling files (#14444)

2026-03-12 08:16:36 -07:00

command_canonicalization.rs

core: remove cross-crate re-exports from lib.rs (#16512)

2026-04-01 23:06:24 -07:00

compact_model_fallback.rs

Separate Codex error details from retry metadata (#34996)

2026-07-23 19:32:26 +00:00

compact_remote_history.rs

Report prompt image resizing to the model (#37134)

2026-08-05 18:19:22 +00:00

compact_remote_metadata_tests.rs

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

compact_remote_request.rs

Store model history in response item envelopes (#38045)

2026-08-11 17:58:11 +00:00

compact_remote_v2_attempt.rs

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

compact_remote_v2.rs

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

compact_remote.rs

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

compact_tests.rs

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

compact_token_budget.rs

Refresh environment dates from the configured clock (#36187)

2026-07-30 16:44:18 +00:00

compact.rs

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

connectors_tests.rs

Enforce automatic review for managed models (#37511)

2026-08-07 23:43:14 +00:00

connectors.rs

Enforce automatic review for managed models (#37511)

2026-08-07 23:43:14 +00:00

consequential_tool_message_templates.json

[elicitation] User-friendly tool call messages. (#14403)

2026-03-12 00:35:21 -07:00

current_time.rs

[codex] route sleep through time providers (#29973)

2026-06-24 22:17:43 -07:00

elicitation_tests.rs

elicitations: Move to shared ElicitationService (#30627)

2026-07-06 11:20:32 -07:00

elicitation.rs

elicitations: Move to shared ElicitationService (#30627)

2026-07-06 11:20:32 -07:00

environment_config.rs

Scope environment readiness config to thread attachments (#38067)

2026-08-11 19:58:10 +00:00

environment_selection.rs

Scope environment readiness config to thread attachments (#38067)

2026-08-11 19:58:10 +00:00

event_mapping_tests.rs

Identify agents by name in token budget context (#36815)

2026-08-04 00:51:53 +00:00

event_mapping.rs

Avoid reinjecting permissions after command approvals (#36800)

2026-08-03 21:37:17 +00:00

exec_env_tests.rs

Add a feature flag to preserve apply_patch line endings (#37758)

2026-08-10 01:44:30 +00:00

exec_env.rs

Expose the session ID to shell commands (#37848)

2026-08-10 17:02:19 +00:00

exec_policy_tests.rs

Ignore reusable command approvals for cyber models (#37516)

2026-08-08 00:59:39 +00:00

exec_policy_windows_tests.rs

Skip missing paths in filesystem sandbox entries (#34598)

2026-07-21 19:17:18 +00:00

exec_policy.rs

Ignore reusable command approvals for cyber models (#37516)

2026-08-08 00:59:39 +00:00

exec_tests.rs

Honor the configured Windows sandbox level for managed networking (#37875)

2026-08-10 19:57:40 +00:00

exec.rs

Honor the configured Windows sandbox level for managed networking (#37875)

2026-08-10 19:57:40 +00:00

function_tool.rs

feat: extract shared tool executor interface (#22359)

2026-05-13 11:31:27 +02:00

git_info_tests.rs

Coalesce concurrent Git status scans (#37151)

2026-08-05 20:23:35 +00:00

hook_runtime.rs

Distinguish turn-start thread persistence (#37926)

2026-08-11 03:35:45 +00:00

image_preparation_tests.rs

Add a unified image budget (#37206)

2026-08-06 03:15:08 +00:00

image_preparation.rs

Add a unified image budget (#37206)

2026-08-06 03:15:08 +00:00

installation_id.rs

feat: split memories part 2 (#19860)

2026-04-28 13:03:28 +02:00

lib.rs

Scope environment readiness config to thread attachments (#38067)

2026-08-11 19:58:10 +00:00

mcp_openai_file.rs

Apply permission profile updates to future turn environments (#37031)

2026-08-05 05:30:51 +00:00

mcp_skill_dependencies.rs

Add per-login MCP OAuth client registration selection (#38052)

2026-08-11 18:35:03 +00:00

mcp_tool_approval_templates.rs

Uprev Rust toolchain pins to 1.95.0 (#24684)

2026-05-26 20:59:47 -07:00

mcp_tool_call_tests.rs

Use ReviewDecision for MCP tool approvals (#38081)

2026-08-11 22:25:14 +00:00

mcp_tool_call.rs

Use ReviewDecision for MCP tool approvals (#38081)

2026-08-11 22:25:14 +00:00

mcp_tool_exposure_test.rs

Reuse MCP handlers across sampling steps (#37273)

2026-08-06 13:37:07 +00:00

mcp_tool_exposure.rs

Reuse MCP handlers across sampling steps (#37273)

2026-08-06 13:37:07 +00:00

mcp.rs

Expose session sources to MCP contributors (#37167)

2026-08-05 21:45:33 +00:00

memory_usage.rs

Canonicalize default tools under the functions namespace (#37022)

2026-08-05 04:07:59 +00:00

mention_syntax.rs

Extract codex-utils-plugins crate (#15746)

2026-03-25 11:05:35 -07:00

network_policy_decision_tests.rs

fix: attribut network requests to the exact exec on linux (#29697)

2026-07-06 14:51:34 -07:00

network_policy_decision.rs

refactor(proxy): clarify sandbox block messages (#17168)

2026-04-09 10:53:06 -07:00

original_image_detail.rs

Remove js_repl feature (#19410)

2026-04-24 17:49:29 -07:00

otel_init.rs

Remove unused Rust helpers (#34345)

2026-07-20 13:45:29 +00:00

prompt_debug.rs

Refresh environment dates from the configured clock (#36187)

2026-07-30 16:44:18 +00:00

realtime_context_tests.rs

Add persisted manual ordering for thread sections (#36007)

2026-07-29 18:37:22 +00:00

realtime_context.rs

Store model history in response item envelopes (#38045)

2026-08-11 17:58:11 +00:00

realtime_conversation_tests.rs

Support configurable realtime BEM channel prefixes (#34816)

2026-07-22 19:43:35 +00:00

realtime_conversation.rs

Add a realtime delegation acknowledgement control (#36413)

2026-08-01 01:17:26 +00:00

realtime_prompt.rs

[codex] Consolidate shared prompts in codex-prompts (#25151)

2026-06-01 18:45:07 +00:00

responses_metadata.rs

Include auto-review state in turn metadata (#38046)

2026-08-11 18:06:05 +00:00

responses_retry_tests.rs

Separate Codex error details from retry metadata (#34996)

2026-07-23 19:32:26 +00:00

responses_retry.rs

Keep response streams alive through connection failures (#37485)

2026-08-07 18:33:46 +00:00

rollout_budget.rs

Use provider-reported rollout budget units (#36715)

2026-08-03 09:46:38 +00:00

rollout.rs

Honor the configured SQLite home across state consumers (#34994)

2026-07-23 19:19:35 +00:00

safety_tests.rs

Consolidate apply_patch runtime execution (#36745)

2026-08-03 12:03:33 +00:00

safety.rs

Consolidate apply_patch runtime execution (#36745)

2026-08-03 12:03:33 +00:00

sandbox_tags_tests.rs

Skip missing paths in filesystem sandbox entries (#34598)

2026-07-21 19:17:18 +00:00

sandbox_tags.rs

telemetry: tag sandboxes from permission profiles (#22791)

2026-05-15 10:58:50 -07:00

session_prefix_tests.rs

core: surface terminal subagent errors to parent agents (#28375)

2026-06-16 14:34:54 +02:00

session_prefix.rs

core: surface terminal subagent errors to parent agents (#28375)

2026-06-16 14:34:54 +02:00

session_rollout_init_error.rs

Enforce single-writer ownership for paginated threads (#34986)

2026-07-23 18:22:41 +00:00

session_startup_prewarm.rs

Preserve base instruction provenance across sessions (#37446)

2026-08-07 14:08:13 +00:00

shell_snapshot_tests.rs

Preserve zsh tied PATH exports in shell snapshots (#34293)

2026-07-20 08:29:12 +00:00

shell_snapshot.rs

Apply permission profile updates to future turn environments (#37031)

2026-08-05 05:30:51 +00:00

shell_tests.rs

[codex] simplify shell snapshot ownership (#27756)

2026-06-15 08:18:13 -07:00

shell.rs

[codex] simplify shell snapshot ownership (#27756)

2026-06-15 08:18:13 -07:00

skills.rs

Track implicit executor skill invocations (#38074)

2026-08-11 21:09:29 +00:00

spawn.rs

Prevent launch context from reaching child processes (#37607)

2026-08-08 16:58:26 +00:00

state_db_bridge.rs

state: pass state db handles through consumers (#20561)

2026-05-04 11:46:03 -07:00

stream_events_utils_tests.rs

Keep effective tool exposure in the registry (#36367)

2026-07-31 17:24:33 +00:00

stream_events_utils.rs

Support plaintext collaboration tool messages (#35845)

2026-07-28 23:49:37 +00:00

test_support.rs

Negotiate MCP extensions per app-server session (#36910)

2026-08-04 15:23:43 +00:00

thread_manager_tests.rs

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

thread_manager.rs

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

thread_rollout_truncation_tests.rs

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

thread_rollout_truncation.rs

Preserve harness metadata across conversation history (#38058)

2026-08-11 19:30:12 +00:00

turn_diff_tracker_tests.rs

Render turn diffs for foreign environment paths (#34654)

2026-07-22 02:19:45 +00:00

turn_diff_tracker.rs

Render turn diffs for foreign environment paths (#34654)

2026-07-22 02:19:45 +00:00

turn_metadata_tests.rs

Include auto-review state in turn metadata (#38046)

2026-08-11 18:06:05 +00:00

turn_metadata.rs

Include auto-review state in turn metadata (#38046)

2026-08-11 18:06:05 +00:00

turn_timing_tests.rs

Support plaintext collaboration tool messages (#35845)

2026-07-28 23:49:37 +00:00

turn_timing.rs

Include item start times in completion events (#35363)

2026-07-25 16:06:54 +00:00

user_message_admission.rs

Add durable user-message queue dispatch (#37204)

2026-08-06 03:11:42 +00:00

user_shell_command_tests.rs

Organize context fragments (#18794)

2026-04-20 22:39:17 -07:00

user_shell_command.rs

core: remove redundant TurnContext and Prompt fields (#28638)

2026-06-16 22:17:24 -07:00

util_tests.rs

Trim TUI legacy core helper usage (#22695)

2026-05-14 16:54:59 -07:00

util.rs

Remove unused Rust helpers (#34345)

2026-07-20 13:45:29 +00:00

web_search.rs

Remove unused Rust helpers (#34345)

2026-07-20 13:45:29 +00:00

windows_sandbox_read_grants_tests.rs

windows-sandbox: pass workspace roots to runner (#24108)

2026-05-28 15:26:55 -07:00

windows_sandbox_read_grants.rs

windows-sandbox: pass workspace roots to runner (#24108)

2026-05-28 15:26:55 -07:00

windows_sandbox_tests.rs

Route Windows sandbox proxy traffic by restricting SID (#34613)

2026-07-21 21:06:04 +00:00

windows_sandbox.rs

Route Windows sandbox proxy traffic by restricting SID (#34613)

2026-07-21 21:06:04 +00:00