Felipe Coury a036584104 fix(tui): let esc exit empty shell mode (#19986) ...

## Summary

- exit shell mode when `Esc` is pressed while the absorbed `!` is the
only input
- add direct regression coverage plus a composer snapshot for the
restored normal prompt state

## Root cause

Shell mode stores the leading `!` outside the editable textarea. After
typing only `!`, the textarea is empty but the composer is still in bash
mode, so the existing empty-composer `Esc` handling never runs.

## Validation

- `just fmt`
- `cargo test -p codex-tui
bottom_pane::chat_composer::tests::esc_exits_empty_shell_mode`
- `cargo test -p codex-tui
bottom_pane::chat_composer::tests::footer_mode_snapshots`
- `cargo insta pending-snapshots`

`cargo test -p codex-tui` still reports unrelated existing `/status`
snapshot drift in this local environment because the rendered
permissions text is `workspace-write with network access` instead of the
older `read-only` fixture text.

2026-04-28 14:35:24 -03:00

..

codex_tui__bottom_pane__app_link_view__tests__app_link_view_enable_suggestion_with_reason.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__app_link_view__tests__app_link_view_install_suggestion_with_reason.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__approval_overlay__tests__approval_overlay_additional_permissions_prompt.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__approval_overlay__tests__approval_overlay_cross_thread_prompt.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__approval_overlay__tests__approval_overlay_permissions_prompt.snap

feat(tui): add configurable keymap support (#18593)

2026-04-28 12:52:25 -03:00

codex_tui__bottom_pane__approval_overlay__tests__network_exec_prompt.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__backspace_after_pastes.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__empty.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_empty_full.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_empty_mode_cycle_with_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_empty_mode_cycle_without_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_empty_mode_only.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_plan_empty_full.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_plan_empty_mode_cycle_with_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_plan_empty_mode_cycle_without_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_plan_empty_mode_only.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_plan_queue_full.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_plan_queue_message_without_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_plan_queue_mode_only.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_plan_queue_short_with_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_plan_queue_short_without_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_queue_full.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_queue_message_without_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_queue_mode_only.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_queue_short_with_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_collapse_queue_short_without_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_ctrl_c_interrupt.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_ctrl_c_quit.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_ctrl_c_then_esc_hint.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_esc_hint_backtrack.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_esc_hint_from_overlay.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_hidden_while_typing.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_history_search.snap

feat(tui): add reverse history search to composer (#17550)

2026-04-12 19:32:19 -03:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_overlay_then_external_esc_hint.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_shell_command_absorbs_bang.snap

Persist shell mode commands in prompt history (#19618)

2026-04-27 09:54:25 -07:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_shell_command_escape_exits_empty_mode.snap

fix(tui): let esc exit empty shell mode (#19986)

2026-04-28 14:35:24 -03:00

codex_tui__bottom_pane__chat_composer__tests__footer_mode_shortcut_overlay.snap

feat(tui): add configurable keymap support (#18593)

2026-04-28 12:52:25 -03:00

codex_tui__bottom_pane__chat_composer__tests__image_placeholder_multiple.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__image_placeholder_single.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__large.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__mention_popup_type_prefixes.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__multiple_pastes.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__plugin_mention_popup.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__remote_image_rows_after_delete_first.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__remote_image_rows_selected.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__remote_image_rows.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__slash_popup_mo.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__slash_popup_res.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__small.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__chat_composer__tests__zellij_empty_composer.snap

fix(tui): handle zellij redraw and composer rendering (#16578)

2026-04-02 18:07:05 -03:00

codex_tui__bottom_pane__feedback_view__tests__feedback_view_bad_result.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__feedback_view__tests__feedback_view_bug.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__feedback_view__tests__feedback_view_good_result.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__feedback_view__tests__feedback_view_other.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__feedback_view__tests__feedback_view_render.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__feedback_view__tests__feedback_view_safety_check.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__feedback_view__tests__feedback_view_with_connectivity_diagnostics.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_active_agent_label.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_composer_has_draft_queue_hint_enabled.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_context_tokens_used.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_ctrl_c_quit_idle.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_ctrl_c_quit_running.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_esc_hint_idle.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_esc_hint_primed.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_mode_indicator_narrow_overlap_hides.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_mode_indicator_running_hides_hint.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_mode_indicator_wide.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_shortcuts_collaboration_modes_enabled.snap

feat(tui): add configurable keymap support (#18593)

2026-04-28 12:52:25 -03:00

codex_tui__bottom_pane__footer__tests__footer_shortcuts_context_running.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_shortcuts_default.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_shortcuts_shift_and_esc.snap

feat(tui): add configurable keymap support (#18593)

2026-04-28 12:52:25 -03:00

codex_tui__bottom_pane__footer__tests__footer_status_line_disabled_context_right.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_status_line_enabled_mode_right.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_status_line_enabled_no_mode_right.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_status_line_overrides_context.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_status_line_overrides_draft_idle.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_status_line_overrides_shortcuts.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_status_line_truncated_with_gap.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_status_line_with_active_agent_label.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__footer__tests__footer_status_line_yields_to_queue_hint.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__list_selection_view__tests__list_selection_col_width_mode_auto_all_rows_scroll.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__list_selection_view__tests__list_selection_col_width_mode_auto_visible_scroll.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__list_selection_view__tests__list_selection_col_width_mode_fixed_scroll.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__list_selection_view__tests__list_selection_footer_note_wraps.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__list_selection_view__tests__list_selection_model_picker_width_80.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__list_selection_view__tests__list_selection_narrow_width_preserves_rows.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__list_selection_view__tests__list_selection_spacing_with_subtitle.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__list_selection_view__tests__list_selection_spacing_without_subtitle.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__mcp_server_elicitation__tests__mcp_server_elicitation_approval_form_with_param_summary.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__mcp_server_elicitation__tests__mcp_server_elicitation_approval_form_with_session_persist.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__mcp_server_elicitation__tests__mcp_server_elicitation_approval_form_without_schema.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__mcp_server_elicitation__tests__mcp_server_elicitation_boolean_form.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__mcp_server_elicitation__tests__mcp_server_elicitation_message_only_form_with_persist_options.snap

[mcp] Support server-driven elicitations (#17043)

2026-04-08 10:18:58 -07:00

codex_tui__bottom_pane__mcp_server_elicitation__tests__mcp_server_elicitation_message_only_form.snap

[mcp] Support server-driven elicitations (#17043)

2026-04-08 10:18:58 -07:00

codex_tui__bottom_pane__message_queue__tests__render_many_line_message.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__message_queue__tests__render_one_message.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__message_queue__tests__render_two_messages.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__message_queue__tests__render_wrapped_message.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__pending_input_preview__tests__render_many_line_message.snap

Queue slash and shell prompts in the TUI (#18542)

2026-04-19 10:52:16 -07:00

codex_tui__bottom_pane__pending_input_preview__tests__render_more_than_three_messages.snap

Queue slash and shell prompts in the TUI (#18542)

2026-04-19 10:52:16 -07:00

codex_tui__bottom_pane__pending_input_preview__tests__render_multiline_pending_steer_uses_single_prefix_and_truncates.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__pending_input_preview__tests__render_one_message_with_shift_left_binding.snap

Queue slash and shell prompts in the TUI (#18542)

2026-04-19 10:52:16 -07:00

codex_tui__bottom_pane__pending_input_preview__tests__render_one_message.snap

Queue slash and shell prompts in the TUI (#18542)

2026-04-19 10:52:16 -07:00

codex_tui__bottom_pane__pending_input_preview__tests__render_one_pending_steer.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__pending_input_preview__tests__render_pending_steers_above_queued_messages.snap

Queue slash and shell prompts in the TUI (#18542)

2026-04-19 10:52:16 -07:00

codex_tui__bottom_pane__pending_input_preview__tests__render_two_messages.snap

Queue slash and shell prompts in the TUI (#18542)

2026-04-19 10:52:16 -07:00

codex_tui__bottom_pane__pending_input_preview__tests__render_wrapped_message.snap

Queue slash and shell prompts in the TUI (#18542)

2026-04-19 10:52:16 -07:00

codex_tui__bottom_pane__skill_popup__tests__skill_popup_scrolled.snap

Fix skills picker scrolling in tui app server (#16109)

2026-03-28 17:22:25 -06:00

codex_tui__bottom_pane__skills_toggle_view__tests__skills_toggle_basic.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__status_line_setup__tests__setup_view_snapshot_uses_runtime_preview_values.snap

Normalize /statusline & /title items (#18886)

2026-04-21 16:13:09 -07:00

codex_tui__bottom_pane__tests__queued_messages_visible_when_status_hidden_snapshot.snap

Queue slash and shell prompts in the TUI (#18542)

2026-04-19 10:52:16 -07:00

codex_tui__bottom_pane__tests__status_and_composer_fill_height_without_bottom_padding.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__tests__status_and_queued_messages_snapshot.snap

Queue slash and shell prompts in the TUI (#18542)

2026-04-19 10:52:16 -07:00

codex_tui__bottom_pane__tests__status_hidden_when_height_too_small_height_1.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__tests__status_only_snapshot.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__tests__status_with_details_and_queued_messages_snapshot.snap

Queue slash and shell prompts in the TUI (#18542)

2026-04-19 10:52:16 -07:00

codex_tui__bottom_pane__title_setup__tests__terminal_title_setup_basic.snap

Show action required in terminal title (#18372)

2026-04-27 15:27:11 -07:00

codex_tui__bottom_pane__unified_exec_footer__tests__render_many_sessions.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00

codex_tui__bottom_pane__unified_exec_footer__tests__render_more_sessions.snap

Rename tui_app_server to tui (#16104)

2026-03-28 11:23:07 -06:00