Eric Traut
ab45264919
Preserve review lifecycle ordering on failure ( #50804 )
...
## Why
A review can fail before the UI receives the event that enters review mode. Failed-turn completion also needs to preserve the running indicator when a queued `/review` has already been submitted and is awaiting startup.
## What changed
- Emit the review-entry lifecycle before starting the review task, after aborting existing tasks and clearing connector selection.
- When a live failed-turn completion repeats an already handled error, refresh task state only if no user turn is pending startup, and continue processing queued input.
## Testing
Add regression tests for lifecycle ordering on a server-overload response and for preserving the running indicator while a queued review awaits startup after a failed turn.
GitOrigin-RevId: 0f91d3d1a1a983542c54c2686630de9c232321b1
2026-10-04 06:35:16 +00:00
..
2026-10-02 04:02:14 +00:00
2026-09-29 22:50:07 +00:00
2026-09-30 17:33:59 +00:00
2026-09-30 05:29:56 +00:00
2026-09-30 00:51:39 +00:00
2026-10-03 05:37:28 +00:00
2026-09-26 23:17:41 +00:00
2026-10-04 06:28:20 +00:00
2026-10-02 22:55:08 +00:00
2026-09-22 06:36:09 +00:00
2026-10-02 16:05:51 +00:00
2026-10-01 15:57:03 +00:00
2026-09-18 00:25:37 +00:00
2026-09-21 22:58:49 +00:00
2026-09-23 00:47:34 +00:00
2026-10-02 22:20:55 +00:00
2026-09-30 18:49:29 +00:00
2026-10-04 06:28:20 +00:00
2026-10-01 22:32:29 +00:00
2026-09-29 13:58:09 +00:00
2026-09-29 03:32:19 +00:00
2026-09-25 16:57:42 +00:00
2026-10-01 15:57:03 +00:00
2026-10-03 07:37:00 +00:00
2026-10-02 22:29:52 +00:00
2026-10-02 20:19:28 +00:00
2026-09-25 00:20:02 +00:00
2026-09-24 01:50:36 +00:00
2026-09-14 19:12:59 +00:00
2026-10-01 17:10:03 +00:00
2026-10-04 04:25:31 +00:00
2026-09-15 18:23:08 +00:00
2026-10-02 22:12:07 +00:00
2026-10-04 06:35:16 +00:00
2026-10-01 03:31:48 +00:00
2026-09-23 22:20:34 +00:00
2026-10-01 15:57:03 +00:00
2026-10-02 16:55:41 +00:00
2026-10-02 23:54:32 +00:00
2026-10-02 04:25:52 +00:00
2026-10-02 10:44:29 +00:00
2026-09-30 11:59:13 +00:00
2026-10-03 18:15:13 +00:00
2026-10-02 22:47:52 +00:00
2026-10-01 09:52:54 +00:00
2026-10-01 00:43:55 +00:00
2026-10-01 15:57:03 +00:00
2026-10-02 22:12:07 +00:00
2026-10-02 16:55:41 +00:00
2026-10-01 11:01:37 +00:00
2026-10-01 22:32:29 +00:00
2026-09-11 21:59:24 +00:00
2026-09-29 22:24:09 +00:00
2026-10-01 18:05:33 +00:00
2026-10-02 23:26:27 +00:00
2026-09-28 14:46:32 +00:00
2026-09-28 06:30:53 +00:00
2026-10-03 00:31:51 +00:00
2026-10-02 23:26:27 +00:00
2026-10-01 01:38:27 +00:00
2026-10-01 18:05:05 +00:00
2026-10-01 18:05:05 +00:00
2026-09-30 17:45:25 +00:00
2026-09-23 22:20:34 +00:00
2026-10-02 22:12:07 +00:00
2026-10-02 21:42:45 +00:00
2026-10-01 15:57:03 +00:00
2026-09-29 01:14:41 +00:00
2026-10-02 23:54:32 +00:00
2026-10-02 23:15:02 +00:00
2026-10-02 18:48:49 +00:00
2026-10-01 15:57:03 +00:00
2026-09-24 18:08:31 +00:00
2026-09-28 15:58:17 +00:00
2026-09-09 04:00:10 +00:00
2026-09-27 03:26:57 +00:00
2026-10-02 23:34:11 +00:00
2026-10-02 00:46:14 +00:00
2026-10-04 04:25:31 +00:00
2026-10-02 23:34:11 +00:00
2026-10-01 06:29:03 +00:00
2026-10-04 06:35:16 +00:00
2026-10-01 18:05:05 +00:00
2026-09-08 00:13:28 +00:00
2026-10-03 07:14:12 +00:00
2026-10-01 15:57:03 +00:00
2026-09-23 04:25:28 +00:00
2026-09-22 23:37:39 +00:00
2026-10-03 03:20:37 +00:00
2026-10-03 03:20:37 +00:00
2026-09-23 00:47:07 +00:00
2026-10-01 15:57:03 +00:00
2026-09-08 21:19:02 +00:00
2026-10-03 21:20:56 +00:00
2026-10-03 21:20:56 +00:00
2026-10-02 04:02:14 +00:00