mirror of
https://github.com/openai/codex.git
synced 2026-10-23 22:16:45 +00:00
jacobzhou-oai
56b82e676c
## What changed - Track Agent Plugin manifests through plugin, skill, and MCP loading so their capabilities use format-specific behavior without changing legacy plugins. - Discover only direct-child skills, exclude app and hook capabilities, isolate MCP data, and reject MCP configuration files that are non-regular or resolve outside the plugin root. - Bound model-visible skill instructions, plugin instructions, MCP descriptions, schemas, individual tools, and the aggregate Agent Plugin MCP tool set. - Stop MCP and OAuth redirects when Agent Plugins send configured or authorization headers, while retaining existing redirect behavior for legacy MCP servers. ## Testing - Add coverage for capability filtering, skill discovery, isolated MCP data and reserved-path expansion, unsafe MCP configuration files, context limits, and redirect handling. GitOrigin-RevId: c9af66b051269f3226628ca280a58d32c808c38f
65 lines
2.9 KiB
Rust
65 lines
2.9 KiB
Rust
use super::*;
|
|
use pretty_assertions::assert_eq;
|
|
|
|
#[test]
|
|
fn render_plugins_section_returns_none_for_empty_plugins() {
|
|
assert_eq!(render_plugins_section(&[]), None);
|
|
}
|
|
|
|
#[test]
|
|
fn render_plugins_section_keeps_plugin_usage_guidance_without_listing_plugins() {
|
|
let rendered = render_plugins_section(&[PluginCapabilitySummary {
|
|
config_name: "sample@test".to_string(),
|
|
display_name: "sample".to_string(),
|
|
plugin_namespace: None,
|
|
description: Some("inspect sample data".to_string()),
|
|
has_skills: true,
|
|
..PluginCapabilitySummary::default()
|
|
}])
|
|
.expect("plugin section should render");
|
|
|
|
let expected = "<plugins_instructions>\n## Plugins\nA plugin is a local bundle of skills, MCP servers, and apps.\n### How to use plugins\n- Skill naming: If a plugin contributes skills, those skill entries are prefixed with `plugin_name:` in the Skills list.\n- MCP naming: Plugin-provided MCP tools keep standard MCP identifiers such as `mcp__server__tool`; use tool provenance to tell which plugin they come from.\n- Trigger rules: If the user explicitly names a plugin, prefer capabilities associated with that plugin for that turn.\n- Relationship to capabilities: Plugins are not invoked directly. Use their underlying skills, MCP tools, and app tools to help solve the task.\n- Relevance: Determine what a plugin can help with from explicit user mention or from the plugin-associated skills, MCP tools, and apps exposed elsewhere in this turn.\n- Missing/blocked: If the user requests a plugin that does not have relevant callable capabilities for the task, say so briefly and continue with the best fallback.\n</plugins_instructions>";
|
|
|
|
assert_eq!(rendered, expected);
|
|
}
|
|
|
|
#[test]
|
|
fn explicit_plugin_instructions_use_manifest_namespace_for_skills() {
|
|
let rendered = render_explicit_plugin_instructions(
|
|
&PluginCapabilitySummary {
|
|
config_name: "acme.tools@test".to_string(),
|
|
display_name: "Acme Developer Tools".to_string(),
|
|
plugin_namespace: Some("acme.tools".to_string()),
|
|
has_skills: true,
|
|
..PluginCapabilitySummary::default()
|
|
},
|
|
&[],
|
|
&[],
|
|
)
|
|
.expect("skill capability should render");
|
|
|
|
assert!(rendered.contains("`acme.tools:`"));
|
|
assert!(!rendered.contains("`Acme Developer Tools:`"));
|
|
}
|
|
|
|
#[test]
|
|
fn explicit_plugin_instructions_are_bounded() {
|
|
let servers = (0..1_024)
|
|
.map(|index| format!("server-{index}"))
|
|
.collect::<Vec<_>>();
|
|
|
|
let rendered = render_explicit_plugin_instructions(
|
|
&PluginCapabilitySummary {
|
|
config_name: "sample@test".to_string(),
|
|
display_name: "sample".to_string(),
|
|
..PluginCapabilitySummary::default()
|
|
},
|
|
&servers,
|
|
&[],
|
|
)
|
|
.expect("MCP capability should render");
|
|
|
|
assert!(rendered.len() <= MAX_EXPLICIT_PLUGIN_INSTRUCTIONS_BYTES);
|
|
assert!(rendered.ends_with(TRUNCATED_PLUGIN_INSTRUCTIONS_SUFFIX));
|
|
}
|