codex

mirror of https://github.com/openai/codex.git synced 2026-10-29 00:06:55 +00:00

Files

T

Michael Bolin f6d64bd6ab core: stop passing legacy SandboxPolicy to guardian reviews (#25911 )

## Why

Guardian review turns already submit a read-only `PermissionProfile`,
which is the permissions model the runtime should honor. Passing the
equivalent legacy `SandboxPolicy` through `ThreadSettingsOverrides`
keeps two representations of the same read-only constraint alive on this
path and makes the guardian flow depend on compatibility plumbing that
is being phased out.

## What Changed

- Set `sandbox_policy` to `None` when the guardian review session
submits its child `Op::UserInput`.
- Keep `permission_profile: Some(PermissionProfile::read_only())` and
`approval_policy: Some(AskForApproval::Never)`, so the guardian review
remains read-only and cannot request approvals.
- Remove the now-unused `SandboxPolicy` import and redundant comment
from `codex-rs/core/src/guardian/review_session.rs`.

## Verification

Not run locally; this is a narrow cleanup of redundant thread-settings
override state.

2026-06-02 14:16:12 -07:00

snapshots

Clarify network approval auto-review prompts (#19907 )

2026-04-28 10:25:37 -07:00

approval_request.rs

permissions: make profiles represent enforcement (#19231 )

2026-04-23 23:02:18 -07:00

metrics.rs

Add Guardian review metrics (#24897 )

2026-05-28 14:07:25 +02:00

mod.rs

[app-server][core] Add connector-level Guardian reviewer overrides (#25167 )