mirror of
https://github.com/openai/codex.git
synced 2026-10-22 23:55:44 +00:00
Owen Lin
23aac925e7
## Description This PR moves review-mode markers onto canonical `TurnItem` lifecycle: - `TurnItem::EnteredReviewMode` - `TurnItem::ExitedReviewMode` Core now emits `ItemStarted` / `ItemCompleted` for both. The completed items map back into the existing `EnteredReviewMode` / `ExitedReviewMode` events, so raw core event consumers and legacy rollout persistence keep seeing the old events. This is the compatibility layer needed before paginated rollouts persist review markers as `ItemCompleted(TurnItem)`. ## Why Review markers were one of the remaining app-server thread items created directly from legacy events. Giving them canonical items lets paginated history persist stable turn/item IDs without changing legacy rollouts. ## What changed - Added canonical review-mode `TurnItem`s and switched review flow to emit their lifecycle. - Added completed-item → legacy review event mappings with stable turn/item IDs. - Switched app-server live notifications to the generic canonical item path and kept legacy replay compatible with old payloads. - Updated `ThreadHistoryBuilder` to replay canonical review items even though review turns still do not emit `TurnStarted`.
36 lines
745 B
Rust
36 lines
745 B
Rust
pub mod account;
|
|
mod agent_path;
|
|
pub mod auth;
|
|
mod session_id;
|
|
mod thread_id;
|
|
mod tool_name;
|
|
pub use agent_path::AgentPath;
|
|
pub use session_id::SessionId;
|
|
pub use thread_id::ThreadId;
|
|
pub use tool_name::ToolName;
|
|
pub mod approvals;
|
|
pub mod capabilities;
|
|
mod compacted_item;
|
|
pub mod config_types;
|
|
pub mod dynamic_tools;
|
|
pub mod error;
|
|
pub mod exec_output;
|
|
pub mod items;
|
|
mod legacy_events;
|
|
pub mod mcp;
|
|
pub mod mcp_approval_meta;
|
|
pub mod memory_citation;
|
|
pub mod models;
|
|
pub mod network_policy;
|
|
pub mod num_format;
|
|
pub mod openai_models;
|
|
pub mod parse_command;
|
|
pub mod permissions;
|
|
pub mod plan_tool;
|
|
pub mod protocol;
|
|
pub mod request_permissions;
|
|
pub mod request_user_input;
|
|
pub mod review_format;
|
|
pub mod shell_environment;
|
|
pub mod user_input;
|