mirror of
https://github.com/openai/codex.git
synced 2026-11-09 00:39:32 +00:00
Abhinav
b64de2f3ad
## Why History recording used the model captured at turn start, so switching models within a turn could apply stale image preparation and tool-output truncation rules. ## What changed Pass explicit model metadata through conversation recording. Record model responses and tool results using their originating step's settings, and capture the current model for pending input recorded during startup interruption or task completion. ## Testing Add regression coverage for tool results across a model switch, explicit model selection for plain and annotated history, and image input retained during interruption and completion. Extend model-switching tests to verify that prepared media and item identity survive switching back to a multimodal model in live, resumed, and forked threads. GitOrigin-RevId: 5bc750c30c334acb9b802cb80fdea01daffa84a1
56 lines
1.9 KiB
Rust
56 lines
1.9 KiB
Rust
use crate::session::tests::make_session_and_context_with_rx;
|
|
use codex_features::Feature;
|
|
use codex_history::CodexHarnessMetadata;
|
|
use codex_history::ResponseItemEnvelope;
|
|
use codex_history::RolloutItem;
|
|
use codex_protocol::models::ConfigurationReasoning;
|
|
use codex_protocol::models::ResponseItem;
|
|
use codex_protocol::openai_models::ReasoningEffort;
|
|
use codex_protocol::protocol::EventMsg;
|
|
use pretty_assertions::assert_eq;
|
|
|
|
#[tokio::test]
|
|
async fn harness_authored_configuration_updates_preserve_metadata_and_resume() {
|
|
let (session, turn_context, rx_event) = make_session_and_context_with_rx().await;
|
|
assert!(!session.enabled(Feature::RetainClientDeveloperMessages));
|
|
|
|
let expected = ResponseItemEnvelope {
|
|
item: ResponseItem::ConfigurationUpdate {
|
|
reasoning: ConfigurationReasoning {
|
|
effort: ReasoningEffort::High,
|
|
},
|
|
},
|
|
metadata: Some(CodexHarnessMetadata {
|
|
harness_authored_configuration: true,
|
|
..Default::default()
|
|
}),
|
|
};
|
|
session
|
|
.record_annotated_conversation_items(
|
|
&turn_context,
|
|
turn_context.model_info(),
|
|
vec![expected.clone()],
|
|
)
|
|
.await;
|
|
|
|
let recorded = session.clone_history().await.into_annotated_items();
|
|
assert_eq!(recorded, vec![expected.clone()]);
|
|
let mut raw_items = Vec::new();
|
|
while let Ok(event) = rx_event.try_recv() {
|
|
if let EventMsg::RawResponseItem(event) = event.msg {
|
|
raw_items.push(event.item);
|
|
}
|
|
}
|
|
assert_eq!(raw_items, vec![expected.item]);
|
|
|
|
let rollout_items = recorded
|
|
.iter()
|
|
.cloned()
|
|
.map(RolloutItem::ResponseItem)
|
|
.collect::<Vec<_>>();
|
|
let reconstructed = session
|
|
.reconstruct_history_from_rollout(&turn_context, &rollout_items)
|
|
.await;
|
|
assert_eq!(reconstructed.history, recorded);
|
|
}
|