fix(dameng): preserve table and column comments when cloning table
This commit is contained in:
4 files changed
+68
-3
No files matched your search
@@ -794,6 +794,7 @@ fn supports_duplicate_table_comment(database_type: DatabaseType) -> bool {
|
||||
| DatabaseType::Gaussdb
|
||||
| DatabaseType::Kwdb
|
||||
| DatabaseType::OpenGauss
|
||||
| DatabaseType::Dameng
|
||||
)
|
||||
}
|
||||
|
||||
@@ -875,6 +876,11 @@ fn quote_sql_string(value: &str) -> String {
|
||||
}
|
||||
|
||||
fn quote_duplicate_table_comment(database_type: DatabaseType, value: &str) -> String {
|
||||
// Dameng rejects Postgres E'...' escape strings; keep standard '' escaping
|
||||
// (same as DamengAgent COMMENT ON / COMMENT ON COLUMN generation).
|
||||
if database_type == DatabaseType::Dameng {
|
||||
return quote_sql_string(value);
|
||||
}
|
||||
if !value.contains('\\') && !value.chars().any(|character| character.is_ascii_control()) {
|
||||
return quote_sql_string(value);
|
||||
}
|
||||
@@ -1624,7 +1630,7 @@ mod tests {
|
||||
schema: Some("APP".to_string()),
|
||||
source_name: "USERS".to_string(),
|
||||
target_name: "users_copy".to_string(),
|
||||
table_comment: None,
|
||||
table_comment: Some("测试'克隆".to_string()),
|
||||
column_comments: vec![
|
||||
DuplicateTableColumnComment {
|
||||
name: "DISPLAY\"NAME".to_string(),
|
||||
@@ -1636,16 +1642,31 @@ mod tests {
|
||||
});
|
||||
assert_eq!(
|
||||
dameng_sql,
|
||||
"CREATE TABLE \"APP\".USERS_COPY AS SELECT * FROM \"APP\".\"USERS\" WHERE 1=0;\nCOMMENT ON COLUMN \"APP\".USERS_COPY.\"DISPLAY\"\"NAME\" IS ' Owner''s; display name';\nCOMMENT ON COLUMN \"APP\".USERS_COPY.\"STATUS\" IS 'active ';"
|
||||
"CREATE TABLE \"APP\".USERS_COPY AS SELECT * FROM \"APP\".\"USERS\" WHERE 1=0;\nCOMMENT ON TABLE \"APP\".USERS_COPY IS '测试''克隆';\nCOMMENT ON COLUMN \"APP\".USERS_COPY.\"DISPLAY\"\"NAME\" IS ' Owner''s; display name';\nCOMMENT ON COLUMN \"APP\".USERS_COPY.\"STATUS\" IS 'active ';"
|
||||
);
|
||||
assert_eq!(
|
||||
crate::sql::split_sql_statements_for_database(&dameng_sql, DatabaseType::Dameng),
|
||||
vec![
|
||||
"CREATE TABLE \"APP\".USERS_COPY AS SELECT * FROM \"APP\".\"USERS\" WHERE 1=0".to_string(),
|
||||
"COMMENT ON TABLE \"APP\".USERS_COPY IS '测试''克隆'".to_string(),
|
||||
"COMMENT ON COLUMN \"APP\".USERS_COPY.\"DISPLAY\"\"NAME\" IS ' Owner''s; display name'".to_string(),
|
||||
"COMMENT ON COLUMN \"APP\".USERS_COPY.\"STATUS\" IS 'active '".to_string(),
|
||||
]
|
||||
);
|
||||
// Control chars / backslashes must not switch Dameng to Postgres E'...' literals.
|
||||
let dameng_escape_sql = build_duplicate_table_structure_sql(DuplicateTableStructureSqlOptions {
|
||||
database_type: Some(DatabaseType::Dameng),
|
||||
schema: Some("APP".to_string()),
|
||||
source_name: "USERS".to_string(),
|
||||
target_name: "users_copy".to_string(),
|
||||
table_comment: Some("line1\\path\nline2".to_string()),
|
||||
column_comments: vec![],
|
||||
});
|
||||
assert_eq!(
|
||||
dameng_escape_sql,
|
||||
"CREATE TABLE \"APP\".USERS_COPY AS SELECT * FROM \"APP\".\"USERS\" WHERE 1=0;\nCOMMENT ON TABLE \"APP\".USERS_COPY IS 'line1\\path\nline2';"
|
||||
);
|
||||
assert!(!dameng_escape_sql.contains("E'"));
|
||||
assert_eq!(
|
||||
build_duplicate_table_structure_sql(DuplicateTableStructureSqlOptions {
|
||||
database_type: Some(DatabaseType::Dameng),
|
||||
|
||||
Reference in new issue
Block a user