fix(clickhouse): create transfer tables in target database
This commit is contained in:
1 parent
f52064bd0e
commit
10019e4cc1
1 file changed
+21
-4
@@ -1444,6 +1444,18 @@ fn max_transfer_write_rows(db_type: &DatabaseType, mode: &TransferMode) -> usize
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn can_reuse_source_table_ddl(
|
||||||
|
source_db_type: &DatabaseType,
|
||||||
|
target_db_type: &DatabaseType,
|
||||||
|
preserves_target_table_name: bool,
|
||||||
|
) -> bool {
|
||||||
|
preserves_target_table_name
|
||||||
|
&& !matches!(target_db_type, DatabaseType::ClickHouse)
|
||||||
|
&& ((source_db_type == target_db_type)
|
||||||
|
|| (is_mysql_family_target(source_db_type) && is_mysql_family_target(target_db_type))
|
||||||
|
|| (is_postgres_family_target(source_db_type) && is_postgres_family_target(target_db_type)))
|
||||||
|
}
|
||||||
|
|
||||||
#[allow(clippy::too_many_arguments)]
|
#[allow(clippy::too_many_arguments)]
|
||||||
fn generate_transfer_write_sql(
|
fn generate_transfer_write_sql(
|
||||||
mode: &TransferMode,
|
mode: &TransferMode,
|
||||||
@@ -2977,10 +2989,8 @@ where
|
|||||||
.await
|
.await
|
||||||
.map_err(|e| format!("Failed to ensure schema exists: {e}"))?;
|
.map_err(|e| format!("Failed to ensure schema exists: {e}"))?;
|
||||||
}
|
}
|
||||||
let can_reuse_source_ddl = preserves_target_table_name
|
let can_reuse_source_ddl =
|
||||||
&& ((source_db_type == target_db_type)
|
can_reuse_source_table_ddl(source_db_type, target_db_type, preserves_target_table_name);
|
||||||
|| (is_mysql_family_target(source_db_type) && is_mysql_family_target(target_db_type))
|
|
||||||
|| (is_postgres_family_target(source_db_type) && is_postgres_family_target(target_db_type)));
|
|
||||||
let ddl = if can_reuse_source_ddl {
|
let ddl = if can_reuse_source_ddl {
|
||||||
crate::schema::get_table_ddl_core(
|
crate::schema::get_table_ddl_core(
|
||||||
&state,
|
&state,
|
||||||
@@ -3848,6 +3858,13 @@ mod tests {
|
|||||||
assert!(!ddl.contains("PRIMARY KEY"));
|
assert!(!ddl.contains("PRIMARY KEY"));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn clickhouse_transfer_does_not_reuse_source_table_ddl() {
|
||||||
|
assert!(!can_reuse_source_table_ddl(&DatabaseType::ClickHouse, &DatabaseType::ClickHouse, true));
|
||||||
|
assert!(can_reuse_source_table_ddl(&DatabaseType::Postgres, &DatabaseType::Postgres, true));
|
||||||
|
assert!(!can_reuse_source_table_ddl(&DatabaseType::Postgres, &DatabaseType::Postgres, false));
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn hive_create_table_uses_hive_friendly_columns() {
|
fn hive_create_table_uses_hive_friendly_columns() {
|
||||||
let cols = vec![
|
let cols = vec![
|
||||||
|
|||||||
Reference in new issue
Block a user