fix(desktop): unify grouped tab bar portal across special pages
This commit is contained in:
27 files changed
+1352
-590
No files matched your search
@@ -21,6 +21,17 @@ function roundTrip(tabs: QueryTab[]) {
|
||||
}
|
||||
|
||||
describe("openTabsPersistence originalSql round-trip", () => {
|
||||
it("preserves read-only source intent without adding editable source metadata", () => {
|
||||
const [restored] = roundTrip([queryTab({ sourceView: true, sql: "CREATE SEQUENCE seq_users" })]);
|
||||
expect(restored.sourceView).toBe(true);
|
||||
expect(restored.objectSource).toBeUndefined();
|
||||
});
|
||||
|
||||
it("keeps legacy query tabs without source intent compatible", () => {
|
||||
const [restored] = roundTrip([queryTab({ sql: "SELECT 1" })]);
|
||||
expect(restored.sourceView).toBeUndefined();
|
||||
});
|
||||
|
||||
it("restores a clean prefilled query tab as clean (sql === originalSql)", () => {
|
||||
const sql = 'SELECT * FROM "public"."users"';
|
||||
const [restored] = roundTrip([queryTab({ sql, originalSql: sql })]);
|
||||
|
||||
@@ -52,6 +52,7 @@ export interface SavedOpenTab {
|
||||
structureTableName?: string;
|
||||
objectBrowser?: QueryTab["objectBrowser"];
|
||||
objectSource?: QueryTab["objectSource"];
|
||||
sourceView?: boolean;
|
||||
tableMeta?: QueryTab["tableMeta"];
|
||||
mongoEditTarget?: QueryTab["mongoEditTarget"];
|
||||
resultEvicted?: boolean;
|
||||
@@ -146,6 +147,7 @@ export function serializeOpenTabs(tabs: QueryTab[]): SavedOpenTab[] {
|
||||
...(tab.structureTableName !== undefined ? { structureTableName: tab.structureTableName } : {}),
|
||||
objectBrowser: tab.objectBrowser,
|
||||
objectSource: tab.objectSource,
|
||||
...(tab.sourceView ? { sourceView: true } : {}),
|
||||
tableMeta: tab.tableMeta,
|
||||
...(tab.mongoEditTarget !== undefined ? { mongoEditTarget: tab.mongoEditTarget } : {}),
|
||||
...(tab.mode !== "data" && tab.resultEvicted ? { resultEvicted: true } : {}),
|
||||
|
||||
@@ -0,0 +1,31 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import type { QueryResult, QueryTab } from "@/types/database";
|
||||
import { hasQueryOutput } from "../queryOutput";
|
||||
|
||||
const emptyResult: QueryResult = { columns: ["id"], rows: [], affected_rows: 0, execution_time_ms: 1 };
|
||||
|
||||
describe("hasQueryOutput", () => {
|
||||
it("does not reserve output space for an idle query", () => {
|
||||
expect(hasQueryOutput(undefined)).toBe(false);
|
||||
expect(hasQueryOutput({ isExecuting: false, results: [], resultRuns: [] })).toBe(false);
|
||||
});
|
||||
|
||||
it.each<[string, Partial<QueryTab>]>([
|
||||
["running query", { isExecuting: true }],
|
||||
["running EXPLAIN", { isExplaining: true }],
|
||||
["zero-row SELECT", { result: emptyResult }],
|
||||
["DML summary", { result: { ...emptyResult, columns: [], affected_rows: 3 } }],
|
||||
["DDL summary", { result: { ...emptyResult, columns: [] } }],
|
||||
["query error", { result: { ...emptyResult, columns: ["Error"], rows: [["syntax error"]] } }],
|
||||
["multiple results", { results: [emptyResult] }],
|
||||
["retained result run", { resultRuns: [{ id: "run-1", title: "Result 1", sequence: 1, sql: "SELECT 1", createdAt: 1 }] }],
|
||||
["EXPLAIN plan", { explainPlan: { databaseType: "mysql", raw: {}, nodes: [] } }],
|
||||
["EXPLAIN table", { explainTableResult: emptyResult }],
|
||||
["EXPLAIN error", { explainError: "syntax error" }],
|
||||
["EXPLAIN table error", { explainTableError: "unsupported" }],
|
||||
["cached result", { resultEvicted: true, resultCacheState: "disk" }],
|
||||
["missing cached result", { resultEvicted: true, resultCacheState: "missing" }],
|
||||
])("retains output space for %s", (_, state) => {
|
||||
expect(hasQueryOutput({ isExecuting: false, ...state })).toBe(true);
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,7 @@
|
||||
import type { QueryTab } from "@/types/database";
|
||||
|
||||
type QueryOutputState = Pick<QueryTab, "result" | "results" | "resultRuns" | "resultEvicted" | "explainPlan" | "explainError" | "explainTableResult" | "explainTableError" | "isExecuting" | "isExplaining">;
|
||||
|
||||
export function hasQueryOutput(tab: QueryOutputState | null | undefined): boolean {
|
||||
return !!tab && (!!tab.result || !!tab.results?.length || !!tab.resultRuns?.length || tab.resultEvicted === true || !!tab.explainPlan || !!tab.explainError || !!tab.explainTableResult || !!tab.explainTableError || tab.isExecuting === true || tab.isExplaining === true);
|
||||
}
|
||||
Reference in new issue
Block a user