fix(desktop): unify grouped tab bar portal across special pages

This commit is contained in:
二丫讲梵 authored and GitHub committed 2026-09-06 20:39:34 +08:00
1 parent 3123e962c8
commit 148345494e
27 files changed
+1352 -590

No files matched your search

@@ -0,0 +1,31 @@
import { describe, expect, it } from "vitest";
import type { QueryResult, QueryTab } from "@/types/database";
import { hasQueryOutput } from "../queryOutput";
const emptyResult: QueryResult = { columns: ["id"], rows: [], affected_rows: 0, execution_time_ms: 1 };
describe("hasQueryOutput", () => {
it("does not reserve output space for an idle query", () => {
expect(hasQueryOutput(undefined)).toBe(false);
expect(hasQueryOutput({ isExecuting: false, results: [], resultRuns: [] })).toBe(false);
});
it.each<[string, Partial<QueryTab>]>([
["running query", { isExecuting: true }],
["running EXPLAIN", { isExplaining: true }],
["zero-row SELECT", { result: emptyResult }],
["DML summary", { result: { ...emptyResult, columns: [], affected_rows: 3 } }],
["DDL summary", { result: { ...emptyResult, columns: [] } }],
["query error", { result: { ...emptyResult, columns: ["Error"], rows: [["syntax error"]] } }],
["multiple results", { results: [emptyResult] }],
["retained result run", { resultRuns: [{ id: "run-1", title: "Result 1", sequence: 1, sql: "SELECT 1", createdAt: 1 }] }],
["EXPLAIN plan", { explainPlan: { databaseType: "mysql", raw: {}, nodes: [] } }],
["EXPLAIN table", { explainTableResult: emptyResult }],
["EXPLAIN error", { explainError: "syntax error" }],
["EXPLAIN table error", { explainTableError: "unsupported" }],
["cached result", { resultEvicted: true, resultCacheState: "disk" }],
["missing cached result", { resultEvicted: true, resultCacheState: "missing" }],
])("retains output space for %s", (_, state) => {
expect(hasQueryOutput({ isExecuting: false, ...state })).toBe(true);
});
});
@@ -0,0 +1,7 @@
import type { QueryTab } from "@/types/database";
type QueryOutputState = Pick<QueryTab, "result" | "results" | "resultRuns" | "resultEvicted" | "explainPlan" | "explainError" | "explainTableResult" | "explainTableError" | "isExecuting" | "isExplaining">;
export function hasQueryOutput(tab: QueryOutputState | null | undefined): boolean {
return !!tab && (!!tab.result || !!tab.results?.length || !!tab.resultRuns?.length || tab.resultEvicted === true || !!tab.explainPlan || !!tab.explainError || !!tab.explainTableResult || !!tab.explainTableError || tab.isExecuting === true || tab.isExplaining === true);
}