feat(export): add portable standard SQL inserts

Closes #9869
This commit is contained in:
t8y2 committed 2026-09-27 15:56:52 +00:00
1 parent ba3872abef
commit 1d07cb05e0
22 files changed
+384 -83

No files matched your search

+248 -59
View File
@@ -97,6 +97,20 @@ impl SqlInsertMode {
}
}
/// SQL dialect used to render exported INSERT statements.
///
/// `Source` preserves the database-specific output used by existing exports.
/// `Standard` emits portable SQL scalar literals and ANSI-delimited
/// identifiers while retaining the source database type for metadata rules
/// such as generated-column and synthetic-column omission.
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "kebab-case")]
pub enum SqlInsertDialect {
#[default]
Source,
Standard,
}
#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct DatabaseExportRequest {
@@ -133,6 +147,8 @@ pub struct DatabaseExportRequest {
#[serde(default)]
pub output_compression: DatabaseExportOutputCompression,
#[serde(default)]
pub insert_dialect: SqlInsertDialect,
#[serde(default)]
pub snapshot_session_id: Option<String>,
pub batch_size: usize,
/// When set, the export is packaged as a `.zip` archive containing
@@ -501,6 +517,8 @@ pub struct BuildExportInsertStatementsOptions {
pub struct BuildExportSqlInsertOptions {
#[serde(flatten)]
pub insert: BuildExportInsertStatementsOptions,
#[serde(default)]
pub insert_dialect: SqlInsertDialect,
/// 生成 INSERT 时需要排除的列名(例如导出时不带主键),忽略大小写匹配。
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub exclude_columns: Vec<String>,
@@ -518,6 +536,8 @@ pub struct BuildDatabaseSqlExportOptions {
pub row_limit_per_table: Option<usize>,
#[serde(default, skip_serializing_if = "Option::is_none")]
pub insert_batch_size: Option<usize>,
#[serde(default)]
pub insert_dialect: SqlInsertDialect,
/// Optional connection info for FK-aware table ordering.
/// When set, the caller should sort tables by dependency before passing them
/// to `build_database_sql_export`.
@@ -537,6 +557,21 @@ pub fn format_export_sql_literal(value: &Value) -> String {
format_export_sql_literal_for_database(value, None)
}
fn format_standard_sql_literal(value: &Value) -> String {
if value.is_null() {
return "NULL".to_string();
}
if let Some(number) = value.as_number() {
return number.to_string();
}
if let Some(value) = value.as_bool() {
return if value { "TRUE" } else { "FALSE" }.to_string();
}
let text = value.as_str().map_or_else(|| value.to_string(), ToString::to_string);
quote_standard_export_sql_string(&text)
}
fn format_export_sql_literal_for_database(value: &Value, database_type: Option<DatabaseType>) -> String {
if value.is_null() {
return "NULL".to_string();
@@ -641,9 +676,7 @@ fn quote_export_sql_string(text: &str) -> String {
format!("'{}'", text.replace('\\', "\\\\").replace('\'', "''"))
}
// OpenGauss exports use standard-conforming strings, so backslashes are
// literal and only embedded single quotes need doubling.
fn quote_opengauss_export_sql_string(text: &str) -> String {
fn quote_standard_export_sql_string(text: &str) -> String {
format!("'{}'", text.replace('\'', "''"))
}
@@ -656,7 +689,7 @@ fn quote_export_sql_string_for_database(text: &str, database_type: Option<Databa
match database_type {
Some(DatabaseType::Dameng) => quote_dameng_export_sql_string(text),
Some(DatabaseType::Postgres) => quote_postgres_string_literal(text),
Some(DatabaseType::OpenGauss) => quote_opengauss_export_sql_string(text),
Some(DatabaseType::OpenGauss) => quote_standard_export_sql_string(text),
database_type if is_mysql_compatible_export_literal_target(database_type) => {
quote_mysql_compatible_export_sql_string(text)
}
@@ -1185,7 +1218,7 @@ fn is_export_numeric_literal(text: &str) -> bool {
}
pub fn build_export_insert_statements(options: BuildExportInsertStatementsOptions) -> Result<Vec<String>, String> {
build_export_insert_statements_excluding(options, &[])
build_export_insert_statements_excluding_with_dialect(options, &[], SqlInsertDialect::Source)
}
/// 与 [`build_export_insert_statements`] 行为一致,但可以额外按列名排除若干列
@@ -1196,6 +1229,14 @@ pub fn build_export_insert_statements(options: BuildExportInsertStatementsOption
pub fn build_export_insert_statements_excluding(
options: BuildExportInsertStatementsOptions,
exclude_columns: &[String],
) -> Result<Vec<String>, String> {
build_export_insert_statements_excluding_with_dialect(options, exclude_columns, SqlInsertDialect::Source)
}
pub(crate) fn build_export_insert_statements_excluding_with_dialect(
options: BuildExportInsertStatementsOptions,
exclude_columns: &[String],
insert_dialect: SqlInsertDialect,
) -> Result<Vec<String>, String> {
if options.columns.is_empty() || options.rows.is_empty() {
return Ok(Vec::new());
@@ -1209,6 +1250,7 @@ pub fn build_export_insert_statements_excluding(
options.table_name.as_deref(),
options.qualified_table_name.as_deref(),
options.identifier_quote.as_deref(),
insert_dialect,
)?;
let spatial_columns =
options.spatial_columns.iter().map(|column| (column.column_index, column.srid)).collect::<HashMap<_, _>>();
@@ -1250,11 +1292,13 @@ pub fn build_export_insert_statements_excluding(
}
return Ok(Vec::new());
}
let batch_size = if options.database_type.is_some_and(uses_single_row_insert_statements) {
let batch_size = if insert_dialect == SqlInsertDialect::Source
&& options.database_type.is_some_and(uses_single_row_insert_statements)
{
1
} else {
let requested = options.batch_size.unwrap_or(DATABASE_EXPORT_INSERT_BATCH_SIZE).max(1);
if options.database_type == Some(DatabaseType::SqlServer) {
if insert_dialect == SqlInsertDialect::Source && options.database_type == Some(DatabaseType::SqlServer) {
requested.min(1000)
} else {
requested
@@ -1263,11 +1307,15 @@ pub fn build_export_insert_statements_excluding(
let columns = insert_columns
.iter()
.map(|(_, column, _)| {
crate::sql_dialect::quote_table_data_identifier(
options.database_type,
column,
options.identifier_quote.as_deref(),
)
if insert_dialect == SqlInsertDialect::Standard {
crate::sql_dialect::quote_table_identifier(None, column)
} else {
crate::sql_dialect::quote_table_data_identifier(
options.database_type,
column,
options.identifier_quote.as_deref(),
)
}
})
.collect::<Vec<_>>()
.join(", ");
@@ -1275,11 +1323,11 @@ pub fn build_export_insert_statements_excluding(
// Dameng and SQL Server both reject explicit values for identity columns
// unless `SET IDENTITY_INSERT <table> ON` wraps the statement (SQL Server
// error 544), so exported INSERTs must carry the wrapper.
let needs_identity_insert_wrapper =
matches!(options.database_type, Some(DatabaseType::Dameng) | Some(DatabaseType::SqlServer))
&& insert_columns.iter().any(|(index, _, _)| {
is_identity_column_extra(options.column_extras.get(*index).and_then(|value| value.as_deref()))
});
let needs_identity_insert_wrapper = insert_dialect == SqlInsertDialect::Source
&& matches!(options.database_type, Some(DatabaseType::Dameng) | Some(DatabaseType::SqlServer))
&& insert_columns.iter().any(|(index, _, _)| {
is_identity_column_extra(options.column_extras.get(*index).and_then(|value| value.as_deref()))
});
// Multi-row batches are written one tuple per line (issue #9814) so exported
// `.sql` files stay readable in plain text editors. Statements that hold a
@@ -1287,9 +1335,10 @@ pub fn build_export_insert_statements_excluding(
// the "one INSERT per row" output of the single-row insert mode.
let statement_head = format!("INSERT INTO {table} ({columns}) VALUES");
let statement_prefix = format!("{statement_head} ");
let statement_overhead_bytes = export_sql_statement_bytes(options.database_type, &statement_prefix) + 1;
let output_database_type = if insert_dialect == SqlInsertDialect::Source { options.database_type } else { None };
let statement_overhead_bytes = export_sql_statement_bytes(output_database_type, &statement_prefix) + 1;
let target_statement_bytes = DATABASE_EXPORT_TARGET_STATEMENT_BYTES;
let separator_bytes = export_sql_statement_bytes(options.database_type, ",\n");
let separator_bytes = export_sql_statement_bytes(output_database_type, ",\n");
let mut current_values = String::new();
let mut current_values_bytes = 0usize;
let mut current_row_count = 0usize;
@@ -1331,16 +1380,21 @@ pub fn build_export_insert_statements_excluding(
.copied()
.flatten()
.or_else(|| spatial_columns.get(index).copied().flatten());
rendered_row.push_str(&format_export_sql_literal_typed_with_spatial(
value,
options.database_type,
column_type,
*sqlserver_unicode_string,
spatial_srid,
));
let literal = if insert_dialect == SqlInsertDialect::Standard {
format_standard_sql_literal(value)
} else {
format_export_sql_literal_typed_with_spatial(
value,
options.database_type,
column_type,
*sqlserver_unicode_string,
spatial_srid,
)
};
rendered_row.push_str(&literal);
}
rendered_row.push(')');
let rendered_row_bytes = export_sql_statement_bytes(options.database_type, &rendered_row);
let rendered_row_bytes = export_sql_statement_bytes(output_database_type, &rendered_row);
let candidate_bytes = statement_overhead_bytes
+ current_values_bytes
+ if current_row_count == 0 { 0 } else { separator_bytes }
@@ -1423,8 +1477,12 @@ fn is_postgres_bytea_export_column(database_type: Option<DatabaseType>, column_t
}
pub fn build_export_sql_insert(options: BuildExportSqlInsertOptions) -> Result<String, String> {
build_export_insert_statements_excluding(options.insert, &options.exclude_columns)
.map(|statements| statements.join("\n"))
build_export_insert_statements_excluding_with_dialect(
options.insert,
&options.exclude_columns,
options.insert_dialect,
)
.map(|statements| statements.join("\n"))
}
pub fn build_database_sql_export(options: BuildDatabaseSqlExportOptions) -> Result<String, String> {
@@ -1458,20 +1516,24 @@ pub fn build_database_sql_export(options: BuildDatabaseSqlExportOptions) -> Resu
lines.push(format!("-- Exported rows: {}", table.rows.len()));
}
let inserts = build_export_insert_statements(BuildExportInsertStatementsOptions {
database_type: table.database_type,
identifier_quote: table.identifier_quote.clone(),
schema: table.schema,
table_name: table.table_name,
qualified_table_name: table.qualified_table_name,
columns: table.columns,
column_types: table.column_types,
column_extras: table.column_extras,
spatial_columns: table.spatial_columns,
spatial_values: table.spatial_values,
rows: table.rows,
batch_size: Some(insert_batch_size),
})?;
let inserts = build_export_insert_statements_excluding_with_dialect(
BuildExportInsertStatementsOptions {
database_type: table.database_type,
identifier_quote: table.identifier_quote.clone(),
schema: table.schema,
table_name: table.table_name,
qualified_table_name: table.qualified_table_name,
columns: table.columns,
column_types: table.column_types,
column_extras: table.column_extras,
spatial_columns: table.spatial_columns,
spatial_values: table.spatial_values,
rows: table.rows,
batch_size: Some(insert_batch_size),
},
&[],
options.insert_dialect,
)?;
if inserts.is_empty() {
lines.push("-- No rows".to_string());
} else {
@@ -1489,7 +1551,19 @@ fn export_qualified_table_name(
table_name: Option<&str>,
qualified_name: Option<&str>,
identifier_quote: Option<&str>,
insert_dialect: SqlInsertDialect,
) -> Result<String, String> {
if insert_dialect == SqlInsertDialect::Standard {
let table_name = table_name
.filter(|name| !name.trim().is_empty())
.ok_or_else(|| "tableName is required for Standard SQL INSERT output".to_string())?;
let table = crate::sql_dialect::quote_table_identifier(None, table_name);
return Ok(schema
.map(str::trim)
.filter(|schema| !schema.is_empty())
.map(|schema| format!("{}.{}", crate::sql_dialect::quote_table_identifier(None, schema), table))
.unwrap_or(table));
}
if let Some(name) = qualified_name.filter(|name| !name.trim().is_empty()) {
return Ok(name.to_string());
}
@@ -2244,6 +2318,7 @@ fn write_database_export_rows<W: Write>(
table: &str,
schema: &str,
db_type: &DatabaseType,
insert_dialect: SqlInsertDialect,
) -> Result<(), String> {
let insert_indices = columns
.iter()
@@ -2293,20 +2368,24 @@ fn write_database_export_rows<W: Write>(
// Batch database exports do not currently thread a per-connection identifier
// quote through BuildDatabaseSqlExportOptions; Kingbase MySQL-compat users
// should fall back to the single-table export path which carries the quote.
let statements = build_export_insert_statements(BuildExportInsertStatementsOptions {
database_type: Some(*db_type),
identifier_quote: None,
schema: (!schema.is_empty()).then(|| schema.to_string()),
table_name: Some(table.to_string()),
qualified_table_name: Some(qualified_table_name),
columns: insert_columns.to_vec(),
column_types: insert_column_types.to_vec(),
column_extras: insert_column_extras.to_vec(),
spatial_columns: Vec::new(),
spatial_values: Vec::new(),
rows: insert_rows.to_vec(),
batch_size: Some(DATABASE_EXPORT_INSERT_BATCH_SIZE),
})?;
let statements = build_export_insert_statements_excluding_with_dialect(
BuildExportInsertStatementsOptions {
database_type: Some(*db_type),
identifier_quote: None,
schema: (!schema.is_empty()).then(|| schema.to_string()),
table_name: Some(table.to_string()),
qualified_table_name: Some(qualified_table_name),
columns: insert_columns.to_vec(),
column_types: insert_column_types.to_vec(),
column_extras: insert_column_extras.to_vec(),
spatial_columns: Vec::new(),
spatial_values: Vec::new(),
rows: insert_rows.to_vec(),
batch_size: Some(DATABASE_EXPORT_INSERT_BATCH_SIZE),
},
&[],
insert_dialect,
)?;
for statement in statements {
writeln!(file, "{statement}\n").map_err(|error| format!("Failed to write file: {error}"))?;
}
@@ -3688,6 +3767,7 @@ async fn export_database_sql_core_inner(
table_name,
&request.schema,
&db_type,
request.insert_dialect,
)?;
total_rows_exported += rows.len() as u64;
on_progress(ExportProgress {
@@ -3804,6 +3884,7 @@ async fn export_database_sql_core_inner(
table_name,
&request.schema,
&db_type,
request.insert_dialect,
)?;
total_rows_exported += row_count as u64;
if use_keyset {
@@ -4195,8 +4276,9 @@ mod tests {
sort_export_views_by_dependencies, split_postgres_export_table_triggers, write_database_export_rows,
BuildDatabaseSqlExportOptions, BuildExportInsertStatementsOptions, BuildExportSqlInsertOptions,
DatabaseExportObjectCounts, DatabaseExportRequest, DatabaseExportWriter, DdlNormalizeOptions, ExportedTableSql,
PostgresExportExtension, PostgresExportSequence, PostgresExtensionMembers, DATABASE_EXPORT_INSERT_BATCH_SIZE,
DATABASE_EXPORT_ROW_LIMIT, POSTGRES_EXPORT_SEQUENCES_COMPAT_SQL, POSTGRES_EXPORT_SEQUENCES_SQL,
PostgresExportExtension, PostgresExportSequence, PostgresExtensionMembers, SqlInsertDialect,
DATABASE_EXPORT_INSERT_BATCH_SIZE, DATABASE_EXPORT_ROW_LIMIT, POSTGRES_EXPORT_SEQUENCES_COMPAT_SQL,
POSTGRES_EXPORT_SEQUENCES_SQL,
};
use super::{ExportProgress, LenientExportErrors};
use crate::connection::AppState;
@@ -4396,12 +4478,38 @@ mod tests {
fail_on_error: false,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: None,
batch_size: 1000,
split_max_mb: None,
}
}
#[test]
fn database_export_request_defaults_to_source_insert_dialect_and_accepts_standard() {
let mut payload = json!({
"exportId": "export-1",
"connectionId": "connection-1",
"database": "app",
"schema": "dbo",
"filePath": "app.sql",
"includeStructure": false,
"includeData": true,
"includeObjects": false,
"batchSize": 1000
});
let legacy: DatabaseExportRequest =
serde_json::from_value(payload.clone()).expect("deserialize legacy database export request");
assert_eq!(legacy.insert_dialect, SqlInsertDialect::Source);
payload["insertDialect"] = json!("standard");
let standard: DatabaseExportRequest =
serde_json::from_value(payload).expect("deserialize Standard SQL database export request");
assert_eq!(standard.insert_dialect, SqlInsertDialect::Standard);
assert_eq!(serde_json::to_value(standard).unwrap()["insertDialect"], json!("standard"));
}
#[test]
fn gzip_export_writer_finishes_a_readable_stream() {
let directory = tempfile::tempdir().unwrap();
@@ -6057,11 +6165,62 @@ mod tests {
}))
.expect("deserialize export insert payload");
assert_eq!(options.insert_dialect, SqlInsertDialect::Source);
let sql = build_export_sql_insert(options).expect("build export sql insert");
assert_eq!(sql, "INSERT INTO \"public\".\"users\" (\"name\") VALUES ('Ada');");
}
#[test]
fn standard_sql_insert_uses_ansi_identifiers_and_portable_scalar_literals() {
let options: BuildExportSqlInsertOptions = serde_json::from_value(json!({
"databaseType": "sqlserver",
"identifierQuote": "[",
"insertDialect": "standard",
"schema": "sales\"ops",
"tableName": "order]items",
"columns": ["id", "select", "full\"name", "payload"],
"columnTypes": ["int", "bit", "nvarchar(100)", "json"],
"columnExtras": ["identity(1,1)", null, null, null],
"rows": [
[1, true, "C:\\tmp\\O'Hara", ["x", 2]],
[2, false, "plain", null]
],
"batchSize": 10
}))
.expect("deserialize Standard SQL INSERT payload");
let sql = build_export_sql_insert(options).expect("build Standard SQL INSERT");
assert_eq!(
sql,
r#"INSERT INTO "sales""ops"."order]items" ("id", "select", "full""name", "payload") VALUES
(1, TRUE, 'C:\tmp\O''Hara', '["x",2]'),
(2, FALSE, 'plain', NULL);"#
);
assert!(!sql.contains("IDENTITY_INSERT"));
assert!(!sql.contains("N'"));
}
#[test]
fn standard_sql_insert_keeps_requested_batch_mode_for_oracle_sources() {
let options: BuildExportSqlInsertOptions = serde_json::from_value(json!({
"databaseType": "oracle",
"insertDialect": "standard",
"schema": "APP",
"tableName": "USERS",
"columns": ["ID"],
"rows": [[1], [2]],
"batchSize": 10
}))
.expect("deserialize Standard SQL INSERT payload");
let sql = build_export_sql_insert(options).expect("build Standard SQL INSERT");
assert_eq!(sql, "INSERT INTO \"APP\".\"USERS\" (\"ID\") VALUES\n(1),\n(2);");
}
#[test]
fn mysql_generated_columns_are_omitted_from_sql_inserts_but_kept_in_ddl() {
let ddl = "CREATE TABLE `orders` (`id` bigint AUTO_INCREMENT, `quantity` int, `unit_price` decimal(10,2), `virtual_total` decimal(10,2) GENERATED ALWAYS AS ((`quantity` * `unit_price`)) VIRTUAL, `stored_total` decimal(10,2) GENERATED ALWAYS AS ((`quantity` * `unit_price`)) STORED);";
@@ -6107,6 +6266,7 @@ mod tests {
}],
row_limit_per_table: Some(DATABASE_EXPORT_ROW_LIMIT),
insert_batch_size: Some(DATABASE_EXPORT_INSERT_BATCH_SIZE),
insert_dialect: SqlInsertDialect::Source,
connection_id: None,
database: None,
schema: None,
@@ -6146,6 +6306,7 @@ mod tests {
"orders",
"shop",
&DatabaseType::Mysql,
SqlInsertDialect::Source,
)
.unwrap();
drop(file);
@@ -6156,6 +6317,32 @@ mod tests {
);
}
#[test]
fn database_row_writer_forwards_the_standard_insert_dialect() {
let directory = tempfile::tempdir().unwrap();
let path = directory.path().join("events.sql");
let mut file = std::fs::File::create(&path).unwrap();
write_database_export_rows(
&mut file,
&[vec![json!(true), json!(r"C:\exports\O'Hara")]],
&["enabled".to_string(), "path".to_string()],
&[Some("bit".to_string()), Some("nvarchar(255)".to_string())],
&[None, None],
"event]log",
"dbo",
&DatabaseType::SqlServer,
SqlInsertDialect::Standard,
)
.unwrap();
drop(file);
assert_eq!(
std::fs::read_to_string(path).unwrap(),
"INSERT INTO \"dbo\".\"event]log\" (\"enabled\", \"path\") VALUES (TRUE, 'C:\\exports\\O''Hara');\n\n"
);
}
#[test]
fn split_zip_export_writer_splits_across_insert_batches_into_valid_sql() {
let directory = tempfile::tempdir().unwrap();
@@ -6182,6 +6369,7 @@ mod tests {
"orders",
"shop",
&DatabaseType::Postgres,
SqlInsertDialect::Source,
)
.unwrap();
}
@@ -6364,6 +6552,7 @@ mod tests {
}],
row_limit_per_table: Some(DATABASE_EXPORT_ROW_LIMIT),
insert_batch_size: Some(DATABASE_EXPORT_INSERT_BATCH_SIZE),
insert_dialect: SqlInsertDialect::Source,
connection_id: None,
database: None,
schema: None,
+32 -8
View File
@@ -21,8 +21,8 @@ use crate::csv_export::{
use crate::data_grid_sql::extra_is_auto_generated;
pub use crate::database_export::ExportStatus;
use crate::database_export::{
build_export_insert_statements_excluding, is_export_cancelled, is_internal_export_column,
BuildExportInsertStatementsOptions, SqlInsertMode,
build_export_insert_statements_excluding_with_dialect, is_export_cancelled, is_internal_export_column,
BuildExportInsertStatementsOptions, SqlInsertDialect, SqlInsertMode,
};
use crate::db::agent_driver::AgentTableReadStartParams;
use crate::models::connection::DatabaseType;
@@ -84,6 +84,8 @@ pub struct TableExportRequest {
#[serde(default)]
pub insert_mode: SqlInsertMode,
#[serde(default)]
pub insert_dialect: SqlInsertDialect,
#[serde(default)]
pub csv_quote_mode: CsvQuoteMode,
#[serde(default)]
pub columns: Option<Vec<String>>,
@@ -1369,7 +1371,7 @@ async fn try_export_native_table_stream(
if pending_rows.is_empty() {
return Ok(());
}
let statements = build_export_insert_statements_excluding(
let statements = build_export_insert_statements_excluding_with_dialect(
BuildExportInsertStatementsOptions {
database_type: Some(*db_type),
identifier_quote: request.identifier_quote.clone(),
@@ -1385,6 +1387,7 @@ async fn try_export_native_table_stream(
batch_size: Some(request.insert_mode.batch_size(SQL_INSERT_BATCH_SIZE)),
},
&sql_export_excluded_columns(request, primary_keys, col_names, column_extras),
request.insert_dialect,
)?;
if !statements.is_empty() {
if wrote_statements {
@@ -2217,7 +2220,7 @@ async fn export_table_data_core_inner(
break;
}
let statements = build_export_insert_statements_excluding(
let statements = build_export_insert_statements_excluding_with_dialect(
BuildExportInsertStatementsOptions {
database_type: Some(db_type),
identifier_quote: request.identifier_quote.clone(),
@@ -2233,6 +2236,7 @@ async fn export_table_data_core_inner(
batch_size: Some(request.insert_mode.batch_size(SQL_INSERT_BATCH_SIZE)),
},
&sql_export_excluded_columns(request, &primary_keys, &col_names, &column_extras),
request.insert_dialect,
)?;
if !statements.is_empty() {
if wrote_statements {
@@ -2307,8 +2311,8 @@ mod tests {
use std::os::unix::fs::PermissionsExt;
#[test]
fn table_export_request_defaults_to_batch_insert_mode() {
let request: TableExportRequest = serde_json::from_value(json!({
fn table_export_request_defaults_to_source_dialect_and_batch_insert_mode() {
let mut payload = json!({
"exportId": "export-1",
"connectionId": "conn-1",
"database": "db",
@@ -2316,10 +2320,18 @@ mod tests {
"tableName": "users",
"filePath": "users.sql",
"format": "sql"
}))
.expect("deserialize table export request");
});
let request: TableExportRequest =
serde_json::from_value(payload.clone()).expect("deserialize table export request");
assert_eq!(request.insert_mode, SqlInsertMode::Batch);
assert_eq!(request.insert_dialect, SqlInsertDialect::Source);
payload["insertDialect"] = json!("standard");
let request: TableExportRequest =
serde_json::from_value(payload).expect("deserialize Standard SQL table export request");
assert_eq!(request.insert_dialect, SqlInsertDialect::Standard);
assert_eq!(serde_json::to_value(request).unwrap()["insertDialect"], json!("standard"));
}
#[cfg(unix)]
@@ -2415,6 +2427,7 @@ mod tests {
file_path: output.to_string_lossy().into_owned(),
format: "csv".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: Some(vec!["id".to_string(), "name".to_string()]),
column_types: Some(vec![Some("INTEGER".to_string()), Some("VARCHAR".to_string())]),
column_extras: None,
@@ -2580,6 +2593,7 @@ mod tests {
file_path: output.to_string_lossy().into_owned(),
format: "csv".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
csv_quote_mode: CsvQuoteMode::All,
exclude_primary_keys: false,
columns: None,
@@ -2748,6 +2762,7 @@ mod tests {
file_path: "device2.csv".to_string(),
format: "csv".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: None,
column_types: None,
column_extras: None,
@@ -2809,6 +2824,7 @@ mod tests {
file_path: "device2.csv".to_string(),
format: "csv".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: None,
column_types: None,
column_extras: None,
@@ -2848,6 +2864,7 @@ mod tests {
file_path: "device2.csv".to_string(),
format: "csv".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: None,
column_types: None,
column_extras: None,
@@ -2882,6 +2899,7 @@ mod tests {
file_path: "device2.csv".to_string(),
format: "csv".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: None,
column_types: None,
column_extras: None,
@@ -2924,6 +2942,7 @@ mod tests {
file_path: "samples.csv".to_string(),
format: "csv".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: None,
column_types: None,
column_extras: None,
@@ -2978,6 +2997,7 @@ mod tests {
file_path: "events.csv".to_string(),
format: "csv".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: None,
column_types: None,
column_extras: None,
@@ -3026,6 +3046,7 @@ mod tests {
file_path: "orders.txt".to_string(),
format: "txt".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: None,
column_types: None,
column_extras: None,
@@ -3102,6 +3123,7 @@ mod tests {
file_path: "order.csv".to_string(),
format: "csv".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: None,
column_types: None,
column_extras: None,
@@ -3160,6 +3182,7 @@ mod tests {
file_path: "spatial_data.sql".to_string(),
format: "sql".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: None,
column_types: None,
column_extras: None,
@@ -3220,6 +3243,7 @@ mod tests {
file_path: "users.sql".to_string(),
format: "sql".to_string(),
insert_mode: Default::default(),
insert_dialect: Default::default(),
columns: None,
column_types: None,
column_extras: None,
@@ -338,6 +338,7 @@ impl BackupService {
} else {
DatabaseExportOutputCompression::None
},
insert_dialect: Default::default(),
snapshot_session_id: Some(snapshot.session_id.clone()),
batch_size: 1000,
split_max_mb: None,
@@ -138,6 +138,7 @@ async fn run_database_export_of_partition_tree_has_no_duplicates_and_replays() {
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: None,
batch_size: 1000,
split_max_mb: None,
@@ -77,6 +77,7 @@ async fn run_database_export_writes_structure_and_data_for_all_tables() {
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: None,
batch_size: 1000,
split_max_mb: None,
@@ -330,6 +330,7 @@ async fn live_postgres_backup_snapshot_exports_wide_jsonb_then_next_table_inner(
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: Some(snapshot.session_id.clone()),
batch_size: 1000,
split_max_mb: None,
@@ -445,6 +446,7 @@ async fn live_postgres_backup_snapshot_cancel_interrupts_pending_row_inner() {
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: Some(snapshot.session_id.clone()),
batch_size: 1,
split_max_mb: None,
@@ -562,6 +564,7 @@ async fn live_mysql_database_backup_refreshes_an_idle_snapshot_before_export() {
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: Some(snapshot.session_id.clone()),
batch_size: 100,
split_max_mb: None,
@@ -153,6 +153,7 @@ async fn live_mysql_database_export_restores_dependent_views() {
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: None,
batch_size: 1000,
split_max_mb: None,
@@ -293,6 +294,7 @@ async fn run_live_mysql_database_export_handles_many_tables_including_empty_tabl
fail_on_error: false,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: None,
batch_size: 1000,
split_max_mb: None,
@@ -388,6 +390,7 @@ async fn live_mysql_database_export_creates_missing_destination_directory() {
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: None,
batch_size: 1000,
split_max_mb: None,
@@ -465,6 +468,7 @@ async fn live_mysql_database_export_refuses_to_recreate_a_destination_that_disap
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: None,
batch_size: 1000,
split_max_mb: None,
@@ -553,6 +557,7 @@ async fn live_mysql_database_export_refuses_a_destination_that_vanished_before_i
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: None,
batch_size: 1000,
split_max_mb: None,
@@ -102,6 +102,7 @@ async fn live_mysql_database_export_table_order_is_not_alphabetical_when_fk_reor
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: None,
batch_size: 1000,
split_max_mb: None,
@@ -112,6 +112,7 @@ async fn live_postgres_all_schema_export_restores_one_sql_file() {
fail_on_error: true,
prevent_overwrite: false,
output_compression: Default::default(),
insert_dialect: Default::default(),
snapshot_session_id: None,
batch_size: 1000,
split_max_mb: None,