github/dbx
4
0 Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-11-15 14:52:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(grid): optimize bulk edit performance

Browse Source
This commit is contained in:
GIWTO authored and GitHub committed 2026-07-25 20:06:25 +08:00
1 parent e6da0a6298
commit 1e21a5ad52
3 files changed
+151 -39
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

apps/desktop/src/components/grid/DataGrid.vue
+41 -24
View File
@@ -2769,6 +2769,8 @@ const {
isSaving,
saveError,
useTransaction,
beginBatch,
commitBatch,
exitTransaction,
startEdit,
commitEdit,
@@ -5474,28 +5476,33 @@ function fillSelectionWithValue(value: string | null): boolean {
const range = selectedRange.value;
let applied = false;
const allowDraftSelectionValue = selectedRangeTargetsOnlyDraftRow();
if (range) {
for (let rowIndex = range.startRow; rowIndex <= range.endRow; rowIndex++) {
beginBatch();
try {
if (range) {
for (let rowIndex = range.startRow; rowIndex <= range.endRow; rowIndex++) {
const item = displayItemAt(rowIndex);
if (!item) continue;
for (let visibleCol = range.startCol; visibleCol <= range.endCol; visibleCol++) {
applied = applyVisibleSelectedCellValue(item, visibleCol, value, allowDraftSelectionValue) || applied;
}
}
return applied;
}
if (!hasColumnSelection.value) return false;
const visibleColumnIndexes = selectedVisibleColumnIndexes();
if (!visibleColumnIndexes.length) return false;
for (let rowIndex = 0; rowIndex < displayRowCount.value; rowIndex++) {
const item = displayItemAt(rowIndex);
if (!item) continue;
for (let visibleCol = range.startCol; visibleCol <= range.endCol; visibleCol++) {
applied = applyVisibleSelectedCellValue(item, visibleCol, value, allowDraftSelectionValue) || applied;
for (const visibleCol of visibleColumnIndexes) {
applied = applyVisibleSelectedCellValue(item, visibleCol, value) || applied;
}
}
return applied;
} finally {
commitBatch();
}
if (!hasColumnSelection.value) return false;
const visibleColumnIndexes = selectedVisibleColumnIndexes();
if (!visibleColumnIndexes.length) return false;
for (let rowIndex = 0; rowIndex < displayRowCount.value; rowIndex++) {
const item = displayItemAt(rowIndex);
if (!item) continue;
for (const visibleCol of visibleColumnIndexes) {
applied = applyVisibleSelectedCellValue(item, visibleCol, value) || applied;
}
}
return applied;
}
function selectionHasEditableCells(): boolean {
@@ -5578,9 +5585,14 @@ function applyGeneratedSelectionValue(kind: CellValueGenerationKind, startValue
const values = generateCellValues(kind, cells.length, { startValue });
const allowDraftSelectionValue = selectedRangeTargetsOnlyDraftRow();
let applied = false;
cells.forEach((cell, index) => {
applied = applyVisibleSelectedCellValue(cell.item, cell.visibleCol, values[index] ?? null, allowDraftSelectionValue, { preserveEmptyString: kind === "empty" }) || applied;
});
beginBatch();
try {
cells.forEach((cell, index) => {
applied = applyVisibleSelectedCellValue(cell.item, cell.visibleCol, values[index] ?? null, allowDraftSelectionValue, { preserveEmptyString: kind === "empty" }) || applied;
});
} finally {
commitBatch();
}
if (applied) toast(t("grid.generatedValuesApplied", { count: cells.length }));
return applied;
}
@@ -5634,12 +5646,17 @@ function cutSelection() {
copySelectionTsv();
const range = selectedRange.value;
const allowDraftSelectionValue = selectedRangeTargetsOnlyDraftRow();
for (let rowIndex = range.startRow; rowIndex <= range.endRow; rowIndex++) {
const item = displayItemAt(rowIndex);
if (!item) continue;
for (let visibleCol = range.startCol; visibleCol <= range.endCol; visibleCol++) {
applyVisibleSelectedCellValue(item, visibleCol, null, allowDraftSelectionValue);
beginBatch();
try {
for (let rowIndex = range.startRow; rowIndex <= range.endRow; rowIndex++) {
const item = displayItemAt(rowIndex);
if (!item) continue;
for (let visibleCol = range.startCol; visibleCol <= range.endCol; visibleCol++) {
applyVisibleSelectedCellValue(item, visibleCol, null, allowDraftSelectionValue);
}
}
} finally {
commitBatch();
}
}