github/dbx
4
0
Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-10-19 16:16:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(grid): keep unpaginated query results on a single page

Browse Source
This commit is contained in:
Jeff
2026-10-14 14:05:31 +08:00
committed by GitHub
parent 95d3e80004
commit 240039f48d
3 changed files with 22 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app-tests/dataGridPagination.test.ts
Vendored
+9
View File
@@ -171,6 +171,15 @@ test("user LIMIT larger than the page size still pages up to the bound", () => {
assert.equal(canGoNextDataGridPage({ rowCount: 100, pageSize: 100, pageOffset: 400, totalRowCount: 500 }), false);
});
test("a result loaded without server-side pagination is a single page", () => {
// `SHOW BINLOG EVENTS` cannot be wrapped in LIMIT/OFFSET, so every row comes
// back at once and the grid renders all of them. Another page would only
// shift the row numbers over the same rows (#12107).
assert.equal(canGoNextDataGridPage({ rowCount: 5_693, pageSize: 100, allRowsLoaded: true }), false);
assert.equal(canGoNextDataGridPage({ rowCount: 5_693, pageSize: 100, totalRowCount: 5_693, allRowsLoaded: true }), false);
assert.equal(canGoNextDataGridPage({ hasMore: true, rowCount: 100_000, pageSize: 100, allRowsLoaded: true }), false);
});
test("infinite scroll compares cumulative loaded rows with a known total", () => {
assert.equal(canFetchNextDataGridSegment({ loadedRowCount: 1_000, pageSize: 1_000, totalRowCount: 2_000 }), true);
assert.equal(canFetchNextDataGridSegment({ loadedRowCount: 2_000, pageSize: 1_000, totalRowCount: 2_000 }), false);