fix(starrocks): preserve JSON arrays during CSV import

Closes #10470
This commit is contained in:
t8y2 committed 2026-09-28 19:07:08 +08:00
1 parent 4190bab5ad
commit 284483031d
2 files changed
+42

No files matched your search

+15
View File
@@ -11616,6 +11616,21 @@ mod tests {
]); ]);
} }
#[test]
fn starrocks_csv_json_array_import_uses_typed_json_expression() {
let plan = CompiledImportPlan {
mapped_source_indexes: vec![0],
target_columns: vec!["organization_path".to_string()],
column_types: vec![Some("array<json>".to_string())],
};
let rows = vec![vec![serde_json::json!(r#"[{"lvl1_org_code":"50001963","nested":{"enabled":true}}]"#)]];
assert_eq!(
import_value_rows_sql(&rows, &plan, &DatabaseType::StarRocks, false, None),
vec![r#"(CAST(PARSE_JSON('[{"lvl1_org_code":"50001963","nested":{"enabled":true}}]') AS ARRAY<JSON>))"#]
);
}
#[test] #[test]
fn import_conflict_policy_keeps_default_and_skip_sql_unchanged() { fn import_conflict_policy_keeps_default_and_skip_sql_unchanged() {
let plan = CompiledImportPlan { let plan = CompiledImportPlan {
+27
View File
@@ -2939,6 +2939,9 @@ pub fn escape_value_typed(val: &serde_json::Value, db_type: &DatabaseType, colum
} }
} }
serde_json::Value::String(s) => { serde_json::Value::String(s) => {
if let Some(json_array_literal) = format_starrocks_json_array_sql_literal(s, db_type, column_type) {
return json_array_literal;
}
if let Some(integer_literal) = normalize_integer_literal(s, db_type, column_type) { if let Some(integer_literal) = normalize_integer_literal(s, db_type, column_type) {
return integer_literal; return integer_literal;
} }
@@ -3008,6 +3011,30 @@ pub fn escape_value_typed(val: &serde_json::Value, db_type: &DatabaseType, colum
} }
} }
fn format_starrocks_json_array_sql_literal(
value: &str,
db_type: &DatabaseType,
column_type: Option<&str>,
) -> Option<String> {
if *db_type != DatabaseType::StarRocks || !column_type.is_some_and(is_starrocks_json_array_type) {
return None;
}
let parsed = serde_json::from_str::<serde_json::Value>(value.trim()).ok()?;
if !parsed.is_array() {
return None;
}
let json = parsed.to_string().replace('\\', "\\\\").replace('\'', "''");
Some(format!("CAST(PARSE_JSON('{json}') AS ARRAY<JSON>)"))
}
fn is_starrocks_json_array_type(column_type: &str) -> bool {
column_type
.chars()
.filter(|character| !character.is_ascii_whitespace())
.collect::<String>()
.eq_ignore_ascii_case("array<json>")
}
fn is_mysql_bit_type(column_type: &str) -> bool { fn is_mysql_bit_type(column_type: &str) -> bool {
let trimmed = column_type.trim(); let trimmed = column_type.trim();
let lower = trimmed.to_ascii_lowercase(); let lower = trimmed.to_ascii_lowercase();