1 parent
a99b75a8c5
commit
2b8a5c8897
3 files changed
+60
No files matched your search
@@ -4,6 +4,7 @@ import {
|
|||||||
buildTableImportParseOptions,
|
buildTableImportParseOptions,
|
||||||
defaultTableImportEmptyStringAsNull,
|
defaultTableImportEmptyStringAsNull,
|
||||||
formatTableImportElapsed,
|
formatTableImportElapsed,
|
||||||
|
importDataTypeForDatabase,
|
||||||
nextTableImportWizardStep,
|
nextTableImportWizardStep,
|
||||||
previousTableImportWizardStep,
|
previousTableImportWizardStep,
|
||||||
requiredImportTargetColumns,
|
requiredImportTargetColumns,
|
||||||
@@ -131,4 +132,18 @@ describe("tableImport", () => {
|
|||||||
created_at: "DATETIME",
|
created_at: "DATETIME",
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("uses SQL Server FLOAT for inferred decimal columns", () => {
|
||||||
|
expect(suggestImportTargetDataTypes(["id", "active", "amount", "created_at", "notes"], [[1001, true, "12.5", "2026-07-07 08:15:00", "invoice"]], "sqlserver")).toEqual({
|
||||||
|
id: "BIGINT",
|
||||||
|
active: "BIT",
|
||||||
|
amount: "FLOAT",
|
||||||
|
created_at: "DATETIME2",
|
||||||
|
notes: "NVARCHAR(MAX)",
|
||||||
|
});
|
||||||
|
expect(importDataTypeForDatabase("decimal", "mysql")).toBe("DOUBLE");
|
||||||
|
expect(importDataTypeForDatabase("decimal", "postgres")).toBe("DOUBLE PRECISION");
|
||||||
|
expect(importDataTypeForDatabase("decimal", "sqlite")).toBe("REAL");
|
||||||
|
expect(importDataTypeForDatabase("decimal", "oracle")).toBe("BINARY_DOUBLE");
|
||||||
|
});
|
||||||
});
|
});
|
||||||
@@ -243,6 +243,7 @@ export function importDataTypeForDatabase(inferredType: ImportInferredType, data
|
|||||||
return "BIGINT";
|
return "BIGINT";
|
||||||
case "decimal":
|
case "decimal":
|
||||||
if (["postgres", "gaussdb", "opengauss", "redshift", "kingbase", "highgo", "uxdb", "kwdb", "vastbase"].includes(databaseType || "")) return "DOUBLE PRECISION";
|
if (["postgres", "gaussdb", "opengauss", "redshift", "kingbase", "highgo", "uxdb", "kwdb", "vastbase"].includes(databaseType || "")) return "DOUBLE PRECISION";
|
||||||
|
if (databaseType === "sqlserver") return "FLOAT";
|
||||||
if (databaseType === "sqlite" || databaseType === "rqlite" || databaseType === "turso" || databaseType === "cloudflare-d1") return "REAL";
|
if (databaseType === "sqlite" || databaseType === "rqlite" || databaseType === "turso" || databaseType === "cloudflare-d1") return "REAL";
|
||||||
if (databaseType === "oracle" || databaseType === "oceanbase-oracle" || databaseType === "dameng") return "BINARY_DOUBLE";
|
if (databaseType === "oracle" || databaseType === "oceanbase-oracle" || databaseType === "dameng") return "BINARY_DOUBLE";
|
||||||
if (databaseType === "clickhouse") return "Float64";
|
if (databaseType === "clickhouse") return "Float64";
|
||||||
|
|||||||
@@ -3575,6 +3575,7 @@ fn decimal_data_type(db_type: &DatabaseType) -> &'static str {
|
|||||||
| DatabaseType::Uxdb
|
| DatabaseType::Uxdb
|
||||||
| DatabaseType::Kwdb
|
| DatabaseType::Kwdb
|
||||||
| DatabaseType::Vastbase => "DOUBLE PRECISION",
|
| DatabaseType::Vastbase => "DOUBLE PRECISION",
|
||||||
|
DatabaseType::SqlServer => "FLOAT",
|
||||||
DatabaseType::Sqlite | DatabaseType::Rqlite | DatabaseType::Turso | DatabaseType::CloudflareD1 => "REAL",
|
DatabaseType::Sqlite | DatabaseType::Rqlite | DatabaseType::Turso | DatabaseType::CloudflareD1 => "REAL",
|
||||||
DatabaseType::Oracle | DatabaseType::OceanbaseOracle | DatabaseType::Dameng => "BINARY_DOUBLE",
|
DatabaseType::Oracle | DatabaseType::OceanbaseOracle | DatabaseType::Dameng => "BINARY_DOUBLE",
|
||||||
DatabaseType::ClickHouse => "Float64",
|
DatabaseType::ClickHouse => "Float64",
|
||||||
@@ -8834,6 +8835,49 @@ mod tests {
|
|||||||
assert_eq!(plan.sql, "CREATE TABLE [dbo].[events] (\n [notes] NVARCHAR(MAX)\n)");
|
assert_eq!(plan.sql, "CREATE TABLE [dbo].[events] (\n [notes] NVARCHAR(MAX)\n)");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn create_table_plan_uses_sqlserver_float_for_inferred_decimals() {
|
||||||
|
let data = ParsedImportFile {
|
||||||
|
columns: vec![
|
||||||
|
"id".to_string(),
|
||||||
|
"active".to_string(),
|
||||||
|
"amount".to_string(),
|
||||||
|
"created_at".to_string(),
|
||||||
|
"notes".to_string(),
|
||||||
|
],
|
||||||
|
rows: vec![vec![
|
||||||
|
serde_json::json!(1001),
|
||||||
|
serde_json::json!(true),
|
||||||
|
serde_json::json!("12.5"),
|
||||||
|
serde_json::json!("2026-07-07 08:15:00"),
|
||||||
|
serde_json::json!("invoice"),
|
||||||
|
]],
|
||||||
|
total_rows: 1,
|
||||||
|
effective_encoding: None,
|
||||||
|
};
|
||||||
|
let mappings = data
|
||||||
|
.columns
|
||||||
|
.iter()
|
||||||
|
.map(|column| TableImportColumnMapping {
|
||||||
|
source_column: column.clone(),
|
||||||
|
target_column: column.clone(),
|
||||||
|
target_data_type: None,
|
||||||
|
})
|
||||||
|
.collect::<Vec<_>>();
|
||||||
|
|
||||||
|
let plan =
|
||||||
|
build_import_create_table_plan(&data, &mappings, "invoices", "dbo", &DatabaseType::SqlServer).unwrap();
|
||||||
|
|
||||||
|
assert_eq!(
|
||||||
|
plan.sql,
|
||||||
|
"CREATE TABLE [dbo].[invoices] (\n [id] BIGINT,\n [active] BIT,\n [amount] FLOAT,\n [created_at] DATETIME2,\n [notes] NVARCHAR(MAX)\n)"
|
||||||
|
);
|
||||||
|
assert_eq!(decimal_data_type(&DatabaseType::Mysql), "DOUBLE");
|
||||||
|
assert_eq!(decimal_data_type(&DatabaseType::Postgres), "DOUBLE PRECISION");
|
||||||
|
assert_eq!(decimal_data_type(&DatabaseType::Sqlite), "REAL");
|
||||||
|
assert_eq!(decimal_data_type(&DatabaseType::Oracle), "BINARY_DOUBLE");
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn create_table_plan_uses_user_defined_column_type() {
|
fn create_table_plan_uses_user_defined_column_type() {
|
||||||
let data = ParsedImportFile {
|
let data = ParsedImportFile {
|
||||||
|
|||||||
Reference in new issue
Block a user