From 31217d63a197f1acf6eb35e52739178cb9a5d211 Mon Sep 17 00:00:00 2001 From: t8y2 <1156263951@qq.com> Date: Wed, 24 Jun 2026 11:30:26 +0800 Subject: [PATCH] fix(mysql): restore non-session pool size --- crates/dbx-core/src/connection.rs | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/crates/dbx-core/src/connection.rs b/crates/dbx-core/src/connection.rs index 2cec306489..1e2f227a45 100644 --- a/crates/dbx-core/src/connection.rs +++ b/crates/dbx-core/src/connection.rs @@ -637,7 +637,7 @@ impl AppState { let url = connection_url_for_endpoint(&db_config, &host, port); let connect_timeout = std::time::Duration::from_secs(db_config.effective_connect_timeout_secs()); let idle_timeout = std::time::Duration::from_secs(db_config.idle_timeout_secs); - let mysql_pool_max_connections = if normalize_client_session_id(client_session_id).is_some() { 1 } else { 3 }; + let mysql_pool_max_connections = mysql_pool_max_connections_for_session(client_session_id); let pool = match db_config.db_type { DatabaseType::Mysql => { let (pool, mode) = connect_mysql_metadata_pool( @@ -1934,6 +1934,14 @@ fn normalize_client_session_id(client_session_id: Option<&str>) -> Option) -> usize { + if normalize_client_session_id(client_session_id).is_some() { + 1 + } else { + 10 + } +} + fn redis_cluster_transport_prefix(connection_id: &str) -> String { format!("{connection_id}:redis-cluster:") } @@ -3116,6 +3124,13 @@ mod tests { ); } + #[test] + fn mysql_pool_size_keeps_session_pools_single_connection() { + assert_eq!(super::mysql_pool_max_connections_for_session(None), 10); + assert_eq!(super::mysql_pool_max_connections_for_session(Some("")), 10); + assert_eq!(super::mysql_pool_max_connections_for_session(Some("tab-1")), 1); + } + #[test] fn prestosql_uses_external_driver_pool_not_agent_pool() { assert!(!super::uses_agent_connection_pool(&DatabaseType::PrestoSql));