feat(editor): configure Ctrl+Click table navigation
This commit is contained in:
1 parent
24d7dc48ad
commit
3285cb21a4
12 files changed
+68
No files matched your search
@@ -282,6 +282,27 @@ describe("normalizeEditorSettings - continueOnErrorOnBatch", () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe("normalizeEditorSettings - clickTableNavigationTarget", () => {
|
||||
it("defaults clickTableNavigationTarget to 'data'", () => {
|
||||
expect(normalizeEditorSettings({}).clickTableNavigationTarget).toBe("data");
|
||||
});
|
||||
|
||||
it("preserves explicit 'ddl' value", () => {
|
||||
expect(normalizeEditorSettings({ clickTableNavigationTarget: "ddl" }).clickTableNavigationTarget).toBe("ddl");
|
||||
});
|
||||
|
||||
it("preserves explicit 'data' value", () => {
|
||||
expect(normalizeEditorSettings({ clickTableNavigationTarget: "data" }).clickTableNavigationTarget).toBe("data");
|
||||
});
|
||||
|
||||
it("falls back to 'data' for invalid values", () => {
|
||||
expect(normalizeEditorSettings({ clickTableNavigationTarget: "invalid" } as any).clickTableNavigationTarget).toBe("data");
|
||||
expect(normalizeEditorSettings({ clickTableNavigationTarget: undefined } as any).clickTableNavigationTarget).toBe("data");
|
||||
expect(normalizeEditorSettings({ clickTableNavigationTarget: null } as any).clickTableNavigationTarget).toBe("data");
|
||||
expect(normalizeEditorSettings({ clickTableNavigationTarget: 123 } as any).clickTableNavigationTarget).toBe("data");
|
||||
});
|
||||
});
|
||||
|
||||
describe("normalizeEditorSettings - tabLayout", () => {
|
||||
it("defaults tabLayout to scroll", () => {
|
||||
expect(normalizeEditorSettings({}).tabLayout).toBe("scroll");
|
||||
|
||||
@@ -346,6 +346,9 @@ export const TABLE_FONT_SIZE_DEFAULT = 13;
|
||||
const DISCONNECT_TAB_HANDLING_MODES = ["close-tabs", "keep-tabs-clear-results", "keep-tabs-keep-results"] as const;
|
||||
export type DisconnectTabHandlingMode = (typeof DISCONNECT_TAB_HANDLING_MODES)[number];
|
||||
|
||||
const CLICK_TABLE_NAVIGATION_TARGETS = ["data", "ddl"] as const;
|
||||
export type ClickTableNavigationTarget = (typeof CLICK_TABLE_NAVIGATION_TARGETS)[number];
|
||||
|
||||
export interface CustomThemeColors {
|
||||
keyword: string;
|
||||
field: string;
|
||||
@@ -505,6 +508,7 @@ export interface EditorSettings {
|
||||
objectBrowserViewMode: "list" | "grid";
|
||||
sqlVariableSyntaxOverrides: SqlVariableSyntaxOverrides;
|
||||
continueOnErrorOnBatch: boolean;
|
||||
clickTableNavigationTarget: ClickTableNavigationTarget;
|
||||
}
|
||||
|
||||
export interface ToolbarItems {
|
||||
@@ -680,6 +684,7 @@ export const DEFAULT_EDITOR_SETTINGS: EditorSettings = {
|
||||
objectBrowserViewMode: "list",
|
||||
sqlVariableSyntaxOverrides: {},
|
||||
continueOnErrorOnBatch: false,
|
||||
clickTableNavigationTarget: "data",
|
||||
};
|
||||
|
||||
export const STORAGE_KEY = "dbx-editor-settings";
|
||||
@@ -767,6 +772,10 @@ function normalizeDisconnectTabHandlingMode(value: unknown, legacyCloseTabsOnDis
|
||||
return DEFAULT_EDITOR_SETTINGS.disconnectTabHandlingMode;
|
||||
}
|
||||
|
||||
function normalizeClickTableNavigationTarget(value: unknown): ClickTableNavigationTarget {
|
||||
return value === "data" || value === "ddl" ? value : DEFAULT_EDITOR_SETTINGS.clickTableNavigationTarget;
|
||||
}
|
||||
|
||||
function normalizeOpenTabsRestoreMode(value: unknown, legacyRestoreOpenTabsOnLaunch?: unknown): OpenTabsRestoreMode {
|
||||
if (value === "all" || value === "pinned" || value === "none") return value;
|
||||
if (typeof legacyRestoreOpenTabsOnLaunch === "boolean") return legacyRestoreOpenTabsOnLaunch ? "all" : "none";
|
||||
@@ -1013,6 +1022,7 @@ export function normalizeEditorSettings(settings: Partial<EditorSettings>, exist
|
||||
objectBrowserViewMode: settings.objectBrowserViewMode === "grid" ? "grid" : DEFAULT_EDITOR_SETTINGS.objectBrowserViewMode,
|
||||
sqlVariableSyntaxOverrides: normalizeSqlVariableSyntaxOverrides(settings.sqlVariableSyntaxOverrides),
|
||||
continueOnErrorOnBatch: settings.continueOnErrorOnBatch === true,
|
||||
clickTableNavigationTarget: normalizeClickTableNavigationTarget(settings.clickTableNavigationTarget),
|
||||
};
|
||||
}
|
||||
|
||||
@@ -1463,6 +1473,7 @@ export const useSettingsStore = defineStore("settings", () => {
|
||||
if (partial.objectBrowserViewMode !== undefined) editorSettings.value.objectBrowserViewMode = partial.objectBrowserViewMode === "grid" ? "grid" : "list";
|
||||
if (partial.sqlVariableSyntaxOverrides !== undefined) editorSettings.value.sqlVariableSyntaxOverrides = normalizeSqlVariableSyntaxOverrides(partial.sqlVariableSyntaxOverrides);
|
||||
if (partial.continueOnErrorOnBatch !== undefined) editorSettings.value.continueOnErrorOnBatch = partial.continueOnErrorOnBatch === true;
|
||||
if (partial.clickTableNavigationTarget !== undefined) editorSettings.value.clickTableNavigationTarget = normalizeClickTableNavigationTarget(partial.clickTableNavigationTarget);
|
||||
saveEditorSettings(editorSettings.value);
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user