From 36c715f3b99c56c28289f724845219f4f6c2c516 Mon Sep 17 00:00:00 2001 From: ammann <161159040+agammann@users.noreply.github.com> Date: Wed, 30 Sep 2026 05:03:49 -0700 Subject: [PATCH] fix(oceanbase): show rename for oracle mode tables --- .../src/lib/__tests__/table/objectRenameSql.spec.ts | 7 +++++++ apps/desktop/src/lib/table/objectRenameSql.ts | 1 + 2 files changed, 8 insertions(+) diff --git a/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts b/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts index b27b1a04dc..7baa7fb372 100644 --- a/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts +++ b/apps/desktop/src/lib/__tests__/table/objectRenameSql.spec.ts @@ -22,6 +22,13 @@ describe("StarRocks object rename", () => { }); }); +describe("OceanBase Oracle object rename", () => { + it("offers table rename without enabling other object renames", () => { + expect(supportsObjectRename("oceanbase-oracle", "TABLE")).toBe(true); + expect(supportsObjectRename("oceanbase-oracle", "VIEW")).toBe(false); + }); +}); + describe("database rename", () => { it("chooses a maintenance database outside the rename target", () => { expect(databaseRenameMaintenanceDatabase("admin", "application")).toBe("admin"); diff --git a/apps/desktop/src/lib/table/objectRenameSql.ts b/apps/desktop/src/lib/table/objectRenameSql.ts index 86e575d11e..fb1cc63dad 100644 --- a/apps/desktop/src/lib/table/objectRenameSql.ts +++ b/apps/desktop/src/lib/table/objectRenameSql.ts @@ -24,6 +24,7 @@ export function supportsObjectRename(databaseType: DatabaseType | undefined, obj } if (databaseType === "sqlite" || databaseType === "rqlite" || databaseType === "turso" || databaseType === "cloudflare-d1" || databaseType === "duckdb") return objectType === "TABLE"; if (databaseType === "transwarp" || databaseType === "starrocks") return objectType === "TABLE"; + if (databaseType === "oceanbase-oracle") return objectType === "TABLE"; if (databaseType === "mysql" || databaseType === "goldendb") return objectType === "TABLE" || objectType === "VIEW"; if (postgresLikeRenameTypes.has(databaseType)) return objectType === "TABLE" || objectType === "VIEW" || objectType === "MATERIALIZED_VIEW"; if (oracleLikeRenameTypes.has(databaseType)) return objectType === "TABLE" || objectType === "VIEW" || objectType === "MATERIALIZED_VIEW";