fix(editor): skip INSERT hints duplicating projection aliases

This commit is contained in:
zipg authored and GitHub committed 2026-09-20 00:51:06 +08:00
1 parent 86115971fa
commit 3cb1faf1c6
6 files changed
+113 -16

No files matched your search

@@ -1,6 +1,7 @@
import { strict as assert } from "node:assert";
import { test } from "vitest";
import { buildInsertValueHintDecorations, insertValueHintsRefreshDispatchSpec, isInsertValueHintDecorationAt } from "@/lib/editor/codemirrorInsertValueHints";
import { parseInsertValueHints } from "@/lib/sql/insertValueHints";
test("insertValueHintsRefreshDispatchSpec disables scrollIntoView", () => {
assert.equal(insertValueHintsRefreshDispatchSpec.scrollIntoView, false);
@@ -18,3 +19,10 @@ test("isInsertValueHintDecorationAt detects widget anchors", () => {
assert.equal(isInsertValueHintDecorationAt(decorations, valueTwo), true);
assert.equal(isInsertValueHintDecorationAt(decorations, sql.indexOf("INSERT")), false);
});
test("a projection that already aliases its target column renders no hint widget", () => {
const sql = ["INSERT INTO t (operation_apply_id, pacu_status)", "SELECT", " noprid.ruid as operation_apply_id,", " noprid.flag", "FROM noprid"].join("\n");
const decorations = buildInsertValueHintDecorations(parseInsertValueHints(sql));
assert.equal(isInsertValueHintDecorationAt(decorations, sql.indexOf("noprid.ruid")), false);
assert.equal(isInsertValueHintDecorationAt(decorations, sql.indexOf("noprid.flag")), true);
});