fix(compare): cap per-table compare reads and flag truncation

This commit is contained in:
zipg authored and GitHub committed 2026-09-30 14:59:56 +08:00
1 parent 535417a763
commit 3dbaed310d
21 files changed
+471 -81

No files matched your search

@@ -190,6 +190,10 @@ const totalAdded = computed(() => batchResults.value.reduce((sum, item) => sum +
const totalRemoved = computed(() => batchResults.value.reduce((sum, item) => sum + item.removed, 0));
const totalModified = computed(() => batchResults.value.reduce((sum, item) => sum + item.modified, 0));
const hasResults = computed(() => batchResults.value.length > 0);
// A compare reads both sides up to a fixed row budget, so a table larger than that budget
// is reported through `*Truncated`. Surfacing it here keeps a partial diff from looking
// like a complete one.
const truncatedResults = computed(() => batchResults.value.filter((item) => item.sourceTruncated || item.targetTruncated));
const visibleKinds = computed(() => [...(showAdded.value ? (["added"] as DiffKind[]) : []), ...(showRemoved.value ? (["removed"] as DiffKind[]) : []), ...(showModified.value ? (["modified"] as DiffKind[]) : [])]);
const selectedAddedCount = computed(() => selectedDiffCount("added"));
const selectedRemovedCount = computed(() => selectedDiffCount("removed"));
@@ -1276,6 +1280,23 @@ onBeforeUnmount(() => {
<div class="text-xs text-muted-foreground">{{ selectedSummary }}</div>
</div>
<div v-if="truncatedResults.length" class="rounded-lg border border-amber-500/40 bg-amber-500/10 p-3 text-xs text-amber-700 space-y-1 dark:text-amber-400">
<div class="text-sm font-medium">{{ t("dataCompare.truncatedTitle") }}</div>
<div>{{ t("dataCompare.truncatedHint") }}</div>
<ul class="list-disc space-y-0.5 pl-4">
<li v-for="item in truncatedResults" :key="`truncated-${item.sourceTable}:${item.targetTable}`">
{{
t("dataCompare.truncatedTable", {
table: item.sourceTable,
source: item.sourceRowCount,
target: item.targetRowCount,
budget: item.rowBudget,
})
}}
</li>
</ul>
</div>
<div class="rounded-lg border p-3 space-y-3">
<div class="flex flex-wrap items-center gap-2">
<Button size="sm" variant="outline" class="h-7 text-xs" :class="showAdded ? 'border-primary' : ''" @click="showAdded = !showAdded"> {{ t("diff.added") }} · {{ totalAdded }} </Button>
@@ -1350,6 +1371,9 @@ onBeforeUnmount(() => {
})
}}
</div>
<div v-if="item.sourceTruncated || item.targetTruncated" class="mt-1 text-amber-700 dark:text-amber-400">
{{ t("dataCompare.truncatedBadge", { budget: item.rowBudget }) }}
</div>
<div class="mt-1">
{{ t("dataCompare.keyColumnsInline", { columns: item.keyColumns.join(", ") }) }}
</div>
@@ -205,6 +205,7 @@ function preparationFor(table: string) {
targetRowCount: 0,
sourceTruncated: false,
targetTruncated: false,
rowBudget: 100_000,
};
}
@@ -129,6 +129,7 @@ function completedSession(): DataCompareSession {
targetRowCount: 0,
sourceTruncated: false,
targetTruncated: false,
rowBudget: 100_000,
databaseType: "oracle",
diff: {
added: [
@@ -509,3 +510,28 @@ describe("DataCompareDialog results layout", () => {
expect(scroller?.contains(dialogFooter)).toBe(false);
});
});
describe("DataCompareDialog truncation warning", () => {
it("warns that a table larger than the row budget was only partially compared", async () => {
const session = completedSession();
const result = session.batchResults[0]!;
result.sourceTruncated = true;
result.sourceRowCount = 4_000_000;
result.rowBudget = 100_000;
mountSessionDialog(session);
await flushAsyncSetup();
const text = document.body.textContent ?? "";
expect(text).toContain(i18n.global.t("dataCompare.truncatedTitle"));
expect(text).toContain(i18n.global.t("dataCompare.truncatedBadge", { budget: 100_000 }));
expect(text).toContain(i18n.global.t("dataCompare.truncatedTable", { table: "ORDERS", source: 4_000_000, target: 0, budget: 100_000 }));
});
it("keeps the warning out of the results when every table fit the budget", async () => {
mountSessionDialog(completedSession());
await flushAsyncSetup();
expect(document.body.textContent ?? "").not.toContain(i18n.global.t("dataCompare.truncatedTitle"));
});
});