fix(grid): show load time with one decimal in all states
This commit is contained in:
3 files changed
+20
-11
No files matched your search
@@ -2,14 +2,15 @@ import { describe, expect, it } from "vitest";
|
||||
import { formatElapsedSeconds } from "@/lib/common/elapsedTime";
|
||||
|
||||
describe("formatElapsedSeconds", () => {
|
||||
it("formats elapsed milliseconds with two fractional second digits", () => {
|
||||
expect(formatElapsedSeconds(1234)).toBe("1.23");
|
||||
expect(formatElapsedSeconds(5)).toBe("0.01");
|
||||
expect(formatElapsedSeconds(0)).toBe("0.00");
|
||||
it("formats elapsed milliseconds with one fractional second digit", () => {
|
||||
expect(formatElapsedSeconds(1234)).toBe("1.2");
|
||||
expect(formatElapsedSeconds(1250)).toBe("1.3");
|
||||
expect(formatElapsedSeconds(5)).toBe("0.0");
|
||||
expect(formatElapsedSeconds(0)).toBe("0.0");
|
||||
});
|
||||
|
||||
it("clamps invalid elapsed values to zero", () => {
|
||||
expect(formatElapsedSeconds(-100)).toBe("0.00");
|
||||
expect(formatElapsedSeconds(Number.NaN)).toBe("0.00");
|
||||
expect(formatElapsedSeconds(-100)).toBe("0.0");
|
||||
expect(formatElapsedSeconds(Number.NaN)).toBe("0.0");
|
||||
});
|
||||
});
|
||||
@@ -1,3 +1,11 @@
|
||||
/**
|
||||
* Elapsed seconds for the running-load hints (the full-area loader, the in-grid
|
||||
* busy pill, ...).
|
||||
*
|
||||
* One decimal on purpose: the grid footer renders a finished run through
|
||||
* `formatQueryDuration` ("2.2 s"), so a two-decimal counter here made the same
|
||||
* value jump between formats while loading and after it finished (#10439/#10441).
|
||||
*/
|
||||
export function formatElapsedSeconds(ms: number): string {
|
||||
return (Math.max(0, Number.isFinite(ms) ? ms : 0) / 1000).toFixed(2);
|
||||
return (Math.max(0, Number.isFinite(ms) ? ms : 0) / 1000).toFixed(1);
|
||||
}
|
||||
Reference in new issue
Block a user