fix(transfer): confirm background task submission

Closes #8649
This commit is contained in:
t8y2 committed 2026-09-27 14:19:10 +00:00
1 parent 5d13c5ecfc
commit 4329ec51db
20 files changed
+181 -12

No files matched your search

@@ -0,0 +1,84 @@
import { afterEach, describe, expect, it, vi } from "vitest";
import type { TransferProgress, TransferRequest } from "@/lib/backend/http";
import { startTransfer } from "@/lib/backend/http";
function request(): TransferRequest {
return {
transferId: "transfer-1",
sourceConnectionId: "source",
sourceDatabase: "app",
sourceSchema: "public",
targetConnectionId: "target",
targetDatabase: "warehouse",
targetSchema: "reporting",
tables: ["orders", "users"],
createTable: true,
content: "structureAndData",
objects: [],
mode: "append",
targetTableNameCase: "preserve",
quoteTargetColumnNames: true,
ownershipPolicy: "preserve",
batchSize: 1000,
dropTargetBeforeCreate: false,
dropTargetConfirmed: false,
};
}
function doneProgress(): TransferProgress {
return {
transferId: "transfer-1",
table: "users",
tableIndex: 2,
totalTables: 2,
rowsTransferred: 3,
totalRows: 3,
status: "done",
error: null,
terminal: true,
};
}
describe("web data-transfer submission", () => {
afterEach(() => vi.unstubAllGlobals());
it("acknowledges an accepted task once before tracking its progress", async () => {
vi.stubGlobal("fetch", vi.fn().mockResolvedValue({ ok: true }));
let source: FakeEventSource | undefined;
class FakeEventSource {
onmessage: ((event: { data: string }) => void) | null = null;
onerror: (() => void) | null = null;
close = vi.fn();
constructor(readonly url: string) {
source = this;
}
}
vi.stubGlobal("EventSource", FakeEventSource);
const onStarted = vi.fn();
const onProgress = vi.fn();
const pending = startTransfer(request(), onProgress, onStarted);
await vi.waitFor(() => expect(onStarted).toHaveBeenCalledTimes(1));
expect(source?.url).toBe("/api/transfer/progress/transfer-1");
source?.onmessage?.({ data: JSON.stringify(doneProgress()) });
await expect(pending).resolves.toBeUndefined();
expect(onStarted).toHaveBeenCalledTimes(1);
expect(onProgress).toHaveBeenCalledWith(doneProgress());
});
it("suppresses acknowledgement when task creation fails", async () => {
vi.stubGlobal(
"fetch",
vi.fn().mockResolvedValue({
ok: false,
text: vi.fn().mockResolvedValue('{"message":"rejected"}'),
}),
);
const onStarted = vi.fn();
await expect(startTransfer(request(), vi.fn(), onStarted)).rejects.toThrow();
expect(onStarted).not.toHaveBeenCalled();
});
});
+2 -1
View File
@@ -2805,7 +2805,7 @@ export async function saveGlobalSearchSettings(settings: GlobalSearchSettings):
// Data Transfer
// ---------------------------------------------------------------------------
export async function startTransfer(request: TransferRequest, onProgress: (progress: TransferProgress) => void): Promise<void> {
export async function startTransfer(request: TransferRequest, onProgress: (progress: TransferProgress) => void, onStarted?: () => void): Promise<void> {
// 1. POST to start the transfer
const res = await fetch(apiUrl("/api/transfer/start"), {
method: "POST",
@@ -2813,6 +2813,7 @@ export async function startTransfer(request: TransferRequest, onProgress: (progr
body: JSON.stringify({ request }),
});
if (!res.ok) throw await backendResponseError(res);
onStarted?.();
// 2. SSE to listen for progress
return new Promise((resolve, reject) => {
+2 -1
View File
@@ -5324,7 +5324,7 @@ export interface TransferProgress {
transferFailuresOmitted?: number;
}
export async function startTransfer(request: TransferRequest, onProgress: (progress: TransferProgress) => void): Promise<void> {
export async function startTransfer(request: TransferRequest, onProgress: (progress: TransferProgress) => void, onStarted?: () => void): Promise<void> {
return new Promise((resolve, reject) => {
let unlisten: UnlistenFn | null = null;
void (async () => {
@@ -5339,6 +5339,7 @@ export async function startTransfer(request: TransferRequest, onProgress: (progr
});
await invoke("start_transfer", { request });
onStarted?.();
} catch (e) {
unlisten?.();
reject(e instanceof BackendErrorException ? e : new BackendErrorException(e));