From 486d9bb3a65125ed837f35cd137ec1d84eb21b79 Mon Sep 17 00:00:00 2001 From: t8y2 <1156263951@qq.com> Date: Thu, 28 May 2026 18:18:45 +0800 Subject: [PATCH] fix(connection): move query timeout into per-connection settings --- .../connection/ConnectionDialog.vue | 50 +++++++++++++------ .../editor/EditorSettingsDialog.vue | 25 ---------- apps/desktop/src/i18n/locales/en.ts | 4 +- apps/desktop/src/i18n/locales/es.ts | 2 + apps/desktop/src/i18n/locales/zh-CN.ts | 4 +- apps/desktop/src/lib/dbeaverImport.ts | 1 + apps/desktop/src/lib/navicatImport.ts | 1 + apps/desktop/src/stores/connectionStore.ts | 1 + apps/desktop/src/stores/queryStore.ts | 17 ++++++- apps/desktop/src/stores/settingsStore.ts | 11 ---- apps/desktop/src/types/database.ts | 1 + crates/dbx-core/src/cloud_sync.rs | 1 + crates/dbx-core/src/connection.rs | 1 + crates/dbx-core/src/connection_secrets.rs | 1 + crates/dbx-core/src/models/connection.rs | 27 +++++++++- crates/dbx-core/src/query.rs | 1 + crates/dbx-core/src/transfer.rs | 1 + crates/dbx-web/src/routes/connection.rs | 1 + packages/app-tests/paginationPageSize.test.ts | 6 ++- src-tauri/src/commands/connection.rs | 1 + 20 files changed, 97 insertions(+), 60 deletions(-) diff --git a/apps/desktop/src/components/connection/ConnectionDialog.vue b/apps/desktop/src/components/connection/ConnectionDialog.vue index 4a35fa93ce..d564cf55e8 100644 --- a/apps/desktop/src/components/connection/ConnectionDialog.vue +++ b/apps/desktop/src/components/connection/ConnectionDialog.vue @@ -40,7 +40,7 @@ type DbOption = { value: string; label: string }; type DbCategory = { key: string; title: string; options: DbOption[] }; type DialogStep = "select" | "config"; type DbPickerView = "icon" | "list"; -type ConfigTab = "connection" | "tls" | "ssh" | "proxy"; +type ConfigTab = "connection" | "advanced" | "tls" | "ssh" | "proxy"; const { t } = useI18n(); const { toast } = useToast(); @@ -88,6 +88,7 @@ const defaultForm = (): Omit => ({ ssh_expose_lan: false, ssh_connect_timeout_secs: 5, connect_timeout_secs: 5, + query_timeout_secs: 30, proxy_enabled: false, proxy_type: "socks5", proxy_host: "", @@ -347,6 +348,7 @@ watch( ssh_expose_lan: config.ssh_expose_lan || false, ssh_connect_timeout_secs: config.ssh_connect_timeout_secs || 5, connect_timeout_secs: config.connect_timeout_secs || 5, + query_timeout_secs: config.query_timeout_secs ?? 30, proxy_enabled: config.proxy_enabled || false, proxy_type: config.proxy_type || "socks5", proxy_host: config.proxy_host || "", @@ -741,6 +743,8 @@ function connectionConfigForSubmit(id: string): ConnectionConfig { config.ssh_connect_timeout_secs = Number.isFinite(sshTimeout) && sshTimeout > 0 ? sshTimeout : 5; const connectTimeout = Number(config.connect_timeout_secs); config.connect_timeout_secs = Number.isFinite(connectTimeout) && connectTimeout > 0 ? connectTimeout : 5; + const queryTimeout = Number(config.query_timeout_secs); + config.query_timeout_secs = Number.isFinite(queryTimeout) && queryTimeout >= 0 ? queryTimeout : 30; const proxyPort = Number(config.proxy_port); config.proxy_port = Number.isFinite(proxyPort) && proxyPort > 0 ? proxyPort : 1080; if (!config.one_time) config.one_time = undefined; @@ -1440,15 +1444,13 @@ function openExternalUrl(url: string) {