From 4ed3662da22a432e4f3e6453e2de8996ac26397f Mon Sep 17 00:00:00 2001 From: zipg Date: Fri, 2 Oct 2026 00:43:08 +0800 Subject: [PATCH] fix(completion): rank CREATE OR REPLACE keyword over REPLACE function --- .../sql/sqlCompletion.context.spec.ts | 28 ++++++++++++++++++ apps/desktop/src/lib/sql/sqlCompletion.ts | 3 ++ docs/screenshots/issue-10596-accepted.jpg | Bin 0 -> 7016 bytes docs/screenshots/issue-10596-after.jpg | Bin 0 -> 12867 bytes docs/screenshots/issue-10596-before.jpg | Bin 0 -> 12322 bytes 5 files changed, 31 insertions(+) create mode 100644 docs/screenshots/issue-10596-accepted.jpg create mode 100644 docs/screenshots/issue-10596-after.jpg create mode 100644 docs/screenshots/issue-10596-before.jpg diff --git a/apps/desktop/src/lib/__tests__/sql/sqlCompletion.context.spec.ts b/apps/desktop/src/lib/__tests__/sql/sqlCompletion.context.spec.ts index 238f641f9b..0990abf0f2 100644 --- a/apps/desktop/src/lib/__tests__/sql/sqlCompletion.context.spec.ts +++ b/apps/desktop/src/lib/__tests__/sql/sqlCompletion.context.spec.ts @@ -51,6 +51,34 @@ describe("SQL completion replacement", () => { }); describe("sqlCompletion keyword snippets", () => { + it.each(["mysql", "postgres", "oracle"] as const)("offers the REPLACE keyword in %s CREATE OR statements", (databaseType) => { + for (const text of ["CREATE OR ", "CREATE OR r", "CREATE OR repla", "-- heading\nCREATE /* comment */ OR repla"]) { + const items = buildSqlCompletionItems(text, text.length, { tables: [], columnsByTable: new Map(), databaseType }); + expect(items[0], text).toMatchObject({ label: "REPLACE", type: "keyword" }); + expect(items[0].apply ?? items[0].label).toBe("REPLACE"); + } + }); + + it("preserves REPLACE function completion in SELECT expressions", () => { + const text = "SELECT repla"; + const items = buildSqlCompletionItems(text, text.length, { tables: [], columnsByTable: new Map(), databaseType: "mysql" }); + expect(items[0]).toMatchObject({ label: "REPLACE", type: "function" }); + expect(items[0]?.apply).toMatch(/^REPLACE\(/); + }); + + it.each(["sqlserver", "sqlite"] as const)("does not suggest unsupported CREATE OR REPLACE syntax on %s", (databaseType) => { + const text = "CREATE OR repla"; + const items = buildSqlCompletionItems(text, text.length, { tables: [], columnsByTable: new Map(), databaseType }); + expect(items.some((item) => item.type === "keyword" && item.label === "REPLACE")).toBe(false); + }); + + it("honors lower-case keyword preferences for CREATE OR REPLACE", () => { + const text = "create or repla"; + const items = buildSqlCompletionItems(text, text.length, { tables: [], columnsByTable: new Map(), databaseType: "postgres", keywordCase: "lower" }); + expect(items[0]).toMatchObject({ label: "replace", type: "keyword" }); + expect(items[0].apply ?? items[0].label).toBe("replace"); + }); + it("auto-opens and suggests SELECT when typing sel", () => { const sql = "sel"; const items = buildSqlCompletionItems(sql, sql.length, { diff --git a/apps/desktop/src/lib/sql/sqlCompletion.ts b/apps/desktop/src/lib/sql/sqlCompletion.ts index f60e2165f7..cd3a1e2496 100644 --- a/apps/desktop/src/lib/sql/sqlCompletion.ts +++ b/apps/desktop/src/lib/sql/sqlCompletion.ts @@ -3213,6 +3213,9 @@ function preferredKeywordsForCompletion( databaseType: DatabaseType | undefined, ): string[] { const keywords: string[] = []; + if (databaseType !== "sqlserver" && databaseType !== "sqlite" && /^create\s+or$/i.test(maskSqlLiteralsAndComments(beforeToken, databaseType).trim())) { + keywords.push("REPLACE"); + } if (selectListColumnContext && hasSelectListExpression(beforeCursor, databaseType)) keywords.push("FROM"); if (isAfterJoinModifierContext(beforeCursor, databaseType)) keywords.push("JOIN"); if (!exclusiveTableSuggestions && isAfterSelectBodyExpression(beforeToken, databaseType)) keywords.push("LIMIT"); diff --git a/docs/screenshots/issue-10596-accepted.jpg b/docs/screenshots/issue-10596-accepted.jpg new file mode 100644 index 0000000000000000000000000000000000000000..81f6451057594ac95b24e59f17a3e3667cf7ff0b GIT binary patch literal 7016 zcmeHKc~DdLzCXy;QWRqlWf5*+WD`_&5h1UYWvWRiLf9iM*gyh-0um4fY`s?{T*!D) zA%sX9t_PB6Xn+v*TxAnke3-BpARq|JCZHsQgd{K8_Pv=-|9La7ojY&*otd1O&*!_H zPd?w7b5vuhX<+v$|1bOj4GjR$P+x#*95@N+Xld(cYw74{>*(t0e5AKqPw(T8^$d3z z=fHiGEQ^OM20nyNeXs9{?Q}w7nAK=%csUA~H<0CbBVz>Gk zGYFb`4sB(nXaX4`b{?9(E01sANRU^e&#zXcaQVm z*Vd`C_y4BuFWG9w0ipqDs!M5UX>0$|RRgkThvuhRpMAaN6!arI^}8DnhMpzkv!|d|csqkE?1XW`n3Iok zOf!`qOGq{I=%xqX-CMkHEYq6N02W9Rz`3SPNs+zvMxOMHL1>lNo>ti!_AxsYZ|Emn zpLv0JoIn=Zm*u8HVPXHdZh_!4UdpNj*{{jj%;OCl+91K;fKy12FPc%FofSWhr4g-j z+B5ooVzXYzI*#Zlg01*Z+6{v}X`kd$h|kE3(Qk6i#5Ds8l!b$|C*~Sa1#U z!N~cEa+$|WH>cPy(<-H6GJk4(sTUC^IPPA6X1EnbY3^v@Jwqb>jOJ@Lh@i)X?!AzO z?GyyooW0RT*)R2UcX*DI;l~*LG5N#Jo?cH+nXcm>hiMa6uCX z$Nh=XbORFB!A`kKAs z9yneK&JpGh$ADx}8Az2(&3UCj#rgR%Zf(XTGxTYwrsZ~IZy!i!@8vro2HMZ_L&p(O z7uQzX#|Otxc5jS7b9XB|vTw)6^tqSuXTh{}b{am+!idS8FQbVW_)%Y!3k0rsl`p9% zZ{Y>S;ljNA?qZuFIT;JGTP-6D+9c7IHE=#c1(1{5KrAz7-ZOcpeoDQ;7gGh}vVv1= z6qD;P?6=)QSe#Ldk;5pZa`T0`?AHqmj6j1+RBwaxnb_GNB4$Au#=5N8CUDN{T2FEwAUh~zTx^lWU%xr^G!{-rE z@W(A=qYSfWPnyyuAAxf%#T|-bZap436(NkDnj8VTsryWILz?b={j4qBdPM8%s4gzb zbqHmMa^oYsRya|Ety>P1&Bs#Af>!E% z`{fsXhrPTmnz}KM~c-cbu6WUU&3czCCZAeZk_Zc6DBbe*2t;fO!Ip_Fl;ZkIr?914Ip~0DZx>_>welPW6T>mdK}9n} zt^>S6H(!5#sQlf6`^r}vRDic^x0z0zB)uT?KvuIB|8FTaMv|RNWKUybD6UIneyq+f z?3f*SyyS3{*PDj?+(_!HY}V?L)+ zP%fKHhLs91-zQ|<&0CqKhtKW#p<*ZclnNMs&=GcqCt1Us{xb0Dd-6Gx9wX0kIauxN zl=ilExoi1iC^*s2hoWB_lk-a}5@@+>7^+e1Q{=H|BYoD8N8bsd_Ru#{c|ox5)WsaL z6hYwn?PTxHdjCxGs-bR$uL>~!m5*rL+%sf6kzEmBDu!;y|2L1BojC0q|7&*nFZ?$Y zQmW(sb@8Uv7+Hx2U+vw<5#AL9ec(YII%K@fj4>VkX}pFsAg zt54Ez8D2@ZGM^OEN(*T?(3+qYa+RwV3tjneK2!iz3l^5J_U*8MS^rKp8?~UUq3NH| zUt~pBzLQyv_TPT5drQET_xTUVj-UCMG~XhSbk+Zc8g-8R{*qgU{fhan_o&V}j+PX+ zh!UPKdyne(;yzw`-{{zT)c7AC+J6xLgZ2Im7w_aDIb8(=n8qP{p9naY?jZt?7&wna z3u&=6`8cdJR6@KTI9XaapVL5{&zS@fE?)3U<&!D^8Ns9Gt}M4UvyV(jM~}`lf|D6* zeB@gvNJzJ!XOdh>eL0@;O-TiPpS>(Ilo`S)-sdPRDBZ*ihdD$`Z?o`XutwyQ>hp8~ zs~l4S{<+>n$0*vMceCR-=nfL?gm$EL$eRRTJmiy|8#9S52EjZkY0=xVEN$j!ZSrU` z6N2-W)S;sWf?Ky2NVli9l55@2Mj86cNj1`M^p7#;u~B`Hlw;Kk-&YoR8B=dpg&#d3M3+i*B-#IINC6i7I#Y}s`M61!!fg7xS1OM(OuW!1-RmdC$pzkNSwT=8^&ZyK*fW$) zw50d&;3zn99T5b9gruz2zn*=*9S~S0xD&0kC>iuo0R{uCbm-naZ%E;?f^a5UQ0w?I zF`R2<5ZHuky~L>Q>}VpC&M?HL{onRKQPe8`TGz8yEiFc%)_M&2=6o2sTohWou-ziO zJ5lImJ(qpAEcMN150BG#zO&1zVLZ4VF7JNIfB5K^$=xYNw%}wV(_9>E*oimo=ezh! zMci69x4An!+kH$@GXqQiYmYIdq#(O4Vt84m0?u;ttC#kR#|7Wsixnvu)&J_5rI8tw z`V=S5S@}ggZ!l7J_xK=PQn`2uo}J@Ya;@N4D#9d}tvJ}4z!Jdw`ELI5ez-jCPV!q1 z-;LLJlP=@PWW?i)3$*muq;q+T0}u#&yZ!ZefMi+fb|fJC^cg|&%Xw_`tqYl08l?nV z86|<8#e-r>3W!0qCilWDnjD22@+m9%+$rC z{0r`_hMh!fBBrs$4~4Jqep`RCedB5}N(Iy(LC3}P^3p9#UYkX5(7k1jexV-Bt2RRF zOA%qK;U`CIxXINYDftB@DTjQTlh2JRytkycf&=xDeA57~V`*8%Kill+OU5Q3hEk29 z-f$fz%t6U1McC^gbped^rdhq3>+9OM(CtYeUT+`Gn_XHEhgYvc#oN)Cwk5Ad6_DiK zm;oocZo^x1oLlX2HPaK)n_)eKYUShtt0i@Hbwz2~ey6T@krX8(9r|*_?L_wZoX`J$ zDaj$4%)!}$mRU>?#v@JTC@DRT&4-#Ts#36#SE=d9J|+}qo$j0PMnkl``#9rU(-2Rcip7SwrR*0+N zR!z0t$(c6`{HNVWMquQU2aCVxaPI^}`yo80>-W)wd|&tG4&Tkw?iQG2FZ?OFzZQCf=W@+%xPJ6oPl{4>IlSc^Zk_HLdrDf9Gf}3O!H0{k}pT zSGSRd-7@4`*cLsRth@=B2H3h6eF@;reh_;8$Bz9@7DI9JfbHhIZzM%u78y*lRlwnj zXJ4s9)DeKt^RxQ2%bE#uIzx|vos~D$$-oEd|Fs%FI}`F?+XyztmplBACH`>B{%!-U zZ}YTCTj!O1R#&7Bd3{xq@ZSyl!$A!*iwAK^G_3Z~wDJ>+Hw%i}e|XE^ZxEon7OnzH m0+(x#!M^W#x44&oKk$!6KUm~93V*Q3Zv+AU4J@LodiGy@g2|Qu literal 0 HcmV?d00001 diff --git a/docs/screenshots/issue-10596-after.jpg b/docs/screenshots/issue-10596-after.jpg new file mode 100644 index 0000000000000000000000000000000000000000..03baa994984f3202259b128ef32c2297cfa37504 GIT binary patch literal 12867 zcmeHscT|(xwr>y-#7YU$m4s#}3L2DZBZQ7XLJvp@NFX3hrCYZ2fPi!XfdDBa7$9Ik zz=Bjk2qbhB1SB*YAR@?R7tee9jd%Yzcies68Taj#G1l+<=A7T0bNt3CbFFL*ZM_8? zG&V3Y0B~^u09@NYz}6_>0$|rpo?SdUckSZY#ml>kkN+S)|L)!V!ut>GJ$Oi1RP>Or zh={n9++lGEu%w8{5#=Lbd4;2pqhg0uj;kmhms32d_^T5xUS3{)K7Jv7ej!D15pl(T zx@|oH2=D9XodM z?B2=8!_D)n5!VjxodP_9yM$yct^3rFscB4MAm|*zHNBX|domyhtPTyld9SEn_Jq~# z>ho1k`9xsBx8$~6iEW42j`K6fulTDgo^6$iz;+HhxVX7??c)B!fJ;^Y`zC~~Xiv9B0DHHMb_j3_0L}n5&;RfK{ym>lA&?*(r2lCSuYDOuWfo%c|2$h(8|>W_Eg*JDEp>T$K!Jn)uY!gOIM7{ z!3Ue}&@XDylZ;%<(?IQP$gm`ZqmNw4JRs0lJ4s)+#$R6&J5lt4Rsr-O1kojv+>B@X z>mUnNv?Sy(b48m^Z6yCVxd{J^l$my`WM>H4ePkdg`&+-PO8p`XQ)_$7fc-#9cYpdN zUJMeU$$g!Bt zpj)-2mhmre%-a+tcib_WIDtW#x4k*qe6ZL<_)8Nt|KWgUMGP#1Fzob!Wk6XVHQ~+E zIwnVI`}8+dQ-Q}v_CZS%QVC5-*sD~y!N3aG`K#~O0w!R07>AWL6=)b%>&Y1wq%@{h<}4tXaXQ{pn(4#rcPg zXvewZ>%;5=N9+n7uB$c9RT?^QWMLh?&1AG=@dF9c;TqflO8jRS{&bLKl^)bc!N+DX zuy(ci{K#xm4Z_8~iTGmHI{;$LAJ2s3)-o=^>6TTFrIe5gYVBBEBek|l`czD}^)9tL z%wE$PAe7Y)#c+riw=f@+^4y?opT;SgBq@%yoO;M@nK;e?YRJi_y4qoFl)p}_-3!v6 zfpd$lIk!i@#H}KIDnrZ$xn0dxZx#pP2bszcUYPP-MmnoaqFSw!H8c&Q_xU!}j07(R z>Jny1nxrfktR8Z>a8?b%>isr5okqKi?yE3BB!nq~?vRB<*%+tRk_-Xqy824O*ZWZQ zi2*_rA-k{-@bKSnas^(my*Xh=-JR%~Va1j`jl&Ff$OeKvl3`uziP(70QFbkIv}PV4 zj(+M*2ryDhIPIBM2H9DhoOudb5hOYt?l3yiQ$I3C$d{6mzkRmm+@q*HxavcApToF; zS0@L2DyWWE~g%*#LgDqDET1pJb?@EG0A(n!JLC$R;tIhO#3WQXL@sa;hBC%^d5cQ%BijsdeRVqHYHQBr|hnUxV>bVUCo!n3Re(JymvKMVxJf#*p-mz8fNtGHbt3 z0HJjG8%>+PABmCy!Somri8bdzDEmadm2UR-_bYQru^o9i>H@11`O(Lf_dz7|LC z*I&IRum$M9OEg6b-W8bs{iSmWyagzismT1lNW=*cGD)oBmSRR0{f!24!Qj|Hx}L(* zvLCL|wKlBR5(j;%CnLoDXAXUL|0z~}tvBiT|6cAf5TsYUGmP;vgay=4$4d%>JQY~Uuld&8qHea5JsjsuLkgqpB8K!ZnS;;X3p&wY9TaZ919>417 zs{Vc|@m{@lqPB2Cscf=rS^+Yic}~9SsLH%g6OoxnGtX!y72d2YznN;#?)}aqfUe9| zt2HQR2t61A*$eExvo`6|0FQr#vcO-z;Aj&MvsQW+yju`kb1a0_6~e&;JFeyRTPD0E z$JtsVLtAU}2Rf|if))PqF>(n|U9x2xG&QI{15@=pM(hq3WXTnmnNWPW=uK7M`S)3a7;lbJ`B zL2;PH7JxW9$ZoIz_m7MjlcoEO+*@gTHBVl>RS>2~EMrx{8Kke8i(7z74A{3pqo5RK z4Tr&bR8AssxA;bdu@2t%3GC8TRSFUn&m;%I@mi;f*I{wbQAw^)Ak-2nn(Podl8jO5 zqw4F!qs~|)MZY;r8h&YtFzGzmW=M;5f0UsgGQ?7jhsSmZapvxK z8f(g7JcD1>mm!f`0OP_UnQoFNtvl#*85-k@Tp5~~`&hAqolbln~dQY=RP*XY7vw#*`e4jFj7lVC@#Su6OjPw(Mm1uJ}`I z2N2XJlNHnuk8Ec-sSAA);0F~0ctXBd-}ZreTq4p@i}&!Uy%v+ntQCiV&Il9RIB!)Y zi#T^HxYU8XE2M0haLGYsCVc_dgK%QQOy{wQQMi1isO$E;BPu&nJ$*=5=CVvUDg~5C zEhx5+1`Ib&z1&nS)$$3lp-#0$AmNr05>_~DjwBYN8xMlAgMb~uj!t84C#A2X6&T-F zt#jN#YLi9oi(hP{=H!4>GCP829fh)vi9kg+AklUyZy2J}dJaxL#+Zj2_Ev|^S?hN` z@|MHZq!qVTY2rpTd~?#ZR1yC5v*l*LRIYhNxi^*NRvOIC%}ZJ9?Qwcv?>V3(NEFod zK>`n_%5~-SnbnSNAcp%iYWeODPO$h%(^uPG%x?i!-Mb5=9XK;On`f%jx_mNwCa2A? zF1CoTlb>*ZV2;zt(uTwgC_NHo{U)*XC#v#0K4Mrq+Ok->YmeRkK)1JloBlHlblpmy zD~l(6nXo}|zDrI0d_Fw}cD2)fS)x9!lXaDkZ5D!^?N-edSWB&X|ho=C= z{1@}*8fNW)J@Qi`{|gRYEDi3HRh#<*N zfgWk%zMo1Q|+$}%CzvAl#eZ}aCZx)Q6%o#dgT1_@lO2bI_u7Er$UN2X1yZ<>16+AH+wVnSq7~kMLN9gb47?`5NczibTIT!X&K!fln3AGXOp2u zNd@=g>|R{E_B-JhdRUMBQy(WB+4K5$?>dW) zt=}Ztivf-QBMioS2hETsj*?3~L_vl~dqL^&!=a0iP)Uh1v;MuziNn+EALsLYb)%o1 z`;J@ZiWE2{v*Ixp``n_2%VX?T2Ltdo{P$Aub6wjZewbnX!!hcYmXl`!%QtE_ci;F` z#lv-WEz}0Ba+-KtJS=6%GJ17-3($1I!Oz}wz2bnf(Y2~FuVVjAaQ_xSzPbaWn;RXo zboL?|0<+;1MHzI|8ZOd$wg6UsE(A0r)R80?Rb|1#0hLqh0_9g$h|#}&@ypVMKM)pj zr>?`MG*Lx|Ry!C3Bu0lx_8cm)o*y@^aZ|;R6nlI6Mu5A;dK&;f>drWIrQ(NmMsR(;|GSV!|iCDEM-?r-s z@#7ejR>db__YfawJg|wb9dFcNG=FwT@hqIszWWEJMwwS3ec}--f&;fk z0zD~oEx(}GqqcPXpte(Nz7?Zfn~X(8U~1u zQ6|^N-jJWrKmO3Pb@ z&Gzlv^YCSgZ;%q3I5&z<##X!`)+wAzksd5eeyy`DmD^2RT4t4H&@zEZTW~3Vh$;~Q(}elc13~BtJEA;@yPSP z#hq$Xotwj(KQ=0*^iAI#UR(~h(j<}M2&8<)#9oh$?=h}nQf8|HNrSTsHEHjVxlr(Y zDcZcsTaxw~mdeQNOhIyHQ8C}Q02V_~Ii3@klHxu?i2Q@tbGMWz@csnqV-S7GYUzW2#$rDVI?}F$OaQ1yjCqlxsKC-%^uJOk5gV3hCZt6^{ zw=CeJ8YpQ*UUzxm(QOWz7)FZ9mG%EtSKF$R?*DlC24M0^XMJc*ouH>$qQx#bpc@>1 zo^BpbjRhk~L#bGh))F$Xc-Yb!jnl)qWeB-n50qE1)>Ak!FC<(N(K*u(WmH8auO{~x zfFK}GxXWef`w=kZAcK@Ui>ZmdGnBsQ`1d2i8S3)f`<%gXh&tet2vQN67|GNhST{vD z(y);762D)Z^GlWWkk5Yf1Zcdar>m-%Z=w)>q=?E=|9hH}3klSA#)q zUj^Nkdq}+tp8N?39QWq|I;o8qd{3%|;TU5qxuJ@Vq7Ndfju|^0Fai;YF&RlA`V?Gc zxI2b{y{2g?UbuaycJR^?{;CA`!?{8T9)WUteX;tz31t(Cw8b`8ysy~;2;!eR{?etP zI0E^FT3&5Kaf7#1tI56`Yftubd_7w`+RN*3K(iI|KK)=TP0Q4Z*xT22cFyL)#riDh z+{;k`-{nB=qkmPST?(o}z5d(x&D zTf13~A83#}NoC90+mZ9FX21`I9wbxD62?73(+FjrlZ!qr|*;DK)58UUK6OA5PKqN zd*J0Bi>t3YRN>bCB5(j<+n7kvN17(T%<&_xQ>wx$Fm4s5k-6Y~ddIYh@5|FW$KeP{ zaEh;~6E)msmOzfmTfO<_b_Y2iXX?qrjsPcTYRVSiU6-5=&6HMOOd(@yYp>Z0SSAKL zbyd4^v~*?DFNu0o>%PiZrfK#Bjw6wABoYtl0|OD|*mP&F_R_p{ z*Tyexwybl}TtNa4Q~&y1=pPYcVwVtGfXp{VYX8`mF8!+HI(t!15|PJt46yRIJAC@k z!WQ6b*%lz9^~vB{m+CFR>%1Sf5&+(o<86DKhTJ_azgJ?35124)=9&|z{R>>N&`Jz_ zHW^czu}%IR7mbUUw_d4MQ{^y2M-sLKW}=Fy?JAobl2_0Eq?jH5ncaWsG)!r1-4}A} zkS3{3Id}m>wk;Lu=xs>sJGU3HcuTRwW1pWvE4vsf(dS{F7#`21>6PicJS^IBJ%*U8 zc?+H=zb~dv9UVfn%QEY#e$Z4?GjAz5ztcnqYoiWx^YpPT6$rE3ee*;|fiqelS#46> z7$w-(38Q{?;^mL+%BHcvN5L3#7RP6yAWd~z_Gz#S;7NH}gb??$j~u)oyaR3|sk(hf z2B8abg3V&agzW$Th})yc?S+=r%YudgEwzpYQZgK-sunl)T-pIrIBy35m1bc8T$VuP zhKtYWz*+>%jI9oUfJl&HlokM>oCT{wX$jk_l0E8gZ1XK3o~f^IaphO;0X*q`J$C^+ z_4TVjpzv)az=w8UUee)YLRnbZSxS&>f>@?T=U{LNrH(aMwTPN|it`a=s|ipr_5xZ0 zdvC~4zh}Uw8)h#)Z<^;_Qs`|)eTAfSUF$81jbtAfvv?pOA}AxV`{1vU{xyy7a@4fN zH|)C5!QRcz!q212^1sCu=HZ@rVbqAO1Ily1-?3TvWBJYJM?>Npdsd^r_eXcWyTrpU z{(itMJ3}dZ0IO7Dz|cbF#4VQAhsBY^S7HnrMZX%%huu#^!yq;j7m)}b*2?j&EO7qL zr4)4q*k|e}wr;XihnpvByKaD#6Vu>`Mu7@@$z>l28i}+>nl{fL-`yA3IEi>%?A>r$ z#Ct}@qMSaWopgEK>iNE%YxjT`ZRW>y)Y@?teN(2?K$XQDY+oII$w%;-mHEA7cL*}s z@cwdxC3}dJM-6S|F41z=yN}=)q?z12XTSg8hI+F2A>%dHQrH>0joF0wVErl=uZh|& zeD8-EQqna5g$a2H%FKdaDo(5G^!_A*=zJL;l5Cht%$OVN@}W@BBR*H&&^zla*0kfBTXL-w&oR1@M z4`HcR#LvF$Myih`u<}prD)NBeHmv znB|-|j%AixyOfHmX1lIj7ujR4M4p!k2N@COKEL}N|n26tApynlYwaj!5(+YuP< z5me~|wUn4$a4rl$nC4--#-@qv!MiK!aFm6hI{d8WnnO0{`CZI{aTp90>TseBe)X)zIy>#cmn z&D-(L9AuUwNC#oh>sG0S>B{=O_-eT@w%$f#?peV-FyH$cwr5 ze@0BKxqbhEY6|+|Ef)Ch!?neg3koAra?-cl>dg}RI!vS`3rov%$|3 zEiAV;m%}dHnAMHC%h?|X)1S>Zzqj0x09_x*m}S8=#b%ZK5*mOaTYz}^)Xm&xkta1- zJN=FDq7(fYD0 zS@pItSp+3h*)oeEUa3&2ib|0+{%|fSaJ&OTYVfIuiyL*scJ~~^*VtK;nWY)~9ptT> z^l>>ER^Gs*&a9C-%$qHMLQB1-HkYac*Kw1*T^=wXH@l~XfO$kWpVz}JP zNi9{nc}r;m-IYk7#x(7Q+NX(uk~KgOmwp(FvaX?N{o1kenU9*z?t$xfe5GwE$)09B zT6A1+poT#h{|eHCc8r7FuIGBRlguvMer{7kM=Yfo4t=lE6xsXAVEu9$Nace+%x18e zu+~;nmcEOWCPpMfMEG<_r2`9aIh|98p6?`;#zVf?!9LV&!{bR7hn^M}n;ImD0lOoZ z-z4s**fdi8Z04;Ys0Kgk4<1P`*r&Y)#zgRoOXcYYi;ekLupp9dTxE3$EWI}bABMG+ z9~k4QZ&WERYnd)_23Syc41jIB^0(-pV&WeZ1`Yo9$lH%{YTmd5 z4?G5t_*slgYM%N1mWU1&qS;$ITFROa%|O%$Q)3K=#7(m#l`4>Y%Z}%}53YHy-uUx) z{43usT=)u!?(*-={zr{|{P%F8Rthya78z$DdfIpELF+YZHe7H7RBqumhzoALBwiR0 z4%!>XBW3Xj6Zv8xPW^~*h~5P8>!GS6?Kdn3zQ>f0Ik*42n5M1jiyh?GO6P!7J@}p+ z@wlqs?i&fVs5#3Q+k5t}B=^t0cmBKrkNa7v{?v0N?hymHJ!?HH`jB>am$I_Qe~&=y fr~iKm{wMYKza;j5CCGpB*TjFt)nEI~*6@D-48oyb literal 0 HcmV?d00001 diff --git a/docs/screenshots/issue-10596-before.jpg b/docs/screenshots/issue-10596-before.jpg new file mode 100644 index 0000000000000000000000000000000000000000..2630a3d03cde6b11362ea9d9a1e208cf9bfd5490 GIT binary patch literal 12322 zcmeHtc|2R$|94tNtF%=ON|cH8^Er0azJGpiVav$UoI%#@AHkxSXnK{qG9kRATwh7&Mk_| z)-|Wdhn+|%Og$7i9mT1&lMYrPYb&08Cn1njYCw9s-s;wR^6sl3tpKGokFv}5gJ7p> zAx&YoZNRGMk)ojmcz^9rjMKV|yJpT-andbp$RLQmVvK&DxL>e~`HHcQ%)PvPSTn1! zvv7 zFg(*vjlj;7(BBt-7X2~x%>wAWK;a|z_ehv+b4%jNI;CQ8cEs$i*FJ%pwQ{ba3~sLJ z4S_<68-C@NSX9;QAxng0epeCLGVqM3;vD{LM2twiJN#69c8>jQL0_n*Y9k8*DISe@ zeM-^O`=W$uW2t9mB4ePa*D5YcaHta8HZWzS8##VWmMKnft^Ft-uGm&-*CJ z9j|Stx0r+Bpq(}3ueiPS#d&656ETf`;LDTJ-DukDOcQsak-8WsTKa2-^$W_cLq%)j z&t8UFc)j&;h>i|cmoc49E(&0vZ8^@+t}DW48Rja;=&TD-dpM4IwW?J~mgP2{2O@BeCEy{-pvoAV#kRxw z;l}!L*!|-59)-6=pUr#9Iq;<{%%?B{dl~Bb(Bi}(?>Ns?@qt*hF@DnxHc+z=90Ef` zndRDJ#L+SOAFs)Rx^zfSn+!zCBv-&;WQW(I$e^bK$S^6-hx5?Y7`_`_7BZ@CYZsdq zUj#4+IySz6IJGqGG(E?AcpYjiKCjEhFZ#~xI=?w1&>%#|t;peUptm4dIz4)K7QUeg znv$eWnKp*gmuWNlvjUctK@hbRIr$AK;eTFs?Xwo{JfQ^qS=~p2>d#2(HqjJ~0elSh2%4QkRk!)9_G7c*H@`QYFy znVl*J{3LHq`ZUgqHBSaBLvMMmAQY-U(87Pc`-+ z!rF%JmWZL|yh_)PjxO}}*X`s@we{SmX6A&j176!VKc7()<#CgVaxE&nT1-RLkdf8x zL1HI!RGPg@@X>9puPpW3NnJgV=3+Z(S#m$?n9HajVXS|p?iAn`^^BYpJDb`h0HzC$ zw1Dz=qk2&&<BO zGlx*pF;?A~-Ur@?`;G8ZhZx;iWInQ8N3Y`&io2& z3sV6U5Z%YmK6%Le`Or!#pA?^K;T$| z+G=BJ^OS{)0O6|jEyUZso9cfw$3D4c%>3Ki&uCQ(H(o#-YAVIR%ww~%Qwr4}ElF;E z!GkR$qoaeVVe@15olh`6p~fY5ZG)#%isKY>P1MCk+Fc-n!V6JB%dFv$5AhN+@rN5Y z{y!hFyC~7B%U}FTFD_6Xi^$z|#i=1!W=^9za@nlYTlU}jzk2)|5C7)Fe_9VRsT+tb zUU41?q;r(Z8tOrslY|@ETL>so6osS4w#+3hP-XiFSU+0%62yV#ZZ(;j0Y93~y5d2j z1~YDvzf5PQ=85M6F*u&BsKLuwr?5~OK-56JR9X^EGIGahmIy*1}1RgOwsc+;O?|^Ga1)aBDYYhMHB}*vUDY&`k?*KXx$L)n)12EA`ki_ z!g*;3MCH+pcBO~l^>dGlRuh0xknX&LEK{nClR1Q{`C59B^@xF}OP_yr@j(o2X?S+V zwSVA|{^aK>$y~eYgY|)SpnCPIF2o0UzCg{K+~PO|_F**o8VxN3O{yC>-92;_qm~O% z7UEAbeJf^v!8rL`UXyS-j8OBEt-l-qPHc;+tG+mPjHin;A?hcb08BTEc+nPZ&xVlu zYNDxqbs>Xj0)%?NYaem0{r)SP{#OHGR~dJsqsN(NaUY#h&Ry**(D6F)(Or0H9L zKGV{0NlK2xW5eC-Gw;!n^H!=Ot_Sk#Jr8D|(0SXeByKGeo7UD;)6y@Ut?3%q4`VGG zW&L!H(je(N@-X*ktq1-Rg;!EC8#1qo)G9p ziLD@vYqw7{zpNM9v>B>H7k~;H7?&gBUX_20fXZC#9Wod=(dGu$^zIG zZ$p0!Ceq=hGA68cmnzj5@6@{{x5{M-;tKZC*-xpZtw1A}P=D`y57QX;GAF&nhUw>x zL=%HP!^`*HkK7H&P%~Wj?#8q9_jJ$Ak8{JsY@WlF#LXbe-ZEIi%TzfxyXq5XljCUiS!WM3JL)$hxvJlZNMq@=iW&+ z7X$K{kKQa~^o!i}#%}}m6>eU<{9;+mcC@iAWvH&68t!;Tolg6#Td>wRDZ;HX;#l~t zCicyI;oruMlmD$6(?6T7A&vX4uAhm@CN+RHUOr|rcYia&Y2;% zcqKnijenkkW}aEXj~#0nyTzbg9tVerh2WDcaM+y;K`Bf&x`0iL%aXJEZ(9C-Z&l+C5V;JG3xiBhzKHD^?cbO7}(=eDD z*I2X=fBPmNz*Xm*M3!aM#b+)W8LG{{d))Us)y0o~_j@t626?@wHH4qd7Y&tP;>a%2 zp9gBxYelUgVG;=8tRAF_CDt9Dle#pJh_qy>`uI&Yr@!6mi_MAkuFHrD8l~f!K8be{ z82;i@{zhiE`sKhs^{{DBGo?%JFR#{hoGZ-jZaY75JRgkRTR1-l#*SBLuw?L6pj4q6 zLBinv=t2S}% zW#|lE&dr-7z6M14r#Ei$bf;{}JR#e=3rOfb9egmSuH9Sr+M#6zEQl-H+$eIXuKrH$ zLqCdC|E6K)@2BtV$X-VpNSC+M(r;d#&JD7BZQkb}2XS97b826yu2Ac9ig+fWk`)(6 z&FbuJ1RZLp8HeJoxLAFF3O-*Pc&*wy!0SBJ_r#x6!~6T#b=s7z8RE!Y{FH1eksee) zR3rDdts0|Yu(A(J0~N;7&n{x8yQ29|;jcjOazEV*l`_euQhl9^ri`s$Wd?n{^skC0 zA;7r=Nde1?C^MNJ-Q zr=*&L9Gv66obTc-pb|s+IjX52X~ULowIZKpnlNaZ+F==Vzcu4wzt#7?()C*RaM#VE zUZLV`;S!u;J8-`)Ly!`Su31d=We|4sbAAi6lfTQo522M!Qj|$vU9%*`!?`ls`puF# ztv8LQ@!jL&%l#JW_E|Q_NvQ;|~70j;4a3_cMy!g|sLCd>Yo`+@b zw{oS8gQEK`g~y^%Q+XhKO|O9|(Jk475-Uq8@=h7)z+-J3W0)M)nNbec*AV)e$e_kE z_j`~o8r=qb1$bv6+2kUGV@RX13w4Zx#`(Z1GCX<$xR<|6U5B!9iU%Y+7U8HhoPNXxVOIV+UfGz>C{5y4+}3HO3RF6Xt3ns zWz1%%{F{Jm@((pfvE?@EMWK3;>SJUzHYQ;_igF3Dy_V`@G+p>YaI z_M{3;!9|br%yD1AGpRzgZIs&jJr`T%3rn8YBklBku4MZNGJtHn4ne7CG$xGp`RV+| zcd4X^%w4@`+k=8}qmASW9P)Zgfv!<1!8$->SW%Kw%;R&FxoKonNiY0rTxps1CI`jZ z(RsQbfwsVbmfH&tRtdMHyAPHOoQ7Nhi5s?z4|GpRjxe187XC&$sW4_o5<>i^XL4qU`0Ls&Dy zK)$W&t?R=kkT(%%(>L|vWtnaAvFR(u0LS5Z%j;>va- zl0K2_Iyhl@_%s2tLM6`=h0EFW`f->>P5&jJ?aNEH>@p{UL`7V0Ncq*ci0D_>DSPAH-mi9z-Cqcy1c_LDz>S{R;eO^y5)&x6pR zWV_91)vneg-dp?Mv4ZO@l$^QT^X;Jay(kmYgd##Hjjx}rs$(6}7 z+G0wRm!lI0s**aM%s)xY=_~kPHFx4G@~X$oeSScMs_5lq6G`2*AdD2>{Ux4_FR+S}+nB9XX64a~6 z>eeCV2wPQH4OvsAFL>PJ6}Chx?$*KlcR#^sly`}B@*n)xsi|trw%!r{&wrAK+uY;D zfGF7(F4M|M69*EVf9XS4K%pPEBSaF0=&(nD*iF`vSni3(SB~?c(-HdVL`~et%v; zKu#Jzf`~rBF+TO-&sSJ+J3JWoiO=WF^fut9Tblx#(Un0mC0%R_O>}ZL%G<84ija6= zh4u4R#MV=Kp>?nzcbToUY)={ZaVM=OJz`UZC9j#1T|#JI`^EkKvnM zb<33lVxRYZHry&7|KR8YXnf@QaE9^HPScenf)5u0n-m&|6Ybg)f}l1S{8<0Vqy;4$ z+2)dtess*|V1Xk|?hW3h5Nswn#zNWw4i$1`PT?T=9@~H;uT`H_2NxnQvl8Ekq7V|$ z6OY?D&HM; z6D!-#v|m4RGU8czr4{+xbX;dMiq&xxw`hetFAj3`4y?+Ve_uTK~w6=lZgi8Yq}?6Qi^SG!>dc^lR7# zj8I%N;7Gyd#D3_;)sAY*E6bedCBO2I{oqGr8y_Z4Eg)SWmpqWjyLvKzfN*eV$h^(; zT#E7%#(W?bqkUd(%GgYJ%X|Es#k@FA=M&92xUk=?;v*jyB=4}YTnpLYo-@f3@@yPr z^uw9Wn9A9O z??adOuLO#lyvLoehsrfN@$-Y4adNc2lm<-pV9OL5QBe_sC8WoGzrgH*jt5XaS6pl4 z*IOuw2=cR5`T=bX z^)mGrB>E*#bgXyW9HrJBDryq*%W(}6Arx_S(PU#wqt(wywmg}Ep_ z?10&|r`Ox?M0hspbEEmi^lp_!7rqRG>3QauPGjgp#eO)IB-UnQ`*7B3!AGwXVCGzy z;+B~89wAKw+p`aN1g@81&R({Xj9|LMNDA}GeEP^LJBaL3khV$1*QUF_P2-P)yDWmm z#{R^#TU;uVX#C}{*7(2KC^6pIKFiRW3Zt*F^t(t0w0~rCzD}aVSKE(+T)029`!>T| zZUX*)5k%nr{}kbw-{a{w!r!Cax`qL(&6&u1bHlHC87-N(GLUm8jJ<#L7{>tZavy9wk-CBYC9`xy4Qg8~Z$b z2E8i~&;T{5M_ug;1!PghvbSgh&@)dJ@DY?cDo4PsgikDss)kbCwdh@fIJ%u_<9bIBzieS2X2?_6uY=l%~XF95JV`c5Yg<-TwFNe|#4CqwwEz R{r~9sufTtk%Dmfy{|i&ASBd}t literal 0 HcmV?d00001