1 parent
e9c35fe619
commit
520de302dd
2 files changed
+32
-1
No files matched your search
@@ -287,6 +287,10 @@ public final class KafkaAgent {
|
|||||||
}
|
}
|
||||||
|
|
||||||
private static KafkaProducer<String, byte[]> buildProducer(JsonObject conn) {
|
private static KafkaProducer<String, byte[]> buildProducer(JsonObject conn) {
|
||||||
|
return new KafkaProducer<>(producerProperties(conn));
|
||||||
|
}
|
||||||
|
|
||||||
|
static Properties producerProperties(JsonObject conn) {
|
||||||
Properties props = new Properties();
|
Properties props = new Properties();
|
||||||
props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers(conn));
|
props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, bootstrapServers(conn));
|
||||||
props.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG,
|
props.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG,
|
||||||
@@ -294,8 +298,10 @@ public final class KafkaAgent {
|
|||||||
props.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG,
|
props.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG,
|
||||||
"org.apache.kafka.common.serialization.ByteArraySerializer");
|
"org.apache.kafka.common.serialization.ByteArraySerializer");
|
||||||
props.put(ProducerConfig.ACKS_CONFIG, "all");
|
props.put(ProducerConfig.ACKS_CONFIG, "all");
|
||||||
|
// Kafka 3.x enables idempotence by default, which rejects pre-0.11 brokers.
|
||||||
|
props.put(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "false");
|
||||||
applyConnectionProperties(conn, props);
|
applyConnectionProperties(conn, props);
|
||||||
return new KafkaProducer<>(props);
|
return props;
|
||||||
}
|
}
|
||||||
|
|
||||||
private static String bootstrapServers(JsonObject conn) {
|
private static String bootstrapServers(JsonObject conn) {
|
||||||
|
|||||||
@@ -29,6 +29,7 @@ import java.util.concurrent.CountDownLatch;
|
|||||||
import java.util.concurrent.TimeUnit;
|
import java.util.concurrent.TimeUnit;
|
||||||
import org.apache.kafka.clients.consumer.ConsumerRecord;
|
import org.apache.kafka.clients.consumer.ConsumerRecord;
|
||||||
import org.apache.kafka.clients.consumer.ConsumerRecords;
|
import org.apache.kafka.clients.consumer.ConsumerRecords;
|
||||||
|
import org.apache.kafka.clients.producer.ProducerConfig;
|
||||||
import org.apache.kafka.clients.admin.AlterConfigOp;
|
import org.apache.kafka.clients.admin.AlterConfigOp;
|
||||||
import org.apache.kafka.clients.admin.Config;
|
import org.apache.kafka.clients.admin.Config;
|
||||||
import org.apache.kafka.clients.admin.ConfigEntry;
|
import org.apache.kafka.clients.admin.ConfigEntry;
|
||||||
@@ -416,6 +417,30 @@ class KafkaAgentTest {
|
|||||||
assertNull(kafkaProperties.getProperty("zookeeper.ssl.trustStore.password"));
|
assertNull(kafkaProperties.getProperty("zookeeper.ssl.trustStore.password"));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void producerDefaultsToLegacyCompatibleNonIdempotentDelivery() {
|
||||||
|
JsonObject connection = new JsonObject();
|
||||||
|
connection.addProperty("bootstrap_servers", "legacy-broker:9092");
|
||||||
|
|
||||||
|
Properties properties = KafkaAgent.producerProperties(connection);
|
||||||
|
|
||||||
|
assertEquals("all", properties.getProperty(ProducerConfig.ACKS_CONFIG));
|
||||||
|
assertEquals("false", properties.getProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG));
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void producerAllowsExplicitIdempotenceForModernBrokers() {
|
||||||
|
JsonObject extraProperties = new JsonObject();
|
||||||
|
extraProperties.addProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "true");
|
||||||
|
JsonObject connection = new JsonObject();
|
||||||
|
connection.addProperty("bootstrap_servers", "modern-broker:9092");
|
||||||
|
connection.add("properties", extraProperties);
|
||||||
|
|
||||||
|
Properties properties = KafkaAgent.producerProperties(connection);
|
||||||
|
|
||||||
|
assertEquals("true", properties.getProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG));
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
void brokerEndpointsFallBackToLegacyHostAndPort() {
|
void brokerEndpointsFallBackToLegacyHostAndPort() {
|
||||||
assertEquals("legacy-broker:9092", KafkaAgent.brokerEndpoints(
|
assertEquals("legacy-broker:9092", KafkaAgent.brokerEndpoints(
|
||||||
|
|||||||
Reference in new issue
Block a user