fix(objects): keep browse search filter per tab
This commit is contained in:
1 parent
38df8e3097
commit
5244e57dca
9 files changed
+79
-3
No files matched your search
@@ -80,19 +80,28 @@ describe("queryStore database open state", () => {
|
||||
expect(store.tabs.filter((tab) => tab.mode === "dolt-version-control")).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("keeps object browser viewport per tab and clears it on schema change", async () => {
|
||||
it("keeps object browser search and viewport per tab", async () => {
|
||||
const { useQueryStore } = await import("@/stores/queryStore");
|
||||
const store = useQueryStore();
|
||||
|
||||
const tabId = store.openObjectBrowser("pg-1", "app", "public");
|
||||
store.updateObjectBrowserSearch(tabId, "orders");
|
||||
store.updateObjectBrowserViewport(tabId, { scrollTop: 340, viewMode: "list" });
|
||||
|
||||
const tab = store.tabs.find((item) => item.id === tabId);
|
||||
expect(tab?.objectBrowser?.searchQuery).toBe("orders");
|
||||
expect(tab?.objectBrowser?.viewport).toEqual({ scrollTop: 340, viewMode: "list" });
|
||||
|
||||
const otherTabId = store.createTab("pg-1", "app", "query");
|
||||
store.switchTab(otherTabId);
|
||||
store.switchTab(tabId);
|
||||
expect(store.tabs.find((item) => item.id === tabId)?.objectBrowser?.searchQuery).toBe("orders");
|
||||
|
||||
store.updateSchema(tabId, "archive");
|
||||
|
||||
expect(tab?.objectBrowser?.schema).toBe("archive");
|
||||
// The keyword intentionally survives a schema switch: the mounted browser keeps its local search too.
|
||||
expect(tab?.objectBrowser?.searchQuery).toBe("orders");
|
||||
expect(tab?.objectBrowser?.viewport).toBeUndefined();
|
||||
});
|
||||
|
||||
|
||||
@@ -4076,6 +4076,13 @@ export const useQueryStore = defineStore("query", () => {
|
||||
tab.objectBrowser = { ...tab.objectBrowser, viewport };
|
||||
}
|
||||
|
||||
function updateObjectBrowserSearch(id: string, query: string) {
|
||||
const tab = tabs.value.find((t) => t.id === id);
|
||||
if (!tab || tab.mode !== "objects") return;
|
||||
if (tab.objectBrowser?.searchQuery === query) return;
|
||||
tab.objectBrowser = { ...tab.objectBrowser, searchQuery: query };
|
||||
}
|
||||
|
||||
function updateNacosConfigEditorViewport(connectionId: string, namespace: string, viewport: NacosConfigEditorViewport) {
|
||||
if (!Number.isFinite(viewport.scrollTop) || !Number.isFinite(viewport.scrollLeft)) return;
|
||||
const tab = tabs.value.find((candidate) => candidate.mode === "nacos" && candidate.connectionId === connectionId && (candidate.nacosNamespace || "") === namespace);
|
||||
@@ -7704,6 +7711,7 @@ export const useQueryStore = defineStore("query", () => {
|
||||
updateEditorViewport,
|
||||
updateEditorSelection,
|
||||
updateObjectBrowserViewport,
|
||||
updateObjectBrowserSearch,
|
||||
updateNacosConfigEditorViewport,
|
||||
setAutoCommit,
|
||||
markManualTransactionDirty,
|
||||
|
||||
Reference in new issue
Block a user