fix(snowflake): resolve database and schema completion namespaces

Closes #10953
This commit is contained in:
t8y2 committed 2026-10-02 18:52:05 +00:00
1 parent 6d1c3c8373
commit 59b6de2cfb
12 files changed
+378 -23

No files matched your search

@@ -1,6 +1,17 @@
import { describe, expect, it } from "vitest";
import { sqlReferenceAnalysisDialectFor, sqlSemanticDialectFor } from "@/lib/sql/semantic/dialect";
describe("Snowflake semantic dialect", () => {
it.each([undefined, "mysql", "postgres"] as const)("preserves Snowflake identifiers with fallback %s", (fallback) => {
const dialect = sqlSemanticDialectFor({ databaseType: "snowflake", dialect: fallback });
expect(dialect.id).toBe("snowflake");
expect(dialect.normalizeIdentifier("Adventureworks2025")).toBe("ADVENTUREWORKS2025");
expect(dialect.normalizeIdentifier("My.DB", true)).toBe("My.DB");
expect(dialect.quoteIdentifier('Sales "Area"')).toBe('"Sales ""Area"""');
expect(dialect.supportsAsForTableAlias).toBe(true);
});
});
describe("ClickHouse semantic dialect", () => {
it("takes precedence over the legacy MySQL behavior dialect", () => {
const dialect = sqlSemanticDialectFor({
@@ -17,6 +17,34 @@ import {
} from "@/lib/sql/sqlCompletionLookupTarget";
describe("sqlCompletionLookupTarget", () => {
it.each([
["Adventureworks2025.Public", "ADVENTUREWORKS2025", "PUBLIC"],
['"Adventureworks2025".public', "Adventureworks2025", "PUBLIC"],
['"My.DB"."Sales Area"', "My.DB", "Sales Area"],
['"My.DB"."A""B"', "My.DB", 'A"B'],
['"adventureworks2025".PUBLIC', "adventureworks2025", "PUBLIC"],
])("resolves Snowflake %s using unquoted uppercase and quoted exact names", (qualifier, database, schema) => {
const sql = `SELECT * FROM ${qualifier}.Di`;
const completionContext = getSqlCompletionContext(sql, sql.length, { databaseType: "snowflake" });
expect(completionContext.qualifierParts).toEqual([database, schema]);
expect(
resolveSqlCompletionTableLookupTarget({
databaseType: "snowflake",
currentDatabase: "DEFAULT_DB",
currentSchema: "PUBLIC",
supportsDatabaseQualifier: false,
supportsDatabaseSchemaQualifier: true,
knownDatabases: ["Adventureworks2025", "ADVENTUREWORKS2025", "My.DB"],
completionContext,
}),
).toEqual({ database, schema, filter: "Di", qualifierDatabase: database });
});
it.each(["postgres", "sqlserver", "trino", "mysql"] as const)("preserves %s qualifier casing", (databaseType) => {
const sql = "SELECT * FROM Adventureworks2025.Public.";
expect(getSqlCompletionContext(sql, sql.length, { databaseType }).qualifierParts).toEqual(["Adventureworks2025", "Public"]);
});
it("treats qualified table completion as a database lookup for MySQL-compatible engines", () => {
const target = resolveSqlCompletionTableLookupTarget({
currentDatabase: "default_db",