From 5a11b8f148dd06a3120dc0cfea4189b34a195b1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=BA=8C=E4=B8=AB=E8=AE=B2=E6=A2=B5?= Date: Sun, 30 Aug 2026 09:59:12 +0800 Subject: [PATCH] feat(sidebar): preview and confirm MongoDB database creation --- .../sidebar/SidebarTreeRuntimeHost.vue | 59 +++++++++++++++---- .../__tests__/mongoCollectionMutation.spec.ts | 5 ++ .../lib/sidebar/mongoCollectionMutation.ts | 5 ++ 3 files changed, 56 insertions(+), 13 deletions(-) diff --git a/apps/desktop/src/components/sidebar/SidebarTreeRuntimeHost.vue b/apps/desktop/src/components/sidebar/SidebarTreeRuntimeHost.vue index c352b904f7..370a20ee1c 100644 --- a/apps/desktop/src/components/sidebar/SidebarTreeRuntimeHost.vue +++ b/apps/desktop/src/components/sidebar/SidebarTreeRuntimeHost.vue @@ -111,7 +111,7 @@ import { } from "@/lib/database/databaseCapabilities"; import { copyDisplayPathForTreeNode, copyNameForTreeNode, isDirectNavigationTreeNode, isDocumentBrowserTreeNode, isRepeatableNavigationTreeNode, objectSourceTargetForTreeNode, shouldRunTreeNodeRowAction, treeNodeRowAction, treeNodeRowDoubleClickAction } from "@/lib/sidebar/treeNodeClick"; import { customTypeCapabilities, supportsTypeObjectSource } from "@/lib/database/databaseObjectCapabilities"; -import { mongoCollectionTableTypeFromNode, mongoDropIndexFailureCount } from "@/lib/sidebar/mongoCollectionMutation"; +import { mongoCollectionTableTypeFromNode, mongoCreateDatabasePreview, mongoDropIndexFailureCount } from "@/lib/sidebar/mongoCollectionMutation"; import { dataTabOpenModeFromTreeClick, type DataTabOpenMode } from "@/lib/sidebar/dataTabOpenPolicy"; import { isCopySidebarSelectionShortcut, isEditSidebarConnectionShortcut, isPasteSidebarSelectionShortcut } from "@/lib/editor/keyboardShortcuts"; import { handleSidebarTreeDeleteShortcut } from "@/lib/sidebar/sidebarTreeDeleteShortcut"; @@ -3603,11 +3603,23 @@ async function confirmCreateDatabase() { await connectionStore.ensureConnected(node.connectionId); const config = connectionStore.getConfig(node.connectionId); if (config?.db_type === "mongodb") { + const plan: AuthorizationPlan = { + steps: [ + { + id: "create-database", + label: `create database ${name}`, + database: "", + sql: mongoCreateDatabasePreview(name), + operation: "createDatabase", + targetDatabase: name, + }, + ], + }; + createDatabaseAuthorizationPlan.value = plan; + createDatabasePreviewSql.value = authorizationPlanSql(plan); + createDatabaseAuthorizationResults.value = []; showCreateDatabaseDialog.value = false; - await api.mongoCreateDatabase(node.connectionId, name); - toast(t("contextMenu.createDatabaseSuccess", { name }), 3000); - await connectionStore.ensureVisibleDatabase(node.connectionId, name); - await connectionStore.loadMongoDatabases(node.connectionId); + showCreateDatabasePreviewDialog.value = true; return; } const sql = await buildCreateDatabaseSql({ @@ -3640,13 +3652,30 @@ async function applyCreateDatabaseAuthorizationPlan() { createDatabaseAuthorizationApplying.value = true; try { const config = connectionStore.getConfig(node.connectionId); - const results = await executeWithProductionSqlGuard({ - connection: config, - database: "", - sql: createDatabasePreviewSql.value, - source: t("production.sourceSidebar"), - execute: () => executeAuthorizationPlan(plan, (step) => api.executeMulti(node.connectionId!, step.database, step.sql, undefined, undefined, { maxRows: 1000, continueOnError: true })), - }); + const isMongoDatabaseCreation = config?.db_type === "mongodb"; + const executePlan = () => + executeAuthorizationPlan(plan, async (step) => { + if (isMongoDatabaseCreation && step.operation === "createDatabase") { + await api.mongoCreateDatabase(node.connectionId!, name); + return []; + } + return api.executeMulti(node.connectionId!, step.database, step.sql, undefined, undefined, { maxRows: 1000, continueOnError: true }); + }); + const results = isMongoDatabaseCreation + ? await executeWithProductionContextGuard({ + connection: config, + database: name, + reviewText: createDatabasePreviewSql.value, + source: t("production.sourceSidebar"), + execute: executePlan, + }) + : await executeWithProductionSqlGuard({ + connection: config, + database: "", + sql: createDatabasePreviewSql.value, + source: t("production.sourceSidebar"), + execute: executePlan, + }); if (!results) return; const displayResults = results.map((result) => ({ ...result, @@ -3657,7 +3686,11 @@ async function applyCreateDatabaseAuthorizationPlan() { const status = authorizationPlanStatus(displayResults); if (created) { await connectionStore.ensureVisibleDatabase(node.connectionId, name); - await connectionStore.loadDatabases(node.connectionId, { force: true }); + if (isMongoDatabaseCreation) { + await connectionStore.loadMongoDatabases(node.connectionId); + } else { + await connectionStore.loadDatabases(node.connectionId, { force: true }); + } } toast(t(status === "success" ? "contextMenu.createDatabaseSuccess" : status === "partial" ? "contextMenu.createDatabasePartial" : "contextMenu.createDatabaseFailed", { name }), status === "success" ? 3000 : 5000); } catch (error: any) { diff --git a/apps/desktop/src/lib/sidebar/__tests__/mongoCollectionMutation.spec.ts b/apps/desktop/src/lib/sidebar/__tests__/mongoCollectionMutation.spec.ts index cd501e3f32..dde775fde3 100644 --- a/apps/desktop/src/lib/sidebar/__tests__/mongoCollectionMutation.spec.ts +++ b/apps/desktop/src/lib/sidebar/__tests__/mongoCollectionMutation.spec.ts @@ -8,6 +8,7 @@ import { mongoCollectionKindFromNode, mongoCollectionTableTypeFromNode, mongoCloneCollectionPreview, + mongoCreateDatabasePreview, mongoCreateIndexFormFromRow, mongoCreateIndexRequestFromSpec, mongoCreateIndexPreview, @@ -118,6 +119,10 @@ describe("isProtectedMongoIndex", () => { }); describe("mongo shell previews", () => { + it("shows the initialization collection used to materialize a database", () => { + expect(mongoCreateDatabasePreview('app "primary"')).toBe('db.getSiblingDB("app \\"primary\\"").createCollection("dbx_init");'); + }); + it("preserves identifier whitespace in rename preview", () => { expect(mongoRenameCollectionPreview("app", " users ", " renamed ")).toBe('db.getSiblingDB("app").getCollection(" users ").renameCollection(" renamed ")'); }); diff --git a/apps/desktop/src/lib/sidebar/mongoCollectionMutation.ts b/apps/desktop/src/lib/sidebar/mongoCollectionMutation.ts index 271783d60f..9079158be0 100644 --- a/apps/desktop/src/lib/sidebar/mongoCollectionMutation.ts +++ b/apps/desktop/src/lib/sidebar/mongoCollectionMutation.ts @@ -66,6 +66,11 @@ export function mongoCollectionTableTypeFromNode(node: Pick): return kind === "view" ? "VIEW" : kind === "timeseries" ? "TIMESERIES" : "TABLE"; } +/** MongoDB materializes a database when its initialization collection is created. */ +export function mongoCreateDatabasePreview(database: string): string { + return `db.getSiblingDB(${JSON.stringify(database)}).createCollection("dbx_init");`; +} + export function toMongoCollectionKind(kind?: string | null): MongoCollectionKind { const normalized = (kind || "collection").toLowerCase(); if (normalized === "view") return "view";