feat(sidebar): auto-load all tables per connection when expanded

Closes #9834
This commit is contained in:
t8y2 committed 2026-09-27 09:38:55 +00:00
1 parent 725b1ee252
commit 5ba0d435f0
44 files changed
+332 -20

No files matched your search

+1
View File
@@ -198,6 +198,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
+1
View File
@@ -940,6 +940,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -385,6 +385,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -661,6 +661,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -743,6 +744,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
+1
View File
@@ -1657,6 +1657,7 @@ for line in sys.stdin:
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -1049,6 +1049,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
+24 -8
View File
@@ -6358,22 +6358,26 @@ fn session_scoped_pool_key_for(
/// 两个运行态连接配置是否视为同一连接(用于决定是否销毁连接池)。
///
/// 仅当双方都是 `save_password=false` 时才忽略 `password` 字段的差异:这类连接
/// 在 connect 时运行态配置可能携带会话密码,持久化同步后为空,这种空值差异不应
/// 触发池重建。若任一方 `save_password=true`,密码是真实的连接参数,任何密码变更
/// (包括用户保存了新密码)都必须销毁旧池,否则旧池会继续用旧密码认证。
/// 始终忽略只影响前端导航的表加载策略。仅当双方都是 `save_password=false` 时才忽略
/// `password` 字段的差异:这类连接在 connect 时运行态配置可能携带会话密码,持久化
/// 同步后为空,这种空值差异不应触发池重建。若任一方 `save_password=true`,密码是
/// 真实的连接参数,任何密码变更(包括用户保存了新密码)都必须销毁旧池,否则旧池会
/// 继续用旧密码认证。
pub fn connection_configs_pool_equivalent(a: &ConnectionConfig, b: &ConnectionConfig) -> bool {
if a == b {
return true;
}
let mut a = a.clone();
let mut b = b.clone();
// Sidebar paging is a presentation preference and cannot change an
// established database session.
a.sidebar_auto_load_all_tables = false;
b.sidebar_auto_load_all_tables = false;
if !a.save_password && !b.save_password {
let mut a = a.clone();
a.password.clear();
let mut b = b.clone();
b.password.clear();
return a == b;
}
false
a == b
}
/// Whether transient credentials can safely survive a persisted config update.
@@ -6393,6 +6397,7 @@ pub fn connection_configs_session_credentials_compatible(a: &ConnectionConfig, b
config.visible_databases = None;
config.visible_schemas = None;
config.show_system_schemas = false;
config.sidebar_auto_load_all_tables = false;
config.color = None;
config.docs_notes_path = None;
config.connect_timeout_secs = 0;
@@ -6953,6 +6958,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -7048,6 +7054,16 @@ mod tests {
assert!(connection_configs_pool_equivalent(&a, &c));
}
#[test]
fn connection_configs_pool_equivalent_ignores_sidebar_table_loading_preference() {
let a = mysql_config(None);
let mut b = a.clone();
b.sidebar_auto_load_all_tables = true;
assert!(connection_configs_pool_equivalent(&a, &b));
assert!(connection_configs_pool_equivalent(&b, &a));
}
#[test]
fn connection_configs_pool_equivalent_detects_saved_password_change() {
let mut a = mysql_config(None);
+2
View File
@@ -10855,6 +10855,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -16854,6 +16855,7 @@ SELECT 1 FROM dual"#
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -2480,6 +2480,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -2563,6 +2564,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -2801,6 +2803,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: Some("CREATE SECRET (TYPE quack, TOKEN 'token-value');".to_string()),
color: None,
@@ -10258,6 +10258,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -10332,6 +10333,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
+2
View File
@@ -8060,6 +8060,7 @@ for line in sys.stdin:
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -10901,6 +10902,7 @@ for line in sys.stdin:
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -777,6 +777,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: vec![],
init_script: None,
color: None,
+1
View File
@@ -3349,6 +3349,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,
@@ -162,6 +162,7 @@ mod tests {
visible_database_patterns: None,
visible_schemas: None,
show_system_schemas: false,
sidebar_auto_load_all_tables: false,
attached_databases: Vec::new(),
init_script: None,
color: None,