fix(gaussdb): quote identifiers by compatibility mode

This commit is contained in:
zipg authored and GitHub committed 2026-07-29 23:34:58 +08:00
1 parent d0c3a3fd2e
commit 66f94f23f1
28 files changed
+1207 -134

No files matched your search

@@ -0,0 +1,75 @@
import { createPinia, setActivePinia } from "pinia";
import { beforeEach, describe, expect, it, vi } from "vitest";
import type { ConnectionConfig } from "@/types/database";
function installLocalStorage() {
const data = new Map<string, string>();
vi.stubGlobal("localStorage", {
getItem: vi.fn((key: string) => data.get(key) ?? null),
setItem: vi.fn((key: string, value: string) => data.set(key, value)),
removeItem: vi.fn((key: string) => data.delete(key)),
});
}
function gaussdbConnection(style: "double" | "backtick"): ConnectionConfig {
return {
id: `gaussdb-${style}`,
name: "GaussDB",
db_type: "gaussdb",
host: "127.0.0.1",
port: 5432,
username: "gaussdb",
password: "",
database: "postgres",
external_config: { gaussdbIdentifierQuoteStyle: style },
};
}
describe("connectionStore GaussDB identifier quote override", () => {
beforeEach(() => {
vi.resetModules();
vi.unstubAllGlobals();
installLocalStorage();
setActivePinia(createPinia());
});
it("resolves the persisted compatibility mode before runtime driver metadata", async () => {
const { useConnectionStore } = await import("@/stores/connectionStore");
const store = useConnectionStore();
const double = gaussdbConnection("double");
const backtick = gaussdbConnection("backtick");
store.connections = [double, backtick];
expect(store.connectionIdentifierQuote(double.id)).toBe('"');
expect(store.connectionIdentifierQuote(backtick.id)).toBe("`");
});
it("loads and caches auto compatibility quotes once per connection", async () => {
const config: ConnectionConfig = {
...gaussdbConnection("double"),
id: "gaussdb-auto",
external_config: undefined,
};
const connectionIdentifierQuote = vi.fn().mockResolvedValue("`");
vi.doMock("@/lib/backend/tauriRuntime", () => ({ isTauriRuntime: () => false }));
vi.doMock("@/lib/backend/api", () => ({
connectDb: vi.fn().mockResolvedValue(config.id),
connectionDatabaseInfo: vi.fn().mockRejectedValue(new Error("metadata unavailable")),
connectionIdentifierQuote,
saveConnections: vi.fn().mockResolvedValue(undefined),
saveSidebarLayout: vi.fn().mockResolvedValue(undefined),
}));
const { useConnectionStore } = await import("@/stores/connectionStore");
const store = useConnectionStore();
await store.addConnection(config);
await store.connect(config);
expect(connectionIdentifierQuote).toHaveBeenCalledOnce();
expect(connectionIdentifierQuote).toHaveBeenCalledWith(config.id);
expect(store.connectionIdentifierQuote(config.id)).toBe("`");
expect(store.connectionIdentifierQuote(config.id)).toBe("`");
expect(connectionIdentifierQuote).toHaveBeenCalledOnce();
});
});
+4 -2
View File
@@ -61,7 +61,7 @@ import * as api from "@/lib/backend/api";
import { isTauriRuntime } from "@/lib/backend/tauriRuntime";
import { useTunnelProfileStore } from "@/stores/tunnelProfileStore";
import { connectionIsDorisFamilyCatalogCapable, isInternalDorisCatalog, isSchemaAware, normalizeSidebarObjectKind, sidebarObjectKindsForDatabase, usesTreeSchemaMode } from "@/lib/database/databaseCapabilities";
import { connectionObjectTreeNodeSchema, connectionObjectTreeQuerySchema, connectionShouldDiscoverJdbcSchemas, connectionUsesDatabaseObjectTreeMode, effectiveDatabaseTypeForConnection } from "@/lib/database/jdbcDialect";
import { connectionObjectTreeNodeSchema, connectionObjectTreeQuerySchema, connectionShouldDiscoverJdbcSchemas, connectionShouldLoadIdentifierQuote, connectionUsesDatabaseObjectTreeMode, effectiveDatabaseTypeForConnection, gaussdbIdentifierQuoteOverride } from "@/lib/database/jdbcDialect";
import { buildDatabaseTreeNodes, buildDuckDbConnectionTreeNodes, compareSidebarNames, sortSidebarDatabases, sortSidebarNames, shouldIncludeDefaultDatabaseNode } from "@/lib/database/databaseTree";
import { buildSqlServerDatabaseTreeNodes } from "@/lib/database/sqlServerTree";
import { collapseExpandedTreeNodes } from "@/lib/sidebar/sidebarTreeCollapse";
@@ -499,6 +499,8 @@ export const useConnectionStore = defineStore("connection", () => {
function connectionIdentifierQuote(connectionId?: string): string | undefined {
if (!connectionId) return undefined;
const override = gaussdbIdentifierQuoteOverride(getConfig(connectionId));
if (override != null) return override;
return identifierQuotes.value[connectionId];
}
@@ -511,7 +513,7 @@ export const useConnectionStore = defineStore("connection", () => {
async function refreshConnectionIdentifierQuote(connectionId: string, config: ConnectionConfig) {
clearConnectionIdentifierQuote(connectionId);
if (config.db_type !== "kingbase") return;
if (!connectionShouldLoadIdentifierQuote(config)) return;
const quote = await api.connectionIdentifierQuote(connectionId).catch(() => undefined);
if (quote != null) identifierQuotes.value = { ...identifierQuotes.value, [connectionId]: quote };
}