fix(gaussdb): quote identifiers by compatibility mode

This commit is contained in:
zipg authored and GitHub committed 2026-07-29 23:34:58 +08:00
1 parent d0c3a3fd2e
commit 66f94f23f1
28 files changed
+1207 -134

No files matched your search

+93
View File
@@ -26,12 +26,39 @@ fn quotes_identifiers_by_database_type() {
assert_eq!(quote_table_identifier(Some(DatabaseType::Kingbase), "order"), "\"order\"");
assert_eq!(quote_table_identifier(Some(DatabaseType::Kingbase), "MixedCase"), "\"MixedCase\"");
assert_eq!(quote_table_identifier(Some(DatabaseType::Kingbase), "order detail"), "\"order detail\"");
assert_eq!(quote_table_identifier(Some(DatabaseType::Gaussdb), "\"MixedCase\""), "\"MixedCase\"");
assert_eq!(quote_table_identifier(Some(DatabaseType::OpenGauss), "\"MixedCase\""), "\"MixedCase\"");
assert_eq!(quote_table_identifier(Some(DatabaseType::Informix), "users_1"), "users_1");
assert_eq!(quote_table_identifier(Some(DatabaseType::Jdbc), "users_1"), "users_1");
assert_eq!(quote_table_identifier(Some(DatabaseType::Jdbc), "user name"), "user name");
assert_eq!(quote_table_identifier(Some(DatabaseType::Iotdb), "root.test.device2"), "root.test.device2");
}
#[test]
fn quotes_gaussdb_jdbc_identifiers_selectively() {
for (name, expected) in [
("schema_01", "schema_01"),
("MixedCase", "\"MixedCase\""),
("order", "\"order\""),
("order detail", "\"order detail\""),
("already\"quoted", "\"already\"\"quoted\""),
("\"AlreadyQuoted\"", "\"AlreadyQuoted\""),
] {
assert_eq!(quote_table_data_identifier(Some(DatabaseType::Gaussdb), name, Some("\"")), expected);
}
for (name, expected) in [
("schema_01", "schema_01"),
("MixedCase", "`MixedCase`"),
("order", "`order`"),
("order detail", "`order detail`"),
("already`quoted", "`already``quoted`"),
("`AlreadyQuoted`", "`AlreadyQuoted`"),
] {
assert_eq!(quote_table_data_identifier(Some(DatabaseType::Gaussdb), name, Some("`")), expected);
}
}
#[test]
fn qualifies_schema_only_for_schema_aware_databases() {
assert_eq!(qualified_table_name(Some(DatabaseType::Postgres), Some("public"), "users"), "\"public\".\"users\"");
@@ -342,6 +369,72 @@ fn builds_table_data_where_and_schema_queries() {
}),
"SELECT * FROM \"App Schema\".\"ANALYZE\" LIMIT 100;"
);
assert_eq!(
build_table_data_select_sql(TableDataSelectSqlOptions {
database_type: Some(DatabaseType::Gaussdb),
identifier_quote: Some("\"".to_string()),
schema: Some("schema_01".to_string()),
table_name: "table_01".to_string(),
limit: Some(100),
..Default::default()
}),
"SELECT * FROM schema_01.table_01 LIMIT 100;"
);
assert_eq!(
build_table_data_select_sql(TableDataSelectSqlOptions {
database_type: Some(DatabaseType::Gaussdb),
identifier_quote: Some("`".to_string()),
schema: Some("App Schema".to_string()),
table_name: "order".to_string(),
limit: Some(100),
..Default::default()
}),
"SELECT * FROM `App Schema`.`order` LIMIT 100;"
);
for database_type in [DatabaseType::Postgres, DatabaseType::OpenGauss] {
assert_eq!(
build_table_data_select_sql(TableDataSelectSqlOptions {
database_type: Some(database_type),
identifier_quote: Some("`".to_string()),
schema: Some("App Schema".to_string()),
table_name: "order".to_string(),
limit: Some(100),
..Default::default()
}),
"SELECT * FROM `App Schema`.`order` LIMIT 100;"
);
assert_eq!(
build_table_data_select_sql(TableDataSelectSqlOptions {
database_type: Some(database_type),
identifier_quote: Some("\"".to_string()),
schema: Some("schema_01".to_string()),
table_name: "MixedCase".to_string(),
limit: Some(100),
..Default::default()
}),
"SELECT * FROM schema_01.\"MixedCase\" LIMIT 100;"
);
}
assert_eq!(
build_table_data_select_sql(TableDataSelectSqlOptions {
database_type: Some(DatabaseType::Gaussdb),
schema: Some("schema_01".to_string()),
table_name: "table_01".to_string(),
limit: Some(100),
..Default::default()
}),
"SELECT * FROM \"schema_01\".\"table_01\" LIMIT 100;"
);
assert_eq!(
build_table_data_select_sql(TableDataSelectSqlOptions {
database_type: Some(DatabaseType::OpenGauss),
schema: Some("schema_01".to_string()),
table_name: "table_01".to_string(),
limit: Some(100),
..Default::default()
}),
"SELECT * FROM \"schema_01\".\"table_01\" LIMIT 100;"
);
assert_eq!(
build_table_data_select_sql(TableDataSelectSqlOptions {
database_type: Some(DatabaseType::Xugu),