github/dbx
4
0 Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-11-15 14:52:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): ignore formatter parse errors for incomplete SQL

Browse Source 
Closes #5462
This commit is contained in:
t8y2 committed 2026-08-06 22:41:42 +08:00
1 parent 48e5ef331a
commit 670ddcfcb3
3 files changed
+31 -3
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

apps/desktop/src/lib/__tests__/sql/sqlFormatter.spec.ts
Vendored
+14 -1
View File
@@ -1,5 +1,5 @@
import { describe, expect, it } from "vitest";
import { formatSqlForDisplay, formatSqlText, MAX_SQL_FORMAT_CHARS, sqlFormatDialectForDbType, UnsupportedStructuredInputError } from "@/lib/sql/sqlFormatter";
import { formatSqlForDisplay, formatSqlForEditing, formatSqlText, MAX_SQL_FORMAT_CHARS, sqlFormatDialectForDbType, UnsupportedStructuredInputError } from "@/lib/sql/sqlFormatter";
describe("sqlFormatter", () => {
it("maps PostgreSQL-compatible database types to the postgres formatter dialect", () => {
@@ -50,6 +50,19 @@ describe("sqlFormatter", () => {
expect(formatted).toContain("AS id");
});
it("keeps incomplete editor SQL unchanged when the formatter cannot parse it", async () => {
const sql = "select *\nfrom dbname.\n;";
await expect(formatSqlText(sql, "mysql")).rejects.toThrow("Parse error at token:");
await expect(formatSqlForEditing(sql, "mysql")).resolves.toBe(sql);
});
it("keeps non-parse editor formatting failures visible", async () => {
const oversizedSql = "x".repeat(MAX_SQL_FORMAT_CHARS + 1);
await expect(formatSqlForEditing(oversizedSql, "mysql")).rejects.toThrow("SQL is too large to format safely.");
});
it("returns the original SQL for display when formatting fails", async () => {
const oversizedSql = "x".repeat(MAX_SQL_FORMAT_CHARS + 1);