fix(saphana): keep DO blocks together

This commit is contained in:
t8y2 committed 2026-07-07 13:23:53 +08:00
1 parent f41c7dd6a0
commit 6e7f0578b6
3 files changed
+223 -3

No files matched your search

@@ -85,6 +85,12 @@ BEGIN
END;
SELECT 2;`;
const sapHanaDoBlockFixture = `DO
BEGIN
SELECT 1 AS "Result" FROM DUMMY;
END;
SELECT 2 FROM DUMMY;`;
describe("splitSqlStatementRanges", () => {
it("splits multiple top-level statements", () => {
const sql = "SELECT 1;\nSELECT 2;\nSELECT 3;";
@@ -177,6 +183,14 @@ describe("splitSqlStatementRanges", () => {
expect(ranges[0].sql).toContain("END;");
expect(ranges[0].sql).not.toContain("\n/");
});
it("keeps SAP HANA DO blocks together", () => {
const ranges = splitSqlStatementRanges(sapHanaDoBlockFixture, "saphana");
expect(rangeSqlTexts(ranges)).toEqual([sapHanaDoBlockFixture.slice(0, sapHanaDoBlockFixture.indexOf("\nSELECT 2")), "SELECT 2 FROM DUMMY"]);
expect(ranges[0].sql).toContain('SELECT 1 AS "Result" FROM DUMMY;');
expect(ranges[0].sql).toContain("END;");
});
});
describe("statementRangeAtCursor", () => {
@@ -423,6 +437,12 @@ WHERE request_json LIKE '%"paperFlag":null%';`;
const range = statementRangeAtCursor(oraclePlSqlFixture, indexOf(oraclePlSqlFixture, "ORDERS_10K", 2), "oracle");
expect(range?.sql.trim()).toBe(oraclePlSqlFixture.slice(0, oraclePlSqlFixture.indexOf("\n/")));
});
it("returns the full SAP HANA DO block for cursors inside nested statements", () => {
const range = statementRangeAtCursor(sapHanaDoBlockFixture, indexOf(sapHanaDoBlockFixture, "Result"), "saphana");
expect(range?.sql.trim()).toBe(sapHanaDoBlockFixture.slice(0, sapHanaDoBlockFixture.indexOf("\nSELECT 2")));
});
});
describe("executableStatementRanges", () => {
@@ -465,6 +485,10 @@ describe("executableStatementRanges", () => {
expect(rangeSqlTexts(executableStatementRanges(mysqlRoutineWithLoopsFixture, "mysql"))).toEqual([mysqlRoutineWithLoopsFixture.slice(0, mysqlRoutineWithLoopsFixture.indexOf("\nSELECT 2;")).replace(/;$/, "").trim(), "SELECT 2"]);
});
it("does not split executable SAP HANA DO ranges at inner statements", () => {
expect(rangeSqlTexts(executableStatementRanges(sapHanaDoBlockFixture, "saphana"))).toEqual([sapHanaDoBlockFixture.slice(0, sapHanaDoBlockFixture.indexOf("\nSELECT 2")), "SELECT 2 FROM DUMMY"]);
});
it("returns executable SQL Server batches without GO delimiter lines", () => {
expect(rangeSqlTexts(executableStatementRanges("SELECT 1\nGO\nSELECT 2;", "sqlserver"))).toEqual(["SELECT 1", "SELECT 2"]);
});