feat(execution): multi-database SQL execution with scoped targets
This commit is contained in:
1 parent
328a2aa107
commit
71ccb3d97d
46 files changed
+4421
-182
No files matched your search
@@ -2,7 +2,17 @@ import { describe, expect, it } from "vitest";
|
||||
import { connectionNamespaceCreationTarget, databaseNodeNamespaceCreationTarget } from "@/lib/database/databaseNamespaceCreation";
|
||||
import { editableDatabasePropertyGroups, editableSchemaPropertyGroups } from "@/lib/database/databasePropertyEditing";
|
||||
import { buildGetDatabaseCommentSql } from "@/lib/database/dbAdminSql";
|
||||
import { isSchemaAware, supportsDatabaseNameCompletion, supportsDatabaseSchemaQualifier, supportsSqlInListPaste, supportsTableImport, supportsTransaction } from "@/lib/database/databaseFeatureSupport";
|
||||
import {
|
||||
isSchemaAware,
|
||||
supportsConnectionScopedQueryExecution,
|
||||
supportsDatabaseNameCompletion,
|
||||
supportsDatabaseSchemaQualifier,
|
||||
supportsQueryTargetDatabaseListing,
|
||||
supportsSqlInListPaste,
|
||||
supportsTableImport,
|
||||
supportsTransaction,
|
||||
usesConnectionOnlyQueryTarget,
|
||||
} from "@/lib/database/databaseFeatureSupport";
|
||||
|
||||
describe("schema awareness", () => {
|
||||
it("keeps SQLite database aliases separate from schema-capable databases", () => {
|
||||
@@ -10,6 +20,21 @@ describe("schema awareness", () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe("connection-scoped query targets", () => {
|
||||
it("keeps connection-only target types separate from unregistered namespace targets", () => {
|
||||
expect(usesConnectionOnlyQueryTarget("etcd")).toBe(true);
|
||||
expect(usesConnectionOnlyQueryTarget("zookeeper")).toBe(true);
|
||||
expect(usesConnectionOnlyQueryTarget("elasticsearch")).toBe(true);
|
||||
expect(supportsConnectionScopedQueryExecution("elasticsearch")).toBe(true);
|
||||
expect(supportsQueryTargetDatabaseListing("elasticsearch")).toBe(false);
|
||||
expect(usesConnectionOnlyQueryTarget("qdrant")).toBe(true);
|
||||
expect(usesConnectionOnlyQueryTarget("milvus")).toBe(true);
|
||||
expect(usesConnectionOnlyQueryTarget("weaviate")).toBe(true);
|
||||
expect(usesConnectionOnlyQueryTarget("chromadb")).toBe(true);
|
||||
expect(supportsQueryTargetDatabaseListing("etcd")).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe("database and schema qualifiers", () => {
|
||||
it.each(["sqlserver", "trino", "prestosql"] as const)("supports three-part object names for %s", (databaseType) => {
|
||||
expect(supportsDatabaseSchemaQualifier(databaseType)).toBe(true);
|
||||
|
||||
+123
@@ -0,0 +1,123 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import type { ConnectionConfig } from "@/types/database";
|
||||
import { manifestDatabaseTypes, supportsDatabaseFeature } from "@/lib/database/databaseDriverManifest";
|
||||
import {
|
||||
normalizeSqlExecutionTarget,
|
||||
sqlExecutionTargetCapabilities,
|
||||
targetAllowsEmptyDatabase,
|
||||
targetCanUseDefaultWhenDatabaseListEmpty,
|
||||
targetDefaultDatabase,
|
||||
targetIsSingleDatabase,
|
||||
targetSupportsSchema,
|
||||
targetUsesConnectionOnlyScope,
|
||||
targetUsesNamespaceScope,
|
||||
} from "@/lib/database/sqlExecutionTargetCapabilities";
|
||||
import { normalizeSqlExecutionTargetContext, resolveSqlExecutionTargetProvider } from "@/lib/database/sqlExecutionTargetRegistry";
|
||||
|
||||
function connection(overrides: Partial<ConnectionConfig>): ConnectionConfig {
|
||||
return {
|
||||
id: "connection-1",
|
||||
name: "Test connection",
|
||||
db_type: "mysql",
|
||||
host: "localhost",
|
||||
port: 3306,
|
||||
username: "user",
|
||||
password: "",
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
describe("sql execution target capabilities", () => {
|
||||
it("exposes a target capability for every manifest database type with query execution", () => {
|
||||
for (const dbType of manifestDatabaseTypes()) {
|
||||
if (!supportsDatabaseFeature(dbType, "queryExecution")) continue;
|
||||
expect(sqlExecutionTargetCapabilities(connection({ db_type: dbType })), dbType).toBeDefined();
|
||||
}
|
||||
});
|
||||
|
||||
it("models connection-only query targets without database or schema", () => {
|
||||
const config = connection({ db_type: "etcd" });
|
||||
const capabilities = sqlExecutionTargetCapabilities(config);
|
||||
|
||||
expect(capabilities?.scope).toBe("connection");
|
||||
expect(capabilities?.supportsDatabase).toBe(false);
|
||||
expect(capabilities?.supportsSchema).toBe(false);
|
||||
expect(targetUsesConnectionOnlyScope(config)).toBe(true);
|
||||
expect(targetAllowsEmptyDatabase(config)).toBe(true);
|
||||
expect(normalizeSqlExecutionTarget(config, { connectionId: config.id, database: "stale", catalog: "old", schema: "old" })).toEqual({
|
||||
connectionId: config.id,
|
||||
database: "",
|
||||
});
|
||||
});
|
||||
|
||||
it("models document and vector query targets as connection-only until a namespace provider exists", () => {
|
||||
const config = connection({ db_type: "qdrant" });
|
||||
const capabilities = sqlExecutionTargetCapabilities(config);
|
||||
|
||||
expect(capabilities?.scope).toBe("connection");
|
||||
expect(capabilities?.supportsDatabase).toBe(false);
|
||||
expect(capabilities?.supportsSchema).toBe(false);
|
||||
expect(targetUsesNamespaceScope(config)).toBe(false);
|
||||
expect(targetUsesConnectionOnlyScope(config)).toBe(true);
|
||||
expect(normalizeSqlExecutionTarget(config, { connectionId: config.id, database: "collection", schema: "stale" })).toEqual({
|
||||
connectionId: config.id,
|
||||
database: "",
|
||||
});
|
||||
});
|
||||
|
||||
it("uses the registered VictoriaMetrics default without treating arbitrary names as valid", () => {
|
||||
const config = connection({ db_type: "victoriametrics", database: undefined });
|
||||
const capabilities = sqlExecutionTargetCapabilities(config);
|
||||
|
||||
expect(capabilities?.defaultDatabase).toBe("metrics");
|
||||
expect(targetDefaultDatabase(config)).toBe("metrics");
|
||||
expect(targetCanUseDefaultWhenDatabaseListEmpty(config)).toBe(true);
|
||||
expect(targetIsSingleDatabase(config)).toBe(true);
|
||||
expect(targetAllowsEmptyDatabase(config)).toBe(true);
|
||||
});
|
||||
|
||||
it("uses the effective JDBC dialect for target semantics", () => {
|
||||
const oracle = connection({ db_type: "jdbc", connection_string: "jdbc:oracle:thin:@localhost:1521/XEPDB1" });
|
||||
const postgres = connection({ db_type: "jdbc", connection_string: "jdbc:postgresql://localhost:5432/app" });
|
||||
|
||||
expect(sqlExecutionTargetCapabilities(oracle)?.databaseType).toBe("oracle");
|
||||
expect(targetIsSingleDatabase(oracle)).toBe(true);
|
||||
expect(targetSupportsSchema(oracle)).toBe(true);
|
||||
expect(sqlExecutionTargetCapabilities(postgres)?.databaseType).toBe("postgres");
|
||||
expect(targetIsSingleDatabase(postgres)).toBe(false);
|
||||
expect(targetSupportsSchema(postgres)).toBe(true);
|
||||
});
|
||||
|
||||
it("prefers a configured PostgreSQL database for the stable default", () => {
|
||||
const config = connection({ db_type: "postgres", database: "app" });
|
||||
|
||||
expect(targetDefaultDatabase(config)).toBe("app");
|
||||
expect(targetCanUseDefaultWhenDatabaseListEmpty(config)).toBe(true);
|
||||
expect(sqlExecutionTargetCapabilities(config)?.provider.id).toBe("builtin:database");
|
||||
});
|
||||
|
||||
it("maps every built-in target scope through the shared provider contract", () => {
|
||||
const databaseProvider = resolveSqlExecutionTargetProvider("database");
|
||||
const connectionProvider = resolveSqlExecutionTargetProvider("connection");
|
||||
const config = connection({ id: "conn-1", db_type: "postgres" });
|
||||
|
||||
expect(databaseProvider.toExecutionContext({ connectionId: "conn-1", database: "app", schema: "public" }, config)).toEqual({
|
||||
scope: "database",
|
||||
database: "app",
|
||||
schema: "public",
|
||||
});
|
||||
expect(connectionProvider.toExecutionContext({ connectionId: "conn-1", database: "" }, config)).toEqual({ scope: "connection" });
|
||||
expect(normalizeSqlExecutionTargetContext({ scope: "connection", database: "stale", schema: "stale", catalog: "stale" })).toEqual({ scope: "connection" });
|
||||
});
|
||||
|
||||
it("rejects stale namespace fields on a connection-scoped target", () => {
|
||||
const config = connection({ id: "conn-1", db_type: "etcd" });
|
||||
const provider = sqlExecutionTargetCapabilities(config)!.provider;
|
||||
|
||||
expect(() => provider.validateTarget({ connectionId: "conn-1", database: "old", schema: "old" }, config)).toThrow();
|
||||
});
|
||||
|
||||
it("does not expose targets for connections without query execution capability", () => {
|
||||
expect(sqlExecutionTargetCapabilities(connection({ db_type: "mq" }))).toBeUndefined();
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user