feat(ddl): formatted DDL display with dialog or tab mode
This commit is contained in:
1 parent
86bdf9f78a
commit
76e41a6a4d
30 files changed
+956
-51
No files matched your search
@@ -33,6 +33,7 @@ function makeSettings(overrides: Partial<EditorSettings> = {}): EditorSettings {
|
||||
continueOnErrorOnBatch: false,
|
||||
confirmUnsavedSqlClose: true,
|
||||
savedSqlOpenTargetMode: "saved",
|
||||
ddlOpenMode: "dialog",
|
||||
objectBrowserViewMode: "list",
|
||||
sqlVariableSubstitutionEnabled: true,
|
||||
sqlVariableSyntaxOverrides: {},
|
||||
@@ -51,6 +52,10 @@ describe("EDITOR_SETTINGS_DRAFT_KEYS", () => {
|
||||
expect(EDITOR_SETTINGS_DRAFT_KEYS).toContain("showLineNumbers");
|
||||
});
|
||||
|
||||
it("includes the DDL open mode", () => {
|
||||
expect(EDITOR_SETTINGS_DRAFT_KEYS).toContain("ddlOpenMode");
|
||||
});
|
||||
|
||||
it("includes continueOnErrorOnBatch", () => {
|
||||
expect(EDITOR_SETTINGS_DRAFT_KEYS).toContain("continueOnErrorOnBatch");
|
||||
});
|
||||
@@ -416,6 +421,19 @@ describe("editorSettingsDraftFromSettings - tabLayout", () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe("editorSettingsDraftFromSettings - ddlOpenMode", () => {
|
||||
it("maps and tracks the selected DDL open mode", () => {
|
||||
const settings = makeSettings({ ddlOpenMode: "dialog" });
|
||||
const draft = editorSettingsDraftFromSettings(settings);
|
||||
const base = editorSettingsDraftFromSettings(settings);
|
||||
|
||||
expect(draft.ddlOpenMode).toBe("dialog");
|
||||
draft.ddlOpenMode = "tab";
|
||||
expect(editorSettingsDraftChanged(draft, base)).toBe(true);
|
||||
expect(editorSettingsPatchFromDraft(draft, base)).toEqual({ ddlOpenMode: "tab" });
|
||||
});
|
||||
});
|
||||
|
||||
describe("editorSettingsDraftChanged - tabLayout", () => {
|
||||
it("detects change in tabLayout", () => {
|
||||
const settings = makeSettings({ tabLayout: "scroll" });
|
||||
|
||||
@@ -195,6 +195,7 @@ describe("settingsTransfer", () => {
|
||||
for (const key of EDITOR_SETTINGS_DRAFT_KEYS) {
|
||||
expect(transferCategoryForKey(key), key).toBeDefined();
|
||||
}
|
||||
expect(transferCategoryForKey("ddlOpenMode")).toBe("editor");
|
||||
expect(transferCategoryForKey("notARealSetting")).toBeUndefined();
|
||||
});
|
||||
|
||||
|
||||
@@ -31,6 +31,7 @@ export const EDITOR_SETTINGS_DRAFT_KEYS = [
|
||||
"selectFirstCompletionOnOpen",
|
||||
"wordWrap",
|
||||
"showWhitespace",
|
||||
"ddlOpenMode",
|
||||
"vimModeEnabled",
|
||||
"autoCloseBrackets",
|
||||
"sqlSemanticDiagnosticsMode",
|
||||
|
||||
@@ -102,6 +102,7 @@ const SETTINGS_TRANSFER_CATEGORY_KEYS: Record<SettingsTransferCategoryId, readon
|
||||
"generateSqlIncludeDatabaseName",
|
||||
"generateSqlQuoteIdentifiers",
|
||||
"formatSqlOnSqlFileSave",
|
||||
"ddlOpenMode",
|
||||
"showTableDdlHoverPreview",
|
||||
"tableHoverLookupMode",
|
||||
"sqlVariableSubstitutionEnabled",
|
||||
|
||||
Reference in new issue
Block a user