fix(query): default query tabs to auto-commit

This commit is contained in:
t8y2 committed 2026-08-24 15:01:55 +08:00
1 parent c021fe009b
commit 781cf01c78
4 files changed
+12 -15

No files matched your search

@@ -115,11 +115,8 @@ describe("supportsTransaction", () => {
});
describe("defaultAutoCommitForDbType", () => {
it("defaults Oracle query tabs to manual transactions", () => {
expect(defaultAutoCommitForDbType("oracle")).toBe(false);
});
it("defaults other databases to auto-commit", () => {
it("defaults query tabs to auto-commit", () => {
expect(defaultAutoCommitForDbType("oracle")).toBe(true);
expect(defaultAutoCommitForDbType("mysql")).toBe(true);
expect(defaultAutoCommitForDbType("postgres")).toBe(true);
expect(defaultAutoCommitForDbType("dameng")).toBe(true);
@@ -250,8 +250,8 @@ export function supportsTransaction(dbType?: string): boolean {
/**
* Default auto-commit mode when opening a query tab for the given database type.
* Oracle defaults to manual transactions so edits require an explicit Commit.
* Query tabs default to auto-commit; users can explicitly switch to manual transactions.
*/
export function defaultAutoCommitForDbType(dbType?: string): boolean {
return dbType !== "oracle";
export function defaultAutoCommitForDbType(_dbType?: string): boolean {
return true;
}