fix(connection): invalidate data-tab metadata on disconnect/reconnect

This commit is contained in:
jearhe authored and GitHub committed 2026-08-20 09:25:14 +08:00
1 parent b537c4b891
commit 78aab1e5ed
15 files changed
+804 -31

No files matched your search

@@ -1,5 +1,5 @@
import { describe, expect, it } from "vitest";
import { canApplyDataTabMetadata, dataTabMetadataNeedsRefresh, dataTabOpenModeFromTreeClick, findExistingDataTabCandidate } from "@/lib/sidebar/dataTabOpenPolicy";
import { canApplyDataTabMetadata, dataTabMetadataNeedsRefresh, dataTabOpenModeFromTreeClick, findExistingDataTabCandidate, isDataTabMetadataLifecycleStale } from "@/lib/sidebar/dataTabOpenPolicy";
import type { QueryTab } from "@/types/database";
function click(modifiers: Partial<Pick<MouseEvent, "metaKey" | "ctrlKey" | "altKey" | "shiftKey">> = {}) {
@@ -166,4 +166,22 @@ describe("dataTabOpenPolicy", () => {
tab.tableMetaUpdatedAt = now - ttl;
expect(dataTabMetadataNeedsRefresh(tab, ttl, now)).toBe(true);
});
it("treats missing freshness or a generation mismatch as lifecycle-stale", () => {
const tab = dataTab("users", "users");
tab.tableMeta = {
schema: "public",
tableName: "users",
columns: [{ name: "id", data_type: "integer", is_nullable: false, column_default: null, is_primary_key: true, extra: null }],
primaryKeys: ["id"],
};
tab.tableMetaUpdatedAt = Date.now();
tab.tableMetaGeneration = 0;
expect(isDataTabMetadataLifecycleStale(tab, 0)).toBe(false);
expect(isDataTabMetadataLifecycleStale(tab, 1)).toBe(true);
tab.tableMetaUpdatedAt = undefined;
expect(isDataTabMetadataLifecycleStale(tab, 0)).toBe(true);
});
});
@@ -5,7 +5,10 @@ import type { QueryTab, TreeNodeType } from "@/types/database";
export type DataTabOpenMode = "default" | "new-tab";
export type { DataTabReuseMode };
type DataTabLike = Pick<QueryTab, "id" | "mode" | "connectionId" | "database" | "catalog" | "schema" | "title" | "tableMeta" | "tableMetaUpdatedAt" | "pinned" | "isExecuting" | "isCancelling" | "isExplaining" | "txnSessionId" | "pendingDataChangeCount" | "hasPendingDataEditorDraft">;
type DataTabLike = Pick<
QueryTab,
"id" | "mode" | "connectionId" | "database" | "catalog" | "schema" | "title" | "tableMeta" | "tableMetaUpdatedAt" | "tableMetaGeneration" | "pinned" | "isExecuting" | "isCancelling" | "isExplaining" | "txnSessionId" | "pendingDataChangeCount" | "hasPendingDataEditorDraft"
>;
export interface DataTabTarget {
connectionId: string;
@@ -57,6 +60,16 @@ export function dataTabMetadataNeedsRefresh(tab: DataTabLike, maxAgeMs: number,
return now - tab.tableMetaUpdatedAt >= maxAgeMs;
}
/**
* Connection-lifetime freshness: a data tab is cold when it has no freshness
* stamp or its recorded generation no longer matches the current
* connection/database generation. TTL only applies inside the same generation.
* Missing columns remain a separate cold-cache case handled by callers.
*/
export function isDataTabMetadataLifecycleStale(tab: Pick<DataTabLike, "tableMetaUpdatedAt" | "tableMetaGeneration">, currentGeneration: number): boolean {
return tab.tableMetaUpdatedAt === undefined || (tab.tableMetaGeneration ?? -1) !== currentGeneration;
}
export function findExistingDataTabCandidate<T extends DataTabLike>(tabs: T[], target: DataTabTarget, options: { openMode: DataTabOpenMode; reuseMode: DataTabReuseMode; activeTabId?: string | null }): ExistingDataTabCandidate<T> | undefined {
if (options.openMode === "new-tab" || options.reuseMode === "always-new") return undefined;