feat(backup): support table filters and MySQL compatibility
This commit is contained in:
1 parent
09c3f7f44c
commit
7abac0959f
15 files changed
+386
-32
No files matched your search
+81
-1
@@ -1,6 +1,19 @@
|
||||
import assert from "node:assert/strict";
|
||||
import { test } from "vitest";
|
||||
import { databaseBackupFilePath, databaseBackupRunsToPrune, databaseBackupScheduleIsDue, nextDatabaseBackupRunAt, normalizeDatabaseBackupSchedule, resolveScheduledDatabaseBackupTargets, supportsScheduledDatabaseBackup, type DatabaseBackupRun, type DatabaseBackupSchedule } from "../../apps/desktop/src/lib/backup/scheduledDatabaseBackup.ts";
|
||||
import {
|
||||
databaseBackupFilePath,
|
||||
databaseBackupRunsToPrune,
|
||||
databaseBackupScheduleIsDue,
|
||||
databaseBackupTableNamesAreCaseSensitive,
|
||||
nextDatabaseBackupRunAt,
|
||||
normalizeDatabaseBackupSchedule,
|
||||
normalizeDatabaseBackupTablePatterns,
|
||||
resolveScheduledDatabaseBackupTableScope,
|
||||
resolveScheduledDatabaseBackupTargets,
|
||||
supportsScheduledDatabaseBackup,
|
||||
type DatabaseBackupRun,
|
||||
type DatabaseBackupSchedule,
|
||||
} from "../../apps/desktop/src/lib/backup/scheduledDatabaseBackup.ts";
|
||||
|
||||
function schedule(overrides: Partial<DatabaseBackupSchedule> = {}): DatabaseBackupSchedule {
|
||||
return {
|
||||
@@ -9,6 +22,8 @@ function schedule(overrides: Partial<DatabaseBackupSchedule> = {}): DatabaseBack
|
||||
enabled: true,
|
||||
connectionId: "connection-1",
|
||||
databases: [],
|
||||
tableFilterMode: "all",
|
||||
tablePatterns: [],
|
||||
destinationDirectory: "C:\\backups",
|
||||
frequency: "daily",
|
||||
intervalHours: 6,
|
||||
@@ -78,6 +93,21 @@ test("normalization deduplicates databases and bounds schedule values", () => {
|
||||
assert.equal(normalized.timeOfDay, "02:00");
|
||||
});
|
||||
|
||||
test("normalization migrates old schedules and deduplicates table patterns", () => {
|
||||
const legacy = { ...schedule(), tableFilterMode: undefined, tablePatterns: undefined };
|
||||
const normalizedLegacy = normalizeDatabaseBackupSchedule(legacy);
|
||||
const normalizedFiltered = normalizeDatabaseBackupSchedule({
|
||||
...schedule(),
|
||||
tableFilterMode: "exclude",
|
||||
tablePatterns: [" audit_* ", "audit_*", "public.events"],
|
||||
});
|
||||
|
||||
assert.equal(normalizedLegacy?.tableFilterMode, "all");
|
||||
assert.deepEqual(normalizedLegacy?.tablePatterns, []);
|
||||
assert.equal(normalizedFiltered?.tableFilterMode, "exclude");
|
||||
assert.deepEqual(normalizedFiltered?.tablePatterns, ["audit_*", "public.events"]);
|
||||
});
|
||||
|
||||
test("due check respects enabled state and next run", () => {
|
||||
const now = new Date("2026-07-16T12:00:00.000Z");
|
||||
assert.equal(databaseBackupScheduleIsDue(schedule({ nextRunAt: "2026-07-16T11:59:00.000Z" }), now), true);
|
||||
@@ -103,6 +133,18 @@ test("all-database backups use the complete database list", () => {
|
||||
assert.deepEqual(resolveScheduledDatabaseBackupTargets([], ["visible", "hidden"]), ["visible", "hidden"]);
|
||||
});
|
||||
|
||||
test("all-database MySQL backups exclude system databases", () => {
|
||||
assert.deepEqual(resolveScheduledDatabaseBackupTargets([], ["information_schema", "app", "mysql", "analytics", "performance_schema", "sys"], "mysql"), ["app", "analytics"]);
|
||||
});
|
||||
|
||||
test("all-database PostgreSQL backups exclude template databases", () => {
|
||||
assert.deepEqual(resolveScheduledDatabaseBackupTargets([], ["template0", "postgres", "template1", "app"], "postgres"), ["postgres", "app"]);
|
||||
});
|
||||
|
||||
test("explicit system database targets remain available", () => {
|
||||
assert.deepEqual(resolveScheduledDatabaseBackupTargets(["mysql"], ["mysql", "app"], "mysql"), ["mysql"]);
|
||||
});
|
||||
|
||||
test("explicit backup databases fail when any configured target is missing", () => {
|
||||
assert.throws(() => resolveScheduledDatabaseBackupTargets(["app", "renamed"], ["app"]), /renamed/);
|
||||
});
|
||||
@@ -114,6 +156,44 @@ test("scheduled backups are limited to databases with consistent snapshot suppor
|
||||
assert.equal(supportsScheduledDatabaseBackup("sqlserver"), false);
|
||||
});
|
||||
|
||||
test("table pattern input supports exact, wildcard, and qualified rules", () => {
|
||||
assert.deepEqual(normalizeDatabaseBackupTablePatterns(" orders, audit_*; public.events\norders "), ["orders", "audit_*", "public.events"]);
|
||||
|
||||
const included = resolveScheduledDatabaseBackupTableScope("include", ["orders", "audit_*", "public.events"], ["orders", "audit_log", "events", "users"], "app", "public");
|
||||
assert.deepEqual(included, {
|
||||
includedTables: ["orders", "audit_log", "events"],
|
||||
selectedTables: ["orders", "audit_log", "events"],
|
||||
});
|
||||
});
|
||||
|
||||
test("exclude table rules preserve all non-matching tables", () => {
|
||||
const excluded = resolveScheduledDatabaseBackupTableScope("exclude", ["audit_*", "private.*"], ["users", "audit_log", "sessions"], "app", "public");
|
||||
assert.deepEqual(excluded, {
|
||||
includedTables: ["users", "sessions"],
|
||||
excludedTables: ["audit_log"],
|
||||
});
|
||||
});
|
||||
|
||||
test("MySQL table rules respect lower_case_table_names", () => {
|
||||
assert.equal(databaseBackupTableNamesAreCaseSensitive("mysql", 0), true);
|
||||
assert.equal(databaseBackupTableNamesAreCaseSensitive("mysql", "1"), false);
|
||||
assert.equal(databaseBackupTableNamesAreCaseSensitive("mysql", 2), false);
|
||||
assert.equal(databaseBackupTableNamesAreCaseSensitive("postgres", 1), true);
|
||||
assert.equal(databaseBackupTableNamesAreCaseSensitive("mysql", undefined), true);
|
||||
|
||||
const caseSensitive = resolveScheduledDatabaseBackupTableScope("exclude", ["orders"], ["orders", "Orders"], "app", "app", true);
|
||||
assert.deepEqual(caseSensitive, {
|
||||
includedTables: ["Orders"],
|
||||
excludedTables: ["orders"],
|
||||
});
|
||||
|
||||
const caseInsensitive = resolveScheduledDatabaseBackupTableScope("exclude", ["orders"], ["orders", "Orders"], "app", "app", false);
|
||||
assert.deepEqual(caseInsensitive, {
|
||||
includedTables: [],
|
||||
excludedTables: ["orders", "Orders"],
|
||||
});
|
||||
});
|
||||
|
||||
test("retention never selects failed backup runs", () => {
|
||||
const failed = { ...run("failed", "2026-07-16T04:00:00.000Z"), status: "failed" as const };
|
||||
const successful = [run("new", "2026-07-16T03:00:00.000Z"), run("old", "2026-07-16T01:00:00.000Z")];
|
||||
|
||||
Reference in new issue
Block a user