diff --git a/crates/dbx-core/src/schema/mod.rs b/crates/dbx-core/src/schema/mod.rs index 69dee5bdc6..8e4db3f85d 100644 --- a/crates/dbx-core/src/schema/mod.rs +++ b/crates/dbx-core/src/schema/mod.rs @@ -11809,6 +11809,50 @@ mod ddl_tests { assert!(ddl.contains("@value=N' User table '")); } + #[test] + fn sqlserver_table_ddl_renders_referential_actions_once_per_constraint() { + let fk_with_actions = |name: &str, columns: &[(&str, &str)]| db::ForeignKeyInfo { + name: name.to_string(), + column: columns[0].0.to_string(), + ref_schema: Some("dbo".to_string()), + ref_table: "parent".to_string(), + ref_column: columns[0].1.to_string(), + on_update: Some("SET NULL".to_string()), + on_delete: Some("CASCADE".to_string()), + }; + let composite = [ + fk_with_actions("fk_pair", &[("a", "pa")]), + db::ForeignKeyInfo { + column: "b".to_string(), + ref_column: "pb".to_string(), + ..fk_with_actions("fk_pair", &[("a", "pa")]) + }, + ]; + let ddl = render_sqlserver_table_ddl("dbo", "child", &[column("a", "int")], &[], &composite, None); + assert!( + ddl.contains("REFERENCES [dbo].[parent]([pa], [pb]) ON DELETE CASCADE ON UPDATE SET NULL"), + "actions once at constraint tail: {ddl}" + ); + assert_eq!(ddl.matches("ON DELETE").count(), 1, "ddl: {ddl}"); + assert_eq!(ddl.matches("ON UPDATE").count(), 1, "ddl: {ddl}"); + } + + #[test] + fn sqlserver_table_ddl_qualifies_cross_schema_references() { + let cross_schema = db::ForeignKeyInfo { + name: "fk_other".to_string(), + column: "ref_id".to_string(), + ref_schema: Some("other".to_string()), + ref_table: "target".to_string(), + ref_column: "id".to_string(), + on_update: Some("NO ACTION".to_string()), + on_delete: None, + }; + let ddl = render_sqlserver_table_ddl("dbo", "child", &[column("ref_id", "int")], &[], &[cross_schema], None); + assert!(ddl.contains("REFERENCES [other].[target]([id])"), "cross-schema reference qualified: {ddl}"); + assert!(!ddl.contains("ON UPDATE"), "NO ACTION omitted: {ddl}"); + } + #[test] fn sqlserver_table_ddl_includes_identity_clause() { let mut id = column("FIDS", "int"); @@ -11843,14 +11887,14 @@ mod ddl_tests { assert!( ddl.contains( - "CONSTRAINT [FK_TRIGGERS_JOB] FOREIGN KEY ([sched_name], [job_name], [job_group]) REFERENCES [JOB_DETAILS]([sched_name], [job_name], [job_group])" + "CONSTRAINT [FK_TRIGGERS_JOB] FOREIGN KEY ([sched_name], [job_name], [job_group]) REFERENCES [dbo].[JOB_DETAILS]([sched_name], [job_name], [job_group])" ), "ddl: {ddl}" ); assert_eq!(ddl.matches("CONSTRAINT [FK_TRIGGERS_JOB]").count(), 1, "ddl: {ddl}"); assert!( ddl.contains( - "CONSTRAINT [FK_TRIGGERS_CAL] FOREIGN KEY ([calendar_name]) REFERENCES [CALENDARS]([calendar_name])" + "CONSTRAINT [FK_TRIGGERS_CAL] FOREIGN KEY ([calendar_name]) REFERENCES [dbo].[CALENDARS]([calendar_name])" ), "ddl: {ddl}" ); @@ -13500,6 +13544,17 @@ pub async fn build_sqlserver_ddl( Ok(render_sqlserver_table_ddl(schema, table, &columns, &indexes, &fkeys, table_comment.as_deref())) } +fn sqlserver_fk_action_clause(kind: &str, value: Option<&str>) -> String { + let Some(value) = value else { + return String::new(); + }; + match value.trim().to_ascii_uppercase().as_str() { + "CASCADE" | "SET NULL" | "SET DEFAULT" => format!(" ON {kind} {}", value.trim().to_ascii_uppercase()), + // NO ACTION / RESTRICT are the default semantics; SQL Server only accepts NO ACTION. + _ => String::new(), + } +} + pub fn render_sqlserver_table_ddl( schema: &str, table: &str, @@ -13541,11 +13596,19 @@ pub fn render_sqlserver_table_ddl( }; let columns = fk_group.iter().map(|fk| sqlserver_ident(&fk.column)).collect::>().join(", "); let ref_columns = fk_group.iter().map(|fk| sqlserver_ident(&fk.ref_column)).collect::>().join(", "); + let ref_table = match first_fk.ref_schema.as_deref().map(str::trim) { + Some(ref_schema) if !ref_schema.is_empty() => { + format!("{}.{}", sqlserver_ident(ref_schema), sqlserver_ident(&first_fk.ref_table)) + } + _ => sqlserver_ident(&first_fk.ref_table), + }; + let on_delete = sqlserver_fk_action_clause("DELETE", first_fk.on_delete.as_deref()); + let on_update = sqlserver_fk_action_clause("UPDATE", first_fk.on_update.as_deref()); ddl.push_str(&format!( - ",\n CONSTRAINT {} FOREIGN KEY ({}) REFERENCES {}({})", + ",\n CONSTRAINT {} FOREIGN KEY ({}) REFERENCES {}({}){on_delete}{on_update}", sqlserver_ident(&first_fk.name), columns, - sqlserver_ident(&first_fk.ref_table), + ref_table, ref_columns )); } diff --git a/crates/dbx-drivers/src/db/sqlserver.rs b/crates/dbx-drivers/src/db/sqlserver.rs index f9c8915c14..f06e319a99 100644 --- a/crates/dbx-drivers/src/db/sqlserver.rs +++ b/crates/dbx-drivers/src/db/sqlserver.rs @@ -3016,7 +3016,8 @@ pub async fn list_foreign_keys( table: &str, ) -> Result, String> { let sql = format!( - "SELECT fk.name, c.name, SCHEMA_NAME(rt.schema_id), rt.name, rc.name \ + "SELECT fk.name, c.name, SCHEMA_NAME(rt.schema_id), rt.name, rc.name, \ + fk.delete_referential_action, fk.update_referential_action \ FROM sys.foreign_keys fk \ JOIN sys.foreign_key_columns fkc ON fk.object_id = fkc.constraint_object_id \ JOIN sys.columns c ON fkc.parent_object_id = c.object_id AND fkc.parent_column_id = c.column_id \ @@ -3037,12 +3038,23 @@ pub async fn list_foreign_keys( ref_schema: Some(row.get::<&str, _>(2).unwrap_or("").to_string()), ref_table: row.get::<&str, _>(3).unwrap_or("").to_string(), ref_column: row.get::<&str, _>(4).unwrap_or("").to_string(), - on_update: None, - on_delete: None, + on_update: sqlserver_referential_action(row.get::(6).unwrap_or(0)), + on_delete: sqlserver_referential_action(row.get::(5).unwrap_or(0)), }) .collect()) } +/// sys.foreign_keys referential actions: 0 = NO ACTION (default, omitted), +/// 1 = CASCADE, 2 = SET NULL, 3 = SET DEFAULT. +fn sqlserver_referential_action(code: i32) -> Option { + match code { + 1 => Some("CASCADE".to_string()), + 2 => Some("SET NULL".to_string()), + 3 => Some("SET DEFAULT".to_string()), + _ => None, + } +} + pub async fn get_table_comment( client: &mut SqlServerClient, schema: &str,