fix(sidebar): show disabled trigger indicators

Closes #8697
This commit is contained in:
t8y2 committed 2026-09-18 01:32:31 +08:00
1 parent 717cc318ed
commit 7b164d0084
3 files changed
+251 -3

No files matched your search

@@ -38,7 +38,7 @@ function objectGroup(type: "group-triggers" | "group-synonyms" | "group-types",
};
}
async function createStore({ listObjects, listTriggers }: { listObjects: ReturnType<typeof vi.fn>; listTriggers: ReturnType<typeof vi.fn> }) {
async function createStore({ listObjects, listTriggers, connection = mysqlConnection() }: { listObjects: ReturnType<typeof vi.fn>; listTriggers: ReturnType<typeof vi.fn>; connection?: ConnectionConfig }) {
vi.doMock("@/lib/backend/tauriRuntime", () => ({ isTauriRuntime: () => false }));
vi.doMock("@/lib/backend/api", () => ({
checkConnectionHealth: vi.fn().mockResolvedValue(undefined),
@@ -55,7 +55,6 @@ async function createStore({ listObjects, listTriggers }: { listObjects: ReturnT
const { useConnectionStore } = await import("@/stores/connectionStore");
const { useSettingsStore } = await import("@/stores/settingsStore");
const store = useConnectionStore();
const connection = mysqlConnection();
store.connections = [connection];
store.connectedIds.add(connection.id);
useSettingsStore().desktopSettings.sidebar_table_page_size = 10;
@@ -130,6 +129,46 @@ describe("sidebar object-group routing", () => {
});
});
it("preserves SQL Server table trigger status metadata across refreshes", async () => {
const listObjects = vi.fn<() => Promise<ObjectInfo[]>>().mockResolvedValue([]);
const listTriggers = vi.fn<() => Promise<TriggerInfo[]>>();
const { connection, store } = await createStore({
listObjects,
listTriggers,
connection: { ...mysqlConnection(), id: "sqlserver-1", name: "SQL Server", db_type: "sqlserver", port: 1433 },
});
const tableTriggerGroup: TreeNode = {
...objectGroup("group-triggers", `${connection.id}:app:dbo:orders:__triggers`),
connectionId: connection.id,
schema: "dbo",
tableName: "orders",
};
store.treeNodes = [{ id: connection.id, label: connection.name, type: "connection", connectionId: connection.id, children: [tableTriggerGroup] }];
const storedTriggerGroup = store.treeNodes[0].children![0];
for (const enabled of [false, true, undefined, null, false]) {
const trigger: TriggerInfo = { name: "trg_orders_audit", timing: "AFTER", event: "UPDATE", enabled };
listTriggers.mockResolvedValueOnce([trigger]);
await loadSidebarObjectGroup(storedTriggerGroup, store);
expect(storedTriggerGroup.children).toHaveLength(1);
expect(storedTriggerGroup.children![0]).toMatchObject({
id: `${tableTriggerGroup.id}:trg_orders_audit`,
label: "trg_orders_audit (AFTER UPDATE)",
objectName: trigger.name,
type: "trigger",
tableName: "orders",
meta: trigger,
});
expect((storedTriggerGroup.children![0].meta as TriggerInfo).enabled).toBe(enabled);
expect(storedTriggerGroup.children![0].valid).toBeUndefined();
}
expect(listTriggers).toHaveBeenCalledTimes(5);
expect(listTriggers).toHaveBeenLastCalledWith(connection.id, "app", "dbo", "orders", undefined);
expect(listObjects).not.toHaveBeenCalled();
});
it("propagates rejected schema-level metadata while clearing the loading state", async () => {
const listObjects = vi.fn<() => Promise<ObjectInfo[]>>().mockRejectedValue(new Error("metadata access denied"));
const listTriggers = vi.fn<() => Promise<never[]>>().mockResolvedValue([]);