github/dbx
4
0 Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-11-15 14:52:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(export): release db backup snapshot only on terminal state

Browse Source
This commit is contained in:
zipg authored and GitHub committed 2026-08-07 13:44:13 +08:00
1 parent f9e93b356f
commit 7d2a5d3355
8 files changed
+59 -12
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

apps/desktop/src/components/export/DatabaseExportDialog.vue
+5 -5
View File
@@ -12,7 +12,7 @@ import * as api from "@/lib/backend/api";
import type { ExportProgress } from "@/lib/backend/api";
import { isSchemaAware } from "@/lib/database/databaseFeatureSupport";
import { databaseOptionsForConnection } from "@/composables/useDatabaseOptions";
import { buildAllDatabaseExportPlan, generateDatabaseExportId, runDatabaseExportUntilTerminal, runWithDatabaseBackupSnapshot, type AllDatabaseExportPlanItem } from "@/lib/export/databaseExport";
import { buildAllDatabaseExportPlan, generateDatabaseExportId, runDatabaseExportUntilTerminal, runWithDatabaseBackupSnapshot, shouldUseDatabaseBackupSnapshot, type AllDatabaseExportPlanItem } from "@/lib/export/databaseExport";
import { buildSelectedTablesPayload } from "@/lib/export/databaseExportSelection";
import { isTauriRuntime } from "@/lib/backend/tauriRuntime";
import { useToast } from "@/composables/useToast";
@@ -304,7 +304,7 @@ async function startExport() {
{
connectionId: connectionId.value,
database: database.value,
enabled: includeData.value && (connectionType === "mysql" || connectionType === "postgres"),
enabled: shouldUseDatabaseBackupSnapshot(connectionType, includeData.value, isTauriRuntime()),
},
async (snapshotSessionId) => {
const request: api.DatabaseExportRequest = {
@@ -323,7 +323,7 @@ async function startExport() {
snapshotSessionId,
batchSize: 1000,
};
await api.exportDatabaseSql(request, (progress) => {
return runDatabaseExportUntilTerminal(request, (progress) => {
exportProgress.value = { ...progress };
updateDatabaseExportTask(progress.exportId, progress);
if (progress.status === "Done") {
@@ -342,7 +342,7 @@ async function startExport() {
}
});
},
() => !exportError.value && !exportCancelled.value,
(terminal) => terminal.status === "Done",
);
} catch (e: any) {
exportError.value = e?.message || String(e);
@@ -438,7 +438,7 @@ async function startAllDatabasesExport() {
{
connectionId: connectionId.value,
database: item.database,
enabled: includeData.value && (connectionType === "mysql" || connectionType === "postgres"),
enabled: shouldUseDatabaseBackupSnapshot(connectionType, includeData.value, isTauriRuntime()),
},
(snapshotSessionId) =>
runDatabaseExportUntilTerminal(