github/dbx
4
0 Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-11-15 22:53:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(completion): respect identifier quoting for upper-folding dialects

Browse Source 
Closes #9775
This commit is contained in:
skyler authored and t8y2 committed 2026-09-21 01:44:23 +08:00
1 parent d66242508e
commit 7e5bcade78
2 files changed
+50 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

apps/desktop/src/lib/sql/sqlCompletion.ts
+3 -2
View File
@@ -1659,8 +1659,9 @@ class SqlCompletionProvider {
) {
this.t = input.translations;
const dialect = sqlCompletionApplyDialect(input.databaseType, input.dialect);
// "Quote identifiers in generated SQL" off: Oracle completion inserts bare names instead of quoting lowercase ones.
this.dialect = dialect === "oracle" && input.quoteIdentifiers === false ? undefined : dialect;
// "Quote identifiers in generated SQL" off: Oracle-like and upper-folding (Dameng, DB2)
// completions insert bare names instead of quoting mixed-case ones.
this.dialect = input.quoteIdentifiers === false && (dialect === "oracle" || dialect === "upper") ? undefined : dialect;
this.databaseType = input.databaseType;
}