fix(sqlserver): recognize datepart function arguments

This commit is contained in:
t8y2 committed 2026-07-21 19:45:59 +08:00
1 parent b513d87750
commit 8126303e64
2 files changed
+314 -4

No files matched your search

+98 -4
View File
@@ -80,6 +80,7 @@ struct Analyzer {
scopes: Vec<SqlReferenceScope>,
scope_stack: Vec<usize>,
next_scope_id: usize,
is_sqlserver: bool,
}
pub fn analyze_sql_references(sql: &str, dialect: Option<&str>) -> Result<SqlReferenceAnalysis, String> {
@@ -107,7 +108,7 @@ pub fn analyze_sql_references(sql: &str, dialect: Option<&str>) -> Result<SqlRef
}
.map_err(|err| err.to_string())?;
let mut analyzer = Analyzer::default();
let mut analyzer = Analyzer { is_sqlserver: normalized_dialect == "sqlserver", ..Analyzer::default() };
for statement in statements {
analyzer.visit_statement(&statement);
}
@@ -457,7 +458,7 @@ impl Analyzer {
}
Expr::Function(function) => {
self.visit_function_args(&function.parameters);
self.visit_function_args(&function.args);
self.visit_function_call_args(&function.name, &function.args);
if let Some(filter) = &function.filter {
self.visit_expr(filter);
}
@@ -483,11 +484,30 @@ impl Analyzer {
}
fn visit_function_args(&mut self, args: &FunctionArguments) {
self.visit_function_args_skipping(args, |_, _| false);
}
fn visit_function_call_args(&mut self, name: &ObjectName, args: &FunctionArguments) {
let sqlserver_datepart_function = self.is_sqlserver.then(|| sqlserver_datepart_function_name(name)).flatten();
self.visit_function_args_skipping(args, |index, arg| {
index == 0
&& sqlserver_datepart_function
.is_some_and(|function_name| is_sqlserver_datepart_argument(function_name, arg))
});
}
fn visit_function_args_skipping(
&mut self,
args: &FunctionArguments,
mut should_skip: impl FnMut(usize, &FunctionArg) -> bool,
) {
match args {
FunctionArguments::Subquery(query) => self.visit_child_query(query),
FunctionArguments::List(list) => {
for arg in &list.args {
self.visit_function_arg(arg);
for (index, arg) in list.args.iter().enumerate() {
if !should_skip(index, arg) {
self.visit_function_arg(arg);
}
}
for clause in &list.clauses {
if let sqlparser::ast::FunctionArgumentClause::OrderBy(items) = clause {
@@ -538,3 +558,77 @@ fn table_reference_from_name(
fn object_name_last_ident(name: &ObjectName) -> Option<&Ident> {
name.0.iter().rev().find_map(ObjectNamePart::as_ident)
}
fn sqlserver_datepart_function_name(name: &ObjectName) -> Option<&str> {
if name.0.len() != 1 {
return None;
}
let ident = name.0.first()?.as_ident()?;
["DATEADD", "DATEDIFF", "DATEDIFF_BIG", "DATEPART", "DATENAME"]
.iter()
.copied()
.find(|function_name| ident.value.eq_ignore_ascii_case(function_name))
}
fn is_sqlserver_datepart_argument(function_name: &str, arg: &FunctionArg) -> bool {
let FunctionArg::Unnamed(FunctionArgExpr::Expr(Expr::Identifier(ident))) = arg else {
return false;
};
if ident.quote_style.is_some() {
return false;
}
// SQL Server parses datepart tokens as identifiers, but these built-ins treat the first token as grammar, not a column.
let datepart = ident.value.as_str();
let common_datepart = is_datepart(
datepart,
&[
"year",
"yy",
"yyyy",
"quarter",
"qq",
"q",
"month",
"mm",
"m",
"dayofyear",
"dy",
"y",
"day",
"dd",
"d",
"week",
"wk",
"ww",
"hour",
"hh",
"minute",
"mi",
"n",
"second",
"ss",
"s",
"millisecond",
"ms",
"microsecond",
"mcs",
"nanosecond",
"ns",
],
);
let weekday_datepart = is_datepart(datepart, &["weekday", "dw", "w"]);
let extended_datepart = is_datepart(datepart, &["tzoffset", "tz", "iso_week", "isowk", "isoww"]);
match function_name {
"DATEADD" | "DATEDIFF" | "DATEDIFF_BIG" => common_datepart || weekday_datepart,
"DATEPART" => common_datepart || weekday_datepart || extended_datepart,
"DATENAME" => common_datepart || weekday_datepart || extended_datepart,
_ => false,
}
}
fn is_datepart(value: &str, valid_dateparts: &[&str]) -> bool {
valid_dateparts.iter().any(|datepart| value.eq_ignore_ascii_case(datepart))
}