fix(grid): restore keyboard focus after tab switches
This commit is contained in:
1 parent
ae87353a28
commit
8228c2af17
3 files changed
+142
-1
No files matched your search
@@ -0,0 +1,68 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { resolveGridFocusRestoreTarget } from "@/lib/dataGrid/dataGridFocusRestore";
|
||||
|
||||
function element(overrides: { connected?: boolean; children?: HTMLElement[]; closest?: Record<string, HTMLElement | null>; ownerDocument?: { body: HTMLElement; documentElement: HTMLElement }; activeGrid?: boolean } = {}) {
|
||||
const children = overrides.children ?? [];
|
||||
const target = {
|
||||
isConnected: overrides.connected ?? true,
|
||||
contains: (other: Element | null) => !!other && (children as Element[]).includes(other),
|
||||
closest: (selector: string) => overrides.closest?.[selector] ?? null,
|
||||
ownerDocument: overrides.ownerDocument,
|
||||
dataset: overrides.activeGrid === undefined ? {} : { gridActive: String(overrides.activeGrid) },
|
||||
} as unknown as HTMLElement;
|
||||
return target;
|
||||
}
|
||||
|
||||
describe("resolveGridFocusRestoreTarget", () => {
|
||||
it("returns null when the grid never held focus", () => {
|
||||
const root = element();
|
||||
expect(resolveGridFocusRestoreTarget(root, null, null)).toBeNull();
|
||||
});
|
||||
|
||||
it("returns null when focus is already inside the grid", () => {
|
||||
const input = element();
|
||||
const root = element({ children: [input] });
|
||||
expect(resolveGridFocusRestoreTarget(root, input, input)).toBeNull();
|
||||
});
|
||||
|
||||
it("restores the last focused inner element when focus was left on the tab strip", () => {
|
||||
const searchInput = element();
|
||||
const root = element({ children: [searchInput] });
|
||||
const tabButton = element({ closest: { ".app-tab-bar, [role='tab'], [role='tablist']": element() } });
|
||||
expect(resolveGridFocusRestoreTarget(root, searchInput, tabButton)).toBe(searchInput);
|
||||
});
|
||||
|
||||
it("falls back to the grid root when the last focused element was removed", () => {
|
||||
const staleEditor = element({ connected: false });
|
||||
const root = element();
|
||||
const tabButton = element({ closest: { ".app-tab-bar, [role='tab'], [role='tablist']": element() } });
|
||||
expect(resolveGridFocusRestoreTarget(root, staleEditor, tabButton)).toBe(root);
|
||||
});
|
||||
|
||||
it("falls back to the grid root from body when the last focused element moved", () => {
|
||||
const movedElsewhere = element();
|
||||
const body = element();
|
||||
const documentElement = element();
|
||||
const root = element({ ownerDocument: { body, documentElement } });
|
||||
expect(resolveGridFocusRestoreTarget(root, movedElsewhere, body)).toBe(root);
|
||||
});
|
||||
|
||||
it("does not steal focus from an external dialog or editor", () => {
|
||||
const searchInput = element();
|
||||
const root = element({ children: [searchInput] });
|
||||
const dialogInput = element();
|
||||
expect(resolveGridFocusRestoreTarget(root, searchInput, dialogInput)).toBeNull();
|
||||
});
|
||||
|
||||
it("restores from an inactive grid but not from another active grid", () => {
|
||||
const searchInput = element();
|
||||
const root = element({ children: [searchInput] });
|
||||
const inactiveGrid = element({ activeGrid: false });
|
||||
const inactiveGridInput = element({ closest: { "[data-grid-root]": inactiveGrid } });
|
||||
expect(resolveGridFocusRestoreTarget(root, searchInput, inactiveGridInput)).toBe(searchInput);
|
||||
|
||||
const activeGrid = element({ activeGrid: true });
|
||||
const activeGridInput = element({ closest: { "[data-grid-root]": activeGrid } });
|
||||
expect(resolveGridFocusRestoreTarget(root, searchInput, activeGridInput)).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,34 @@
|
||||
/**
|
||||
* Decide where focus should go when a kept-alive data grid becomes active
|
||||
* again after a tab switch.
|
||||
*
|
||||
* Switching away from a tab moves focus to the tab strip, body, or an element
|
||||
* inside the grid that is being deactivated. Focus is restored only from one
|
||||
* of those states so activation never steals focus from a dialog, editor,
|
||||
* input, menu, or another active grid.
|
||||
*
|
||||
* Returns null when no focus restore should happen: the grid never held
|
||||
* focus, or focus is already inside the grid (e.g. the cell editor restored
|
||||
* its own input focus first).
|
||||
*/
|
||||
export function resolveGridFocusRestoreTarget(root: HTMLElement | null | undefined, lastFocusedWithinGrid: HTMLElement | null | undefined, activeElement: Element | null): HTMLElement | null {
|
||||
if (!root || !lastFocusedWithinGrid) return null;
|
||||
if (root.contains(activeElement)) return null;
|
||||
if (!gridFocusCanTransferFrom(root, activeElement)) return null;
|
||||
if (lastFocusedWithinGrid.isConnected && root.contains(lastFocusedWithinGrid)) {
|
||||
return lastFocusedWithinGrid;
|
||||
}
|
||||
return root;
|
||||
}
|
||||
|
||||
function gridFocusCanTransferFrom(root: HTMLElement, activeElement: Element | null): boolean {
|
||||
if (!activeElement || !activeElement.isConnected) return true;
|
||||
const ownerDocument = root.ownerDocument;
|
||||
if (activeElement === ownerDocument?.body || activeElement === ownerDocument?.documentElement) return true;
|
||||
|
||||
const closest = (activeElement as HTMLElement).closest?.bind(activeElement as HTMLElement);
|
||||
if (!closest) return false;
|
||||
const activeGrid = closest("[data-grid-root]") as HTMLElement | null;
|
||||
if (activeGrid && activeGrid !== root) return activeGrid.dataset.gridActive !== "true";
|
||||
return !!closest(".app-tab-bar, [role='tab'], [role='tablist']");
|
||||
}
|
||||
Reference in new issue
Block a user