fix(structure): virtualize column grid for smooth large-table scrolling

This commit is contained in:
t8y2 committed 2026-09-22 03:12:35 +08:00
1 parent f425b9b9d1
commit 84171f635a
6 files changed
+962 -519

No files matched your search

@@ -93,6 +93,9 @@ const triggerBaseClass = computed(() =>
const filteredOptions = computed(() => filterDatabaseOptions(props.options, searchText.value, props.displayName));
const customOptionValue = computed(() => props.normalizeCustom(props.trimCustom ? searchText.value.trim() : searchText.value));
const canSelectCustom = computed(() => props.allowCustom && !!customOptionValue.value && !props.options.includes(customOptionValue.value));
const closedFilteredOptions: string[] = [];
const openFilteredOptions = computed(() => (open.value ? filteredOptions.value : closedFilteredOptions));
const openOptionsSignature = computed(() => (open.value ? props.options.join("\0") : ""));
function highlightSelectedOption() {
const selectedIndex = filteredOptions.value.findIndex((option) => option === props.modelValue);
@@ -134,22 +137,20 @@ watch(open, async (value) => {
});
watch(searchText, () => {
if (!open.value) return;
highlightIndex.value = 0;
activeHelpOption.value = searchableSelectKeyboardTooltipOption(filteredOptions.value, 0, props.optionTooltip);
});
watch(
() => [props.modelValue, props.options],
() => {
if (!open.value || searchText.value) return;
activeHelpOption.value = undefined;
highlightAndScrollSelectedOption();
activateInitialHelpOption();
},
{ deep: true },
);
watch([() => (open.value ? props.modelValue : undefined), openOptionsSignature], ([_modelValue], [previousModelValue]) => {
if (!open.value || previousModelValue === undefined || searchText.value) return;
activeHelpOption.value = undefined;
highlightAndScrollSelectedOption();
activateInitialHelpOption();
});
watch([highlightIndex, filteredOptions], () => {
watch([highlightIndex, openFilteredOptions], () => {
if (!open.value) return;
void scrollHighlightedOptionIntoView();
emit("option-highlight", filteredOptions.value[highlightIndex.value]);
});
@@ -186,7 +187,8 @@ async function updateHelpPanelOffset() {
});
}
watch([activeHelpOption, filteredOptions], () => {
watch([activeHelpOption, openFilteredOptions], () => {
if (!open.value) return;
void updateHelpPanelOffset();
});
@@ -34,6 +34,23 @@ afterEach(() => {
});
describe("SearchableSelect trigger", () => {
it("does not traverse option values while the popover is closed", () => {
let optionReads = 0;
const options = ["Point", "LineString"];
Object.defineProperty(options, "1", {
configurable: true,
enumerable: true,
get() {
optionReads += 1;
return "LineString";
},
});
mountSelect({ options });
expect(optionReads).toBe(0);
});
it("renders the trigger button itself as the layout participant", () => {
const { root } = mountSelect({ triggerClass: "min-w-0 flex-1" });