github/dbx
4
0 Fork 0
mirror of https://github.com/t8y2/dbx.git synced 2026-11-15 14:52:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(objects): open view data tab on double-click and stop source toggle-off

Browse Source
This commit is contained in:
Terry Yao authored and GitHub committed 2026-09-20 13:49:05 +08:00
1 parent 555cb25c4f
commit 853a408d30
3 files changed
+24 -14
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

apps/desktop/src/lib/__tests__/table/objectBrowserRowAction.spec.ts
Vendored
+12 -8
View File
@@ -76,8 +76,8 @@ describe("doubleClickRowAction", () => {
expect(doubleClickRowAction(row("TABLE", "orders"))).toBe("open-table");
});
it("returns open-source for VIEW", () => {
expect(doubleClickRowAction(row("VIEW", "v_orders"))).toBe("open-source");
it.each(["VIEW", "MATERIALIZED_VIEW"] as const)("returns open-table for %s like the sidebar data nodes", (type) => {
expect(doubleClickRowAction(row(type, "v_orders"))).toBe("open-table");
});
it("returns open-source for PROCEDURE", () => {
@@ -123,9 +123,9 @@ describe("resolveRowClickAction", () => {
expect(result.isDouble).toBe(false);
});
it("double click on VIEW returns open-source", () => {
it("double click on VIEW returns open-table", () => {
const result = resolveRowClickAction(viewRow, 2, "single");
expect(result.action).toBe("open-source");
expect(result.action).toBe("open-table");
expect(result.isDouble).toBe(true);
});
});
@@ -149,9 +149,9 @@ describe("resolveRowClickAction", () => {
expect(result.isDouble).toBe(true);
});
it("double click on VIEW returns open-source", () => {
it("double click on VIEW returns open-table", () => {
const result = resolveRowClickAction(viewRow, 2, "double");
expect(result.action).toBe("open-source");
expect(result.action).toBe("open-table");
expect(result.isDouble).toBe(true);
});
});
@@ -165,8 +165,12 @@ describe("shouldDeferSingleClick", () => {
expect(shouldDeferSingleClick(tableRow, "table-info")).toBe(true);
});
it("does not defer VIEW open-source (same single/double action)", () => {
expect(shouldDeferSingleClick(viewRow, "open-source")).toBe(false);
it("defers VIEW open-source (distinct single/double actions)", () => {
expect(shouldDeferSingleClick(viewRow, "open-source")).toBe(true);
});
it("does not defer PROCEDURE open-source (same single/double action)", () => {
expect(shouldDeferSingleClick(row("PROCEDURE", "sp_run"), "open-source")).toBe(false);
});
it("does not defer none action", () => {