feat(sqlite): support attached database schema changes
This commit is contained in:
41 files changed
+1219
-129
No files matched your search
@@ -162,6 +162,16 @@ describe("useNavigationTargets openTableTarget", () => {
|
||||
expect(mocks.tabs[0]?.tableMetaPending).toBe(true);
|
||||
});
|
||||
|
||||
it("uses the SQLite attached database as the table namespace when a target omits schema", async () => {
|
||||
mocks.databaseType = "sqlite";
|
||||
|
||||
await useNavigationTargets(dialogs).openLineageTarget({ connectionId: "connection-1", database: "analytics", tableName: "events" });
|
||||
|
||||
expect(mocks.tabs[0]?.schema).toBe("analytics");
|
||||
expect(mocks.tabs[0]?.tableMeta?.schema).toBe("analytics");
|
||||
expect(mocks.getColumns.mock.calls.some(([connectionId, database, schema, tableName]) => connectionId === "connection-1" && database === "analytics" && schema === "analytics" && tableName === "events")).toBe(true);
|
||||
});
|
||||
|
||||
it("does not let a stale navigation land metadata over a newer target on a reused tab", async () => {
|
||||
// A 的 getColumns 挂起;B 复用同一 tab 后 A 才返回
|
||||
const columnGates = new Map<string, (columns: unknown[]) => void>();
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
import * as api from "@/lib/backend/api";
|
||||
import { effectiveDatabaseTypeForConnection, metadataSchemaForConnection } from "@/lib/database/jdbcDialect";
|
||||
import { connectionObjectTreeNodeSchema, effectiveDatabaseTypeForConnection, metadataSchemaForConnection } from "@/lib/database/jdbcDialect";
|
||||
import { invalidateTableMetadataCache, loadTableMetadata } from "@/lib/metadata/tableMetadataCache";
|
||||
import { canApplyDataTabMetadata } from "@/lib/sidebar/dataTabOpenPolicy";
|
||||
import { isNoSnapshotErrorResult } from "@/lib/query/queryResultError";
|
||||
@@ -32,7 +32,8 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
|
||||
connectionStore.activeConnectionId = target.connectionId;
|
||||
const config = connectionStore.getConfig(target.connectionId);
|
||||
const tabTitle = target.catalog ? `${target.catalog}.${target.schema || target.database}.${target.tableName}` : target.schema ? `${target.schema}.${target.tableName}` : target.tableName;
|
||||
const tableSchema = connectionObjectTreeNodeSchema(config, target.database, target.schema);
|
||||
const tabTitle = target.catalog ? `${target.catalog}.${tableSchema || target.database}.${target.tableName}` : tableSchema ? `${tableSchema}.${target.tableName}` : target.tableName;
|
||||
if (config?.db_type === "qdrant" || config?.db_type === "milvus" || config?.db_type === "weaviate" || config?.db_type === "chromadb") {
|
||||
await connectionStore.ensureConnected(target.connectionId);
|
||||
const tabId = queryStore.createTab(target.connectionId, target.database || "default", tabTitle, "vector");
|
||||
@@ -44,13 +45,13 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
const existing = queryStore.tabs.find((tab) => tab.mode === "data" && tab.connectionId === target.connectionId && tab.database === target.database && (tab.tableMeta?.catalog || "") === (target.catalog || ""));
|
||||
if (existing) {
|
||||
existing.title = tabTitle;
|
||||
existing.schema = target.schema;
|
||||
existing.schema = tableSchema;
|
||||
existing.tableInfoTab = options.tableInfoTab;
|
||||
queryStore.switchTab(existing.id);
|
||||
return existing.id;
|
||||
}
|
||||
}
|
||||
return queryStore.createTab(target.connectionId, target.database, tabTitle, "data", target.schema);
|
||||
return queryStore.createTab(target.connectionId, target.database, tabTitle, "data", tableSchema);
|
||||
})();
|
||||
const targetTab = queryStore.tabs.find((tab) => tab.id === tabId);
|
||||
if (targetTab) targetTab.tableInfoTab = options.tableInfoTab;
|
||||
@@ -58,7 +59,7 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
// filters, row count) never read a stale tableMeta from a reused tab or
|
||||
// fall back to parsing the schema-qualified tab title (issue #3613).
|
||||
queryStore.setTableMeta(tabId, {
|
||||
schema: target.schema,
|
||||
schema: tableSchema,
|
||||
catalog: target.catalog,
|
||||
database: target.database,
|
||||
tableName: target.tableName,
|
||||
@@ -89,7 +90,7 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
{
|
||||
connectionId: target.connectionId,
|
||||
database: target.database,
|
||||
schema: target.schema,
|
||||
schema: tableSchema,
|
||||
catalog: target.catalog,
|
||||
tableName: target.tableName,
|
||||
},
|
||||
@@ -113,7 +114,7 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
if (!config) throw new Error("Connection config not found");
|
||||
const effectiveDbType = effectiveDatabaseTypeForConnection(config);
|
||||
const identifierQuote = connectionStore.connectionIdentifierQuote?.(target.connectionId);
|
||||
const querySchema = metadataSchemaForConnection(config, target.database, target.schema);
|
||||
const querySchema = metadataSchemaForConnection(config, target.database, tableSchema);
|
||||
const targetTableType = target.tableType ?? "TABLE";
|
||||
if (config.db_type === "neo4j") {
|
||||
const columns = await api.getColumns(target.connectionId, target.database, querySchema, target.tableName);
|
||||
@@ -121,7 +122,7 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
const sql = await buildTableSelectSql({
|
||||
databaseType: effectiveDbType,
|
||||
identifierQuote,
|
||||
schema: target.schema,
|
||||
schema: tableSchema,
|
||||
catalog: target.catalog,
|
||||
database: target.database,
|
||||
tableName: target.tableName,
|
||||
@@ -136,7 +137,7 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
queryStore.setTableMeta(tabId, {
|
||||
catalog: target.catalog,
|
||||
database: target.database,
|
||||
schema: target.schema,
|
||||
schema: tableSchema,
|
||||
tableName: target.tableName,
|
||||
tableType: targetTableType,
|
||||
columns,
|
||||
@@ -149,7 +150,7 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
const sql = await buildTableSelectSql({
|
||||
databaseType: effectiveDbType,
|
||||
identifierQuote,
|
||||
schema: target.schema,
|
||||
schema: tableSchema,
|
||||
catalog: target.catalog,
|
||||
database: target.database,
|
||||
tableName: target.tableName,
|
||||
@@ -160,7 +161,7 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
if (!isPreparationCurrent()) return;
|
||||
queryStore.updateSql(tabId, sql);
|
||||
queryStore.setTableMeta(tabId, {
|
||||
schema: target.schema,
|
||||
schema: tableSchema,
|
||||
catalog: target.catalog,
|
||||
database: target.database,
|
||||
tableName: target.tableName,
|
||||
@@ -192,7 +193,7 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
const emptySql = await buildTableSelectSql({
|
||||
databaseType: effectiveDbType,
|
||||
identifierQuote,
|
||||
schema: target.schema,
|
||||
schema: tableSchema,
|
||||
catalog: target.catalog,
|
||||
database: target.database,
|
||||
tableName: target.tableName,
|
||||
@@ -224,7 +225,7 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
if (!isCurrentTarget()) return;
|
||||
const useRowId = usesSyntheticRowIdKey(effectiveDbType, primaryKeys, targetTableType);
|
||||
queryStore.setTableMeta(tabId, {
|
||||
schema: target.schema,
|
||||
schema: tableSchema,
|
||||
catalog: target.catalog,
|
||||
database: target.database,
|
||||
tableName: target.tableName,
|
||||
@@ -236,7 +237,7 @@ async function openTableTarget(target: NavigationTarget, options: { tableInfoTab
|
||||
const newSql = await buildTableSelectSql({
|
||||
databaseType: effectiveDbType,
|
||||
identifierQuote,
|
||||
schema: target.schema,
|
||||
schema: tableSchema,
|
||||
catalog: target.catalog,
|
||||
database: target.database,
|
||||
tableName: target.tableName,
|
||||
|
||||
Reference in new issue
Block a user